[DataFactory] [Bug Fix] Remove unnecessary additional properties for data flow flowlet. #16652

jackmagic313 · 2021-11-03T19:49:24Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-11-03T19:49:27Z

Hi, @jackmagic313 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-11-03T19:49:28Z

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.1)
- current:2018-06-01/entityTypes/DataFlow.json compared with base:2018-06-01/entityTypes/DataFlow.json

Rule	Message
`❌` 1022 - RemovedAdditionalProperties	The new version removes the 'additionalProperties' element. New: stable/2018-06-01/entityTypes/DataFlow.json#L69:5 Old: stable/2018-06-01/entityTypes/DataFlow.json#L69:5
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'additionalProperties' renamed or removed? New: stable/2018-06-01/entityTypes/DataFlow.json#L164:7 Old: stable/2018-06-01/entityTypes/DataFlow.json#L167:7

️🔄LintDiff inProgress [Detail]

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

datafactory/resource-manager/readme.md#package-2018-06

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-11-03T19:49:28Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-11-03T19:49:28Z

Swagger Generation Artifacts

️🔄[Staging] ApiDocPreview inProgress [Detail]

️❌[Staging] SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-datafactory - 2.0.0
❌azure-sdk-for-go - datafactory/mgmt/2018-06-01/datafactory - v59.0.0

❌azure-sdk-for-go - preview/datafactory/mgmt/2017-09-01-preview/datafactory - v59.0.0

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from a1d4992. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/datafactory/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.DataFactory [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.DataFactory.4.28.0.nupkg
- Microsoft.Azure.Management.DataFactory.4.28.0.symbols.nupkg

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from a1d4992. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-datafactory [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model DataFlowDebugPackage has a new parameter data_flows
info	[Changelog]   - Model MappingDataFlow has a new parameter script_lines
info	[Changelog]   - Model DataFlowReference has a new parameter parameters
info	[Changelog]   - Model DatasetCompression has a new parameter level
info	[Changelog]   - Model Transformation has a new parameter linked_service
info	[Changelog]   - Model Transformation has a new parameter flowlet
info	[Changelog]   - Model Transformation has a new parameter dataset
info	[Changelog]   - Model PowerQuerySource has a new parameter flowlet
info	[Changelog]   - Model PowerQuerySink has a new parameter flowlet
info	[Changelog]   - Model DataFlowSink has a new parameter flowlet
info	[Changelog]   - Model DataFlowSource has a new parameter flowlet

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from a1d4992. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-11-11 09:30:38 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-datafactory;1.0.0-beta.7;1.0.0-beta.8"
cmderr	[generate.py] 2021-11-11 09:30:38 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.8"
cmderr	[generate.py] 2021-11-11 09:30:38 INFO autorest --version=3.6.0 --use=@autorest/java@4.0.40 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/datafactory/azure-resourcemanager-datafactory --java.namespace=com.azure.resourcemanager.datafactory   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/datafactory/resource-manager/readme.md
cmderr	[generate.py] 2021-11-11 09:31:37 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-datafactory
cmderr	[generate.py] 2021-11-11 09:31:37 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-11-11 09:31:37 INFO [POM][Skip] pom already has module azure-resourcemanager-datafactory
cmderr	[generate.py] 2021-11-11 09:31:37 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-11-11 09:31:37 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-11-11 09:31:37 INFO [POM][Skip] pom already has module sdk/datafactory
cmderr	[generate.py] 2021-11-11 09:31:37 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-datafactory [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-11-11 09:34:23 DEBUG Got artifact_id: azure-resourcemanager-datafactory
cmderr	[Inst] 2021-11-11 09:34:23 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-11-11 09:34:23 DEBUG Got artifact: azure-resourcemanager-datafactory-1.0.0-beta.8.jar
cmderr	[Inst] 2021-11-11 09:34:23 DEBUG Match jar package: azure-resourcemanager-datafactory-1.0.0-beta.8.jar
cmderr	[Inst] 2021-11-11 09:34:23 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16652/azure-sdk-for-java/azure-resourcemanager-datafactory/azure-resourcemanager-datafactory-1.0.0-beta.8.jar\" -o azure-resourcemanager-datafactory-1.0.0-beta.8.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-datafactory -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-datafactory-1.0.0-beta.8.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from a1d4992. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️datafactory/mgmt/2018-06-01/datafactory [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 60 items here, please refer to log for details.

info	[Changelog] - Function `DatasetBZip2Compression.AsDatasetBZip2Compression` has been removed
info	[Changelog] - Function `*DatasetBZip2Compression.UnmarshalJSON` has been removed
info	[Changelog] - Function `DatasetTarGZipCompression.AsDatasetBZip2Compression` has been removed
info	[Changelog] - Function `DatasetGZipCompression.AsDatasetGZipCompression` has been removed
info	[Changelog] - Function `DatasetTarCompression.AsDatasetTarGZipCompression` has been removed
info	[Changelog] - Function `DatasetDeflateCompression.MarshalJSON` has been removed
info	[Changelog] - Function `DatasetCompression.AsDatasetZipDeflateCompression` has been removed
info	[Changelog] - Function `DatasetTarGZipCompression.AsDatasetZipDeflateCompression` has been removed
info	[Changelog] - Function `DatasetTarCompression.AsDatasetGZipCompression` has been removed
info	[Changelog] - Function `DatasetBZip2Compression.AsDatasetTarCompression` has been removed
info	[Changelog] - Function `DatasetTarCompression.AsDatasetCompression` has been removed
info	[Changelog] - Function `DatasetZipDeflateCompression.AsBasicDatasetCompression` has been removed
info	[Changelog] - Function `DatasetZipDeflateCompression.AsDatasetBZip2Compression` has been removed
info	[Changelog] - Function `DatasetBZip2Compression.MarshalJSON` has been removed
info	[Changelog] - Function `DatasetCompression.AsDatasetCompression` has been removed
info	[Changelog] - Function `DatasetZipDeflateCompression.AsDatasetDeflateCompression` has been removed
info	[Changelog] - Function `DatasetZipDeflateCompression.AsDatasetCompression` has been removed
info	[Changelog] - Function `DatasetTarGZipCompression.AsDatasetTarCompression` has been removed
info	[Changelog] - Function `DatasetGZipCompression.MarshalJSON` has been removed
info	[Changelog] - Struct `DatasetBZip2Compression` has been removed
info	[Changelog] - Struct `DatasetDeflateCompression` has been removed
info	[Changelog] - Struct `DatasetGZipCompression` has been removed
info	[Changelog] - Struct `DatasetTarCompression` has been removed
info	[Changelog] - Struct `DatasetTarGZipCompression` has been removed
info	[Changelog] - Struct `DatasetZipDeflateCompression` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `TypeBasicDataFlowTypeFlowlet`
info	[Changelog] - New function `*Flowlet.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `Flowlet.AsWranglingDataFlow() (*WranglingDataFlow, bool)`
info	[Changelog] - New function `Flowlet.AsFlowlet() (*Flowlet, bool)`
info	[Changelog] - New function `DataFlowReference.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `Flowlet.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `Flowlet.AsBasicDataFlow() (BasicDataFlow, bool)`
info	[Changelog] - New function `MappingDataFlow.AsFlowlet() (*Flowlet, bool)`
info	[Changelog] - New function `DataFlow.AsFlowlet() (*Flowlet, bool)`
info	[Changelog] - New function `Flowlet.AsMappingDataFlow() (*MappingDataFlow, bool)`
info	[Changelog] - New function `Flowlet.AsDataFlow() (*DataFlow, bool)`
info	[Changelog] - New function `WranglingDataFlow.AsFlowlet() (*Flowlet, bool)`
info	[Changelog] - New struct `Flowlet`
info	[Changelog] - New struct `FlowletTypeProperties`
info	[Changelog] - New struct `PowerQuerySinkMapping`
info	[Changelog] - New field `Flowlet` in struct `PowerQuerySource`
info	[Changelog] - New field `Dataset` in struct `Transformation`
info	[Changelog] - New field `LinkedService` in struct `Transformation`
info	[Changelog] - New field `Flowlet` in struct `Transformation`
info	[Changelog] - New field `ScriptLines` in struct `MappingDataFlowTypeProperties`
info	[Changelog] - New field `Level` in struct `DatasetCompression`
info	[Changelog] - New field `Flowlet` in struct `PowerQuerySink`
info	[Changelog] - New field `DataFlows` in struct `DataFlowDebugPackage`
info	[Changelog] - New field `Flowlet` in struct `DataFlowSink`
info	[Changelog] - New field `Flowlet` in struct `DataFlowSource`
info	[Changelog] - New field `Parameters` in struct `DataFlowReference`
info	[Changelog] - New field `DocumentLocale` in struct `PowerQueryTypeProperties`
info	[Changelog] - New field `PublicNetworkAccess` in struct `FactoryUpdateParameters`
info	[Changelog] - New field `Queries` in struct `ExecutePowerQueryActivityTypeProperties`
info	[Changelog]
info	[Changelog] Total 100 breaking change(s), 31 additive change(s).
info	[Changelog]

️✔️preview/datafactory/mgmt/2017-09-01-preview/datafactory [View full logs] Breaking Change Detected

Only show 60 items here, please refer to log for details.

info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `Insert`
info	[Changelog] - New const `Available`
info	[Changelog] - New const `QueryAll`
info	[Changelog] - New const `IntegrationRuntimeStateNeedRegistration`
info	[Changelog] - New const `Merge`
info	[Changelog] - New const `EACHQUORUM`
info	[Changelog] - New const `TWO`
info	[Changelog] - New const `IntegrationRuntimeStateStopping`
info	[Changelog] - New const `Fastest`
info	[Changelog] - New const `IntegrationRuntimeStateLimited`
info	[Changelog] - New const `Upsert`
info	[Changelog] - New const `IntegrationRuntimeStateStopped`
info	[Changelog] - New const `Office365`
info	[Changelog] - New const `Date`
info	[Changelog] - New const `Query`
info	[Changelog] - New const `SERIAL`
info	[Changelog] - New const `Value`
info	[Changelog] - New const `Int64`
info	[Changelog] - New const `Percentage`
info	[Changelog] - New const `String`
info	[Changelog] - New const `OnPremisesWithIfd`
info	[Changelog] - New const `IntegrationRuntimeStateStarting`
info	[Changelog] - New const `IntegrationRuntimeStateStarted`
info	[Changelog] - New const `Recycling`
info	[Changelog] - New const `Ifd`
info	[Changelog] - New const `SapCloudForCustomerSinkWriteBehaviorUpdate`
info	[Changelog] - New const `Upload`
info	[Changelog] - New const `Disabled`
info	[Changelog] - New const `LOCALQUORUM`
info	[Changelog] - New const `IntegrationRuntimeStateInitial`
info	[Changelog] - New const `ALL`
info	[Changelog] - New const `Boolean`
info	[Changelog] - New const `THREE`
info	[Changelog] - New const `IntegrationRuntimeStateOffline`
info	[Changelog] - New const `IntegrationRuntimeStateOnline`
info	[Changelog] - New const `Int`
info	[Changelog] - New const `Optimal`
info	[Changelog] - New const `GUID`
info	[Changelog] - New const `LOCALSERIAL`
info	[Changelog] - New const `Decimal`
info	[Changelog] - New const `QUORUM`
info	[Changelog] - New const `Unavailable`
info	[Changelog] - New const `SapCloudForCustomerSinkWriteBehaviorInsert`
info	[Changelog] - New const `LOCALONE`
info	[Changelog] - New const `ONE`
info	[Changelog] - New function `PossibleSapCloudForCustomerSinkWriteBehaviorValues() []SapCloudForCustomerSinkWriteBehavior`
info	[Changelog] - New function `PossibleCassandraSourceReadConsistencyLevelsValues() []CassandraSourceReadConsistencyLevels`
info	[Changelog] - New function `PossibleSalesforceSourceReadBehaviorValues() []SalesforceSourceReadBehavior`
info	[Changelog] - New function `PossibleDynamicsDeploymentTypeValues() []DynamicsDeploymentType`
info	[Changelog] - New function `PossibleAzureSearchIndexWriteBehaviorTypeValues() []AzureSearchIndexWriteBehaviorType`
info	[Changelog] - New function `PossibleStoredProcedureParameterTypeValues() []StoredProcedureParameterType`
info	[Changelog] - New function `PossibleSalesforceSinkWriteBehaviorValues() []SalesforceSinkWriteBehavior`
info	[Changelog] - New function `PossibleDatasetCompressionLevelValues() []DatasetCompressionLevel`
info	[Changelog] - New function `PossibleDynamicsAuthenticationTypeValues() []DynamicsAuthenticationType`
info	[Changelog] - New function `PossiblePolybaseSettingsRejectTypeValues() []PolybaseSettingsRejectType`
info	[Changelog]
info	[Changelog] Total 28 breaking change(s), 55 additive change(s).
info	[Changelog]

️❌ azure-sdk-for-go-track2 failed [Detail]

❌Failed [Logs]Release - Generate from a1d4992. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
cmderr	[generator automation-v2] [ERROR] total 1 error(s):
cmderr	[generator automation-v2] [ERROR] failed to execute `go generate` 'WARNING: Unable to find version for /home/vsts/work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/datafactory/armdatafactory
cmderr	[generator automation-v2] [ERROR] Cannot find go module under resourcemanager/datafactory/armdatafactory, try to build in /home/vsts/work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/datafactory/armdatafactory
cmderr	[generator automation-v2] [ERROR] ##[command]Cleaning auto-generated files in /home/vsts/work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/datafactory/armdatafactory
cmderr	[generator automation-v2] [ERROR] ##[command]Executing autorest.go in  /home/vsts/work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/datafactory/armdatafactory
cmderr	[generator automation-v2] [ERROR] AutoRest code generation utility [cli version: 3.2.3; node: v14.18.1, max-memory: 8192 MB]
cmderr	[generator automation-v2] [ERROR] (C) 2018 Microsoft Corporation.
cmderr	[generator automation-v2] [ERROR] https://aka.ms/autorest
cmderr	[generator automation-v2] [ERROR] NOTE: AutoRest core version selected from configuration: 3.6.2.
cmderr	[generator automation-v2] [ERROR] There is a new version of AutoRest available (3.4.2).
cmderr	[generator automation-v2] [ERROR] > You can install the newer version with with npm install -g autorest@latest
cmderr	[generator automation-v2] [ERROR] info    |    Loading AutoRest core      '/home/vsts/.autorest/@autorestcore@3.6.2/nodemodules/@autorest/core/dist' (3.6.2)
cmderr	[generator automation-v2] [ERROR] info    |    Loading AutoRest extension '@autorest/go' (4.0.0-preview.31->4.0.0-preview.31)
cmderr	[generator automation-v2] [ERROR] info    |    Loading AutoRest extension '@autorest/modelerfour' (4.21.1->4.21.1)
cmderr	[generator automation-v2] [ERROR] warning | IgnoredPropertyNextToRef | Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > PipelineRun > properties > invokedBy)
cmderr	[generator automation-v2] [ERROR] keys: [ �[32m'readOnly'�[39m ]
cmderr	[generator automation-v2] [ERROR] - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json:5789:9
cmderr	[generator automation-v2] [ERROR] fatal   | Process() cancelled due to failure
cmderr	[generator automation-v2] [ERROR] error   | DiscriminatorNotRequired | Semantic violation: Discriminator must be a required property. (components > schemas > DataFlow)
cmderr	[generator automation-v2] [ERROR] discriminator: { propertyName: �[32m'type'�[39m }
cmderr	[generator automation-v2] [ERROR] - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/DataFlow.json:20:5
cmderr	[generator automation-v2] [ERROR] Error: Semantic validation failed. There was some errors
cmderr	[generator automation-v2] [ERROR] ##[error]Error running autorest.go
cmderr	[generator automation-v2] [ERROR] build.go:5: running "pwsh.exe": exit status 1
cmderr	[generator automation-v2] [ERROR] ': exit status 1
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2
warn	Skip package processing as generation is failed

️🔄 azure-sdk-for-js inProgress [Detail]

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from a1d4992. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️datafactory [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-11-03T19:51:30Z

Hi @jackmagic313, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

remove unnecessary additional properties

0b9c5b0

jackmagic313 requested review from shawnxzq and zhangyd2015 as code owners November 3, 2021 19:49

openapi-assignment-bot bot assigned leni-msft Nov 3, 2021

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Nov 3, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Nov 3, 2021

openapi-sdkautomation bot mentioned this pull request Nov 3, 2021

[AutoPR Microsoft.Azure.Management.DataFactory] [DataFactory] [Bug Fix] Remove unnecessary additional properties for data flow flowlet. AzureSDKAutomation/azure-sdk-for-net#6514

Closed

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 4, 2021

leni-msft approved these changes Nov 11, 2021

View reviewed changes

leni-msft merged commit a1d4992 into Azure:main Nov 11, 2021

Jingshu923 mentioned this pull request Dec 1, 2021

[DataFactory]Added new features into 5.0.0 Azure/azure-sdk-for-net#25595

Merged

11 tasks

LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022

remove unnecessary additional properties (Azure#16652)

2c846a1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DataFactory] [Bug Fix] Remove unnecessary additional properties for data flow flowlet. #16652

[DataFactory] [Bug Fix] Remove unnecessary additional properties for data flow flowlet. #16652

jackmagic313 commented Nov 3, 2021

openapi-workflow-bot bot commented Nov 3, 2021

openapi-pipeline-app bot commented Nov 3, 2021 •

edited

Loading

openapi-workflow-bot bot commented Nov 3, 2021

openapi-pipeline-app bot commented Nov 3, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Nov 3, 2021

[DataFactory] [Bug Fix] Remove unnecessary additional properties for data flow flowlet. #16652

[DataFactory] [Bug Fix] Remove unnecessary additional properties for data flow flowlet. #16652

Conversation

jackmagic313 commented Nov 3, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Nov 3, 2021

openapi-pipeline-app bot commented Nov 3, 2021 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented Nov 3, 2021

openapi-pipeline-app bot commented Nov 3, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Nov 3, 2021

openapi-pipeline-app bot commented Nov 3, 2021 •

edited

Loading

openapi-pipeline-app bot commented Nov 3, 2021 •

edited

Loading