[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-12-01 #17271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/2021-10-01 to version 2021-12-01
- This policy type will additionally support hourly backups along with daily and weekly supported by current policy - Added respective examples for create/update, Get and List policy api
|
Hi, @arpja Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| 'policyType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L5497 |
|
| 'DailySchedule' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6966 |
|
| 'WeeklySchedule' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6979 |
|
| 'scheduleRunDays' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6982 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig' Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L21 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupPreValidateProtection' Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L164 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupStatus' Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L209 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupValidateFeatures' Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L254 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/backupProtectionIntent/{intentObjectName}' Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L299 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupProtectionIntents' Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L460 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupUsageSummaries' Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L517 |
|
The response of operation:'BackupResourceStorageConfigsNonCRR_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L22 |
|
The response of operation:'ProtectionIntent_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L300 |
|
The response of operation:'BackupResourceVaultConfigs_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L609 |
|
The response of operation:'BackupResourceEncryptionConfigs_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L758 |
|
The response of operation:'PrivateEndpointConnection_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L852 |
|
The response of operation:'ProtectedItems_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L1298 |
|
The response of operation:'ProtectedItemOperationResults_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L1521 |
|
The response of operation:'RecoveryPoints_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L1677 |
|
The response of operation:'ProtectionPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L1907 |
|
The response of operation:'ProtectionPolicyOperationResults_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L2093 |
|
The response of operation:'JobDetails_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L2221 |
|
The response of operation:'BackupEngines_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L2834 |
|
The response of operation:'ProtectionContainers_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L3022 |
|
The response of operation:'ProtectionContainerOperationResults_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L3352 |
|
The response of operation:'ResourceGuardProxy_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4313 |
|
The response of operation:'BackupResourceStorageConfigsNonCRR_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L65 |
|
The response of operation:'ProtectionIntent_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L351 |
|
The response of operation:'BackupResourceVaultConfigs_Put' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L704 |
|
The response of operation:'PrivateEndpointConnection_Put' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L902 |
|
The response of operation:'ProtectedItems_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L1373 |
|
The response of operation:'ProtectionPolicies_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L1960 |
|
The response of operation:'ProtectionContainers_Register' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L3079 |
|
The response of operation:'ResourceGuardProxy_Put' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4362 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 42 Errors, 29 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.1)
- current:stable/2021-12-01/bms.json compared with base:stable/2021-11-15/bms.json
- current:stable/2021-12-01/bms.json compared with base:preview/2021-02-01-preview/bms.json
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupUsageSummaries' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L21:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupAadProperties' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L87:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupCrossRegionRestore' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L137:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupCrrJob' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L195:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupCrrJobs' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L246:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupCrrOperationResults/{operationId}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L315:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupCrrOperationsStatus/{operationId}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L362:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/recoveryPoints/{recoveryPointId}/accessToken' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L409:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L495:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/recoveryPoints/' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L638:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupProtectedItems/' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L715:5 |
|
The new version is missing a definition that was found in the old version. Was 'AADProperties' removed or renamed? New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4522:3 Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L779:3 |
|
The new version is missing a definition that was found in the old version. Was 'AADPropertiesResource' removed or renamed? New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4522:3 Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L779:3 |
|
The new version is missing a definition that was found in the old version. Was 'CrrJobRequest' removed or renamed? New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4522:3 Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L779:3 |
|
The new version is missing a definition that was found in the old version. Was 'CrossRegionRestoreRequest' removed or renamed? New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4522:3 Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L779:3 |
|
The new version is missing a definition that was found in the old version. Was 'CrrAccessToken' removed or renamed? New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4522:3 Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L779:3 |
|
The new version is missing a definition that was found in the old version. Was 'OperationStatusRecoveryPointExtendedInfo' removed or renamed? New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4522:3 Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L779:3 |
|
The new version is missing a definition that was found in the old version. Was 'WorkloadCrrAccessToken' removed or renamed? New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4522:3 Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L779:3 |
|
The read only property has changed from 'true' to 'false'. New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4889:9 Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1058:9 |
|
The read only property has changed from 'true' to 'false'. New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4893:9 Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1063:9 |
|
The read only property has changed from 'true' to 'false'. New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4898:9 Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1069:9 |
|
The read only property has changed from 'true' to 'false'. New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4902:9 Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1074:9 |
|
The read only property has changed from 'true' to 'false'. New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6016:9 Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1989:9 |
|
The read only property has changed from 'true' to 'false'. New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6021:9 Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1995:9 |
|
The read only property has changed from 'true' to 'false'. New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6016:9 Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1989:9 |
|
The read only property has changed from 'true' to 'false'. New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6021:9 Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1995:9 |
|
The read only property has changed from 'true' to 'false'. New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6016:9 Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1989:9 |
|
The read only property has changed from 'true' to 'false'. New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6021:9 Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1995:9 |
|
The read only property has changed from 'true' to 'false'. New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6016:9 Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1989:9 |
|
The read only property has changed from 'true' to 'false'. New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6021:9 Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1995:9 |
The following breaking changes are detected by comparison with latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @arpja, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jan 6, 2022
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @arpja your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
arpja
added
the
DoNotMerge
|
Working on getting the ARM manifest updated, I have added the 'DoNotMerge' tag until then. Cross-Version Breaking Changes is failing since the previous version 2021-11-15 was for our Passive stamps and hence has difference in APIs. For this PR 2021-10-01 is the base version on which I have made the changes. |
arpja
removed
the
DoNotMerge
jorgecotillo
added
ARMSignedOff
Hi @jianyexi |
openapi-pipeline-app
bot
added
CI-BreakingChange-Go-V2
and removed
CI-BreakingChange-Go-V2
labels
openapi-pipeline-app
bot
added
CI-BreakingChange-Go-V2
and removed
CI-BreakingChange-Go-V2
labels
Hi @raych1 I have fixed the Semantic validation failures. |
Hi @jianyexi |
jianyexi
approved these changes
Jan 20, 2022
|
After compared with https://github.com/Azure/azure-rest-api-specs/blob/main/specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-10-01/bms.json ,there is no breaking change , so |
pratimaupadhyay02
approved these changes
Jan 20, 2022
This was referenced Jan 20, 2022
25 tasks
mstrisoline
pushed a commit
to mstrisoline/azure-rest-api-specs
that referenced
this pull request
Feb 1, 2022
…version stable/2021-12-01 (Azure#17271) * Adds base for updating Microsoft.RecoveryServices from version stable/2021-10-01 to version 2021-12-01 * Updates readme * Updates API version in new specs and examples * - Adding support for creation of new 'Enhanced' policy for IaaSVM backup - This policy type will additionally support hourly backups along with daily and weekly supported by current policy - Added respective examples for create/update, Get and List policy api * - prettier fixes * updating readme.md to new api * - correcting the path of new example files * - fixing examples * - more fixes in examples * fixing spell check error * fixing semantic errors * - semantic errors fix
25 tasks
JeffreyRichter
added
the
Approved-BreakingChange
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
…version stable/2021-12-01 (Azure#17271) * Adds base for updating Microsoft.RecoveryServices from version stable/2021-10-01 to version 2021-12-01 * Updates readme * Updates API version in new specs and examples * - Adding support for creation of new 'Enhanced' policy for IaaSVM backup - This policy type will additionally support hourly backups along with daily and weekly supported by current policy - Added respective examples for create/update, Get and List policy api * - prettier fixes * updating readme.md to new api * - correcting the path of new example files * - fixing examples * - more fixes in examples * fixing spell check error * fixing semantic errors * - semantic errors fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.