Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swagger changes for setting minimalTlsVersion for workspace sql server post workspace creation #17476

Merged
merged 15 commits into from
Mar 9, 2022
Merged

Swagger changes for setting minimalTlsVersion for workspace sql server post workspace creation #17476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
61ce3f5
Checking in the swagger related changes to dedicated sql minial tls s…
naresh-polu Jan 22, 2022
667cdea
Updated the ms-examples related to minimal tls settings in both previ…
naresh-polu Jan 24, 2022
1d32e68
Fixing the swagger validation errors
naresh-polu Jan 24, 2022
0c14e8b
Fixing the swagger model validation errors
naresh-polu Jan 24, 2022
6e49241
Updated ms-examples and swagger files after review
naresh-polu Jan 26, 2022
f65d4b7
Updated swagger files to include additional property
naresh-polu Jan 26, 2022
7bbc8dd
Fixing the swagger prettier check
naresh-polu Jan 26, 2022
affed9f
Fixing the swagger model validation errors
naresh-polu Jan 26, 2022
05dde68
Updated the ms-examples related to patch and changes in swagger files
naresh-polu Jan 27, 2022
6f158a2
Updated the swagger files for fixing few of the code review comments
naresh-polu Feb 8, 2022
eef0340
Updated the swagger files for fixing few of the code review comments
naresh-polu Feb 9, 2022
8798faf
Updated the swagger files for fixing few of the code review comments
naresh-polu Feb 9, 2022
343c729
Updated the swagger files and ms-examples for fixing code review comm…
naresh-polu Feb 10, 2022
eb40586
Updated the swagger files for fixing code review comments
naresh-polu Feb 10, 2022
171e14c
Updated the swagger files for fixing code review comments
naresh-polu Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions custom-words.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1150,6 +1150,7 @@ Lucene
Lumia
LUNs
Luxembourgish
Lminimal
machinelearning
machinelearningcompute
machinelearningexperimentation
Expand Down
22 changes: 22 additions & 0 deletions ...21-06-01-preview/examples/GetWorkspaceManagedSqlServerDedicatedSQLminimalTlsSettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"parameters": {
"subscriptionId": "00000000-1111-2222-3333-444444444444",
"resourceGroupName": "workspace-6852",
"workspaceName": "workspace-2080",
"dedicatedSQLminimalTlsSettingsName": "default",
"api-version": "2021-06-01-preview"
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/workspace-6852/providers/Microsoft.Synapse/workspaces/workspace-2080/dedicatedSQLminimalTlsSettings/default",
"name": "default",
"type": "Microsoft.Synapse/workspaces/dedicatedSQLminimalTlsSettings",
"location": "eastus",
"properties": {
"minimalTlsVersion": "1.1"
}
}
}
}
}
34 changes: 34 additions & 0 deletions ...1-06-01-preview/examples/ListWorkspaceManagedSqlServerDedicatedSQLminimalTlsSettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
{
"parameters": {
"subscriptionId": "00000000-1111-2222-3333-444444444444",
"resourceGroupName": "workspace-6852",
"workspaceName": "workspace-2080",
"api-version": "2021-06-01-preview"
},
"responses": {
"200": {
"body": {
"value": [
{
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/workspace-6852/providers/Microsoft.Synapse/workspaces/workspace-2080/dedicatedSQLminimalTlsSettings/default",
"name": "default",
"type": "Microsoft.Synapse/workspaces/dedicatedSQLminimalTlsSettings",
"location": "eastus",
"properties": {
"minimalTlsVersion": "1.1"
}
},
{
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/workspace-6852/providers/Microsoft.Synapse/workspaces/workspace-2080/dedicatedSQLminimalTlsSettings/default",
"name": "default",
"type": "Microsoft.Synapse/workspaces/dedicatedSQLminimalTlsSettings",
"location": "eastus",
"properties": {
"minimalTlsVersion": "1.1"
}
}
]
}
}
}
}
27 changes: 27 additions & 0 deletions ...06-01-preview/examples/UpdateWorkspaceManagedSqlServerDedicatedSQLminimalTlsSettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"parameters": {
"subscriptionId": "00000000-1111-2222-3333-444444444444",
"resourceGroupName": "workspace-6852",
"workspaceName": "workspace-2080",
"dedicatedSQLminimalTlsSettingsName": "default",
"api-version": "2021-06-01-preview",
"parameters": {
"properties": {
"minimalTlsVersion": "1.1"
}
}
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/workspace-6852/providers/Microsoft.Synapse/workspaces/workspace-2080/dedicatedSQLminimalTlsSettings/default",
"name": "default",
"type": "Microsoft.Synapse/workspaces/dedicatedSQLminimalTlsSettings",
"properties": {
"minimalTlsVersion": "1.1"
}
}
},
"202": {}
}
}
229 changes: 229 additions & 0 deletions ...tion/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1188,6 +1188,185 @@
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/dedicatedSQLminimalTlsSettings/{dedicatedSQLminimalTlsSettingsName}": {
pilor marked this conversation as resolved.
Show resolved Hide resolved
"put": {
"operationId": "WorkspaceManagedSqlServerDedicatedSQLminimalTlsSettings_Update",
"summary": "Update server's tls settings.",
"description": "Update workspace managed sql server's minimal tls settings.",
"tags": [
"WorkspaceManagedSqlServer, DedicatedSQLminimalTlsSettings"
],
"deprecated": false,
"parameters": [
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/ApiVersionParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/ResourceGroupNameParameter"
},
{
"$ref": "../../../../common/v1/types.json#/parameters/WorkspaceNameParameter"
},
{
"name": "dedicatedSQLminimalTlsSettingsName",
"in": "path",
"description": "The name of the dedicated sql minimal tls settings.",
"required": true,
"type": "string",
"enum": [
"default"
],
"x-ms-enum": {
"name": "DedicatedSQLMinimalTlsSettingsName",
"modelAsString": true
}
},
{
"schema": {
"$ref": "#/definitions/DedicatedSQLminimalTlsSettings"
},
"in": "body",
"name": "parameters",
"description": "minimal tls settings",
"required": true
}
],
"responses": {
"200": {
"description": "Successfully updated dedicated sql minimal tls settings.",
"schema": {
"$ref": "#/definitions/DedicatedSQLminimalTlsSettings"
}
},
"202": {
pilor marked this conversation as resolved.
Show resolved Hide resolved
"description": "Accepted"
},
"default": {
"schema": {
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
},
"description": "*** Error Responses: ***\n\n * 404 SubscriptionDoesNotHaveServer - The requested server was not found.\n\n * 404 ServerNotInSubscriptionResourceGroup - Specified server does not exist in the specified resource group and subscription.\n\n * 409 UnsupportedWorkspaceType - Unsupported operation for the workspace type.\n\n * 500 InternalServerError - Something went wrong."
naresh-polu marked this conversation as resolved.
Show resolved Hide resolved
}
},
"consumes": [
"application/json"
],
"produces": [
"application/json"
],
"x-ms-long-running-operation": true,
"x-ms-examples": {
"Update tls version of the workspace managed sql server": {
"$ref": "./examples/UpdateWorkspaceManagedSqlServerDedicatedSQLminimalTlsSettings.json"
}
}
},
"get": {
"operationId": "WorkspaceManagedSqlServerDedicatedSQLminimalTlsSettings_Get",
"summary": "Get server's minimal tls settings.",
"description": "Get workspace managed sql server's minimal tls settings.",
"tags": [
"WorkspaceManagedSqlServer, DedicatedSQLminimalTlsSettings"
],
"parameters": [
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/ApiVersionParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/ResourceGroupNameParameter"
},
{
"$ref": "../../../../common/v1/types.json#/parameters/WorkspaceNameParameter"
},
{
"name": "dedicatedSQLminimalTlsSettingsName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the dedicated sql minimal tls settings."
}
],
"responses": {
"200": {
"description": "Successfully retrieved dedicated sql minimal tls settings.",
"schema": {
"$ref": "#/definitions/DedicatedSQLminimalTlsSettings"
}
},
"default": {
"schema": {
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
},
"description": "*** Error Responses: ***\n\n * 404 SubscriptionDoesNotHaveServer - The requested server was not found.\n\n * 404 ServerNotInSubscriptionResourceGroup - Specified server does not exist in the specified resource group and subscription.\n\n * 409 UnsupportedWorkspaceType - Unsupported operation for the workspace type.\n\n * 500 InternalServerError - Something went wrong."
}
},
"consumes": [],
"produces": [
"application/json"
],
"x-ms-examples": {
"Get workspace managed sql server dedicated sql minimal tls settings": {
"$ref": "./examples/GetWorkspaceManagedSqlServerDedicatedSQLminimalTlsSettings.json"
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/dedicatedSQLminimalTlsSettings": {
"get": {
"operationId": "WorkspaceManagedSqlServerDedicatedSQLminimalTlsSettings_List",
"summary": "List workspace server's minimal tls settings.",
"description": "List workspace managed sql server's minimal tls settings.",
"tags": [
"WorkspaceManagedSqlServer, DedicatedSQLminimalTlsSettings"
],
"parameters": [
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/ApiVersionParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/ResourceGroupNameParameter"
},
{
"$ref": "../../../../common/v1/types.json#/parameters/WorkspaceNameParameter"
}
],
"responses": {
"200": {
"description": "Successfully retrieved dedicated sql minimal tls settings.",
"schema": {
"$ref": "#/definitions/DedicatedSQLminimalTlsSettingsListResult"
}
},
"default": {
"schema": {
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
},
"description": "*** Error Responses: ***\n\n * 404 SubscriptionDoesNotHaveServer - The requested server was not found.\n\n * 404 ServerNotInSubscriptionResourceGroup - Specified server does not exist in the specified resource group and subscription.\n\n * 409 UnsupportedWorkspaceType - Unsupported operation for the workspace type.\n\n * 500 InternalServerError - Something went wrong."
}
},
"consumes": [],
"produces": [
"application/json"
],
"x-ms-pageable": {
"nextLinkName": "nextLink"
},
"x-ms-examples": {
"List dedicated sql minimal tls settings of the workspace managed sql server": {
"$ref": "./examples/ListWorkspaceManagedSqlServerDedicatedSQLminimalTlsSettings.json"
}
}
}
}
},
"definitions": {
Expand Down Expand Up @@ -1788,6 +1967,56 @@
"readOnly": true
}
}
},
"DedicatedSQLminimalTlsSettingsProperties": {
"description": "Properties of a dedicated sql minimal tls settings.",
"type": "object",
"properties": {
"minimalTlsVersion": {
"type": "string",
"description": "The minimal tls version of the sql server."
}
}
},
"DedicatedSQLminimalTlsSettings": {
"description": "Dedicated Sql Minimal Tls Settings Info",
"type": "object",
"allOf": [
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ProxyResource"
}
],
"properties": {
"location": {
pilor marked this conversation as resolved.
Show resolved Hide resolved
"description": "Resource location.",
"type": "string",
"readOnly": true
},
"properties": {
"$ref": "#/definitions/DedicatedSQLminimalTlsSettingsProperties",
"description": "Resource properties.",
"x-ms-client-flatten": true
}
}
},
"DedicatedSQLminimalTlsSettingsListResult": {
"description": "A list of the server's dedicated sql minimal tls settings.",
"type": "object",
"properties": {
"value": {
"description": "Array of results.",
"type": "array",
"items": {
"$ref": "#/definitions/DedicatedSQLminimalTlsSettings"
},
"readOnly": true
},
"nextLink": {
"description": "Link to retrieve next page of results.",
"type": "string",
"readOnly": true
}
}
}
}
}
22 changes: 22 additions & 0 deletions ...table/2021-06-01/examples/GetWorkspaceManagedSqlServerDedicatedSQLminimalTlsSettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"parameters": {
"subscriptionId": "00000000-1111-2222-3333-444444444444",
"resourceGroupName": "workspace-6852",
"workspaceName": "workspace-2080",
"dedicatedSQLminimalTlsSettingsName": "default",
"api-version": "2021-06-01"
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/workspace-6852/providers/Microsoft.Synapse/workspaces/workspace-2080/dedicatedSQLminimalTlsSettings/default",
"name": "default",
"type": "Microsoft.Synapse/workspaces/dedicatedSQLminimalTlsSettings",
"location": "eastus",
"properties": {
"minimalTlsVersion": "1.1"
}
}
}
}
}
34 changes: 34 additions & 0 deletions ...able/2021-06-01/examples/ListWorkspaceManagedSqlServerDedicatedSQLminimalTlsSettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
{
"parameters": {
"subscriptionId": "00000000-1111-2222-3333-444444444444",
"resourceGroupName": "workspace-6852",
"workspaceName": "workspace-2080",
"api-version": "2021-06-01"
},
"responses": {
"200": {
"body": {
"value": [
{
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/workspace-6852/providers/Microsoft.Synapse/workspaces/workspace-2080/dedicatedSQLminimalTlsSettings/default",
"name": "default",
"type": "Microsoft.Synapse/workspaces/dedicatedSQLminimalTlsSettings",
"location": "eastus",
"properties": {
"minimalTlsVersion": "1.1"
}
},
{
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/workspace-6852/providers/Microsoft.Synapse/workspaces/workspace-2080/dedicatedSQLminimalTlsSettings/default",
"name": "default",
"type": "Microsoft.Synapse/workspaces/dedicatedSQLminimalTlsSettings",
"location": "eastus",
"properties": {
"minimalTlsVersion": "1.1"
}
}
]
}
}
}
}
Loading