Swagger updates to address docs and sdk issues #2139

finiteattractor · 2017-12-12T19:58:58Z

Found few issues while generating docs and SDK. Addressed by these changes. All test pass and SDK generation and test cases passing as well. Changes:

Fixed wrong enum definitions
IncludedUpdateClassifications to use comma separated strings
Fixed parameters not showing in docs
removed discriminator property, was resulting in missing property in generated models
First letter capital for better looking doc
Cleaned common definition file
fixed x-ms-enum without enum on same level error in code generation
removed subscriptionid/resourcegroupname/azureautomationname parameters to simplify sdk (they are not in the client)
Changed scheduleinfo to be a required property
moved filter parameter for better sdk parameter ordering
ran auto indent on files

Added extension properties to DSCNode for Get/GetNode api calls

Bring in the changes from Upstream to AzureAutomationTeam

Adding new API version (2017-05-15-preview). Only three new resources added and all others reference the previous version. - Added resources: - SoftwareUpdateConfiguration - SoftwareUpdateConfigurationRun - SoftwareUpdateConfigurationMachineRun - Validations: - Autorest azure validations passed - x-ms-examples validated with no errors

Updated tag in global configuration to use the latest api version as per azure PR review comment

- Moved parameters inside operations as it was not showing properly in documentation.

Fixing merge error

* Changed property type to integer * includedUpdateClassifications to scalar integer * model as string * type to string * Created adhoc property to allow code generation of enum with bitfield values since it seems that autorest doesn't support birfields and generate the enum only for string type property * test * Removed readonly attribute from name to allow setting outside constructor * Fixed parameter type and replaced reference to parameter with actual definition * removed descriminator property * trying modelAsString with false * modeled includedUpdateClassifications as string as deserialization was failing * - First letter capital for better looking doc - Replaces referece to paramaters with actual definitions on all resources - Cleaned common definition file * fixed x-ms-enum without enum on same level error in code generation * removed subid/rg/aa parameters to simplify sdk * added paemeters tat path level to avoid passing as arguments in sdk * more fixes * more fixes * fixing more parameters * Added missing automationAccountName parameter * made resourceGroupName passed in function for account resource * made schedule info requred property * moved filter parameter for better sdk parameter ordering * ran auto indent on files

…ion.

finiteattractor · 2017-12-12T20:08:33Z

Note: This is a resubmit of original PR (#2097). Been asked to resubmit from my own fork to address Travis issue with PRs originating from team forks.

marstr

And just to confirm, this API Version is currently available, but in preview?

marstr · 2017-12-12T20:54:12Z

...ication/automation/resource-manager/Microsoft.Automation/2017-05-15-preview/definitions.json

+  "swagger": "2.0",
+  "info": {
+    "title": "AutomationManagement",
+    "version": "2015-10-31"


Sorry I didn't notice this earlier, I'm a bit confused by the difference in API Version between the path to this file and how its declared here. Is this done to ship multiple API Versions together? If so, we can achieve the same thing more concisely by using tags that are found here: README.md@2165c04

Nope, you caught a copy/paste mistake :) this should be matching the version of the folder. I fixed it. Thanks!!

Correct, API is live and being used by Ibiza portal.

dsgouda · 2017-12-12T21:37:09Z

@marstr do you think you can review this since you have some context

azuresdkciprbot · 2017-12-12T22:04:59Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/automation/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 77
After the PR: Warning(s): 0 Error(s): 77

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

ravbhatnagar · 2017-12-14T22:24:11Z

@marstr - Only thing that popped from ARM point of view was that this has some breaking changes like making a property as required and enum changes. This if done in a new api-version is fine. Please confirm and looks good to merge other than that.

finiteattractor · 2017-12-14T22:49:10Z

@ravbhatnagar this is a new api version and it is required property so we should be ok here.

azuresdkciprbot · 2017-12-16T00:30:59Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/automation/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 77
After the PR: Warning(s): 0 Error(s): 77

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

marstr · 2017-12-19T20:16:33Z

Adding the potential breaking changes label, but because this is in a new API Version, that's not a blocker.

AutorestCI · 2017-12-19T20:20:23Z

No modification for AutorestCI/azure-sdk-for-python

AutorestCI · 2017-12-19T20:21:19Z

Azure/azure-sdk-for-ruby#1199

AutorestCI · 2017-12-19T22:00:37Z

No modification for AutorestCI/azure-sdk-for-python

eshaparmar and others added 17 commits September 11, 2017 12:42

added extension properties to Get & GetNode

311c922

fix indentation

088dc60

fix indentation

3fd4e20

changed description text

c26a4eb

Merge pull request #1 from AzureAutomationTeam/billing

89d356e

Added extension properties to DSCNode for Get/GetNode api calls

Merge remote branch 'upstream/current' into current

85087ab

Bring in the changes from Upstream to AzureAutomationTeam

Merge remote branch 'upstream/current' into current

dadc8d3

Updated tag in global configuration

a3c3d5d

Updated tag in global configuration to use the latest api version as per azure PR review comment

- Fixed 2 typos in URLs (#4)

af0ba37

- Moved parameters inside operations as it was not showing properly in documentation.

Merge branch 'current' into current

125bba4

Merge remote-tracking branch 'upstream/current' into current

94f9f6c

Fixing merge error

d4b6512

Fixing merge error

Fixing merge error

81bd6b4

Fixing merge error

Merge branch 'current' into current

f1fb508

Reformatted the file to use two-spaced indentation as per recommendat…

cbe3127

…ion.

azuresdkci assigned dsgouda Dec 12, 2017

marstr assigned marstr and unassigned dsgouda Dec 12, 2017

marstr mentioned this pull request Dec 12, 2017

swagger updates to address docs and sdk issues #2097

Closed

marstr requested review from simongdavies and ravbhatnagar December 12, 2017 20:41

marstr added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 12, 2017

marstr reviewed Dec 12, 2017

View reviewed changes

Fixing API version in definitions.json

8aca7f3

marstr added potential-sdk-breaking-change and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 19, 2017

marstr approved these changes Dec 19, 2017

View reviewed changes

marstr merged commit ca571e3 into Azure:current Dec 19, 2017

AutorestCI mentioned this pull request Dec 19, 2017

Automatic PR from RestAPI-PR2139 Azure/azure-sdk-for-ruby#1199

Closed

vrdmr mentioned this pull request Jan 11, 2018

Automation 3.0.1-preview: Software Update Configuration Azure/azure-sdk-for-net#3992

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Swagger updates to address docs and sdk issues #2139

Swagger updates to address docs and sdk issues #2139

finiteattractor commented Dec 12, 2017 •

edited by azuresdkci

Loading

finiteattractor commented Dec 12, 2017

marstr left a comment

marstr Dec 12, 2017

finiteattractor Dec 12, 2017

finiteattractor Dec 12, 2017

dsgouda commented Dec 12, 2017

azuresdkciprbot commented Dec 12, 2017

ravbhatnagar commented Dec 14, 2017

finiteattractor commented Dec 14, 2017

azuresdkciprbot commented Dec 16, 2017

marstr commented Dec 19, 2017

AutorestCI commented Dec 19, 2017

AutorestCI commented Dec 19, 2017

AutorestCI commented Dec 19, 2017

Swagger updates to address docs and sdk issues #2139

Swagger updates to address docs and sdk issues #2139

Conversation

finiteattractor commented Dec 12, 2017 • edited by azuresdkci Loading

finiteattractor commented Dec 12, 2017

marstr left a comment

Choose a reason for hiding this comment

marstr Dec 12, 2017

Choose a reason for hiding this comment

finiteattractor Dec 12, 2017

Choose a reason for hiding this comment

finiteattractor Dec 12, 2017

Choose a reason for hiding this comment

dsgouda commented Dec 12, 2017

azuresdkciprbot commented Dec 12, 2017

ravbhatnagar commented Dec 14, 2017

finiteattractor commented Dec 14, 2017

azuresdkciprbot commented Dec 16, 2017

marstr commented Dec 19, 2017

AutorestCI commented Dec 19, 2017

AutorestCI commented Dec 19, 2017

AutorestCI commented Dec 19, 2017

finiteattractor commented Dec 12, 2017 •

edited by azuresdkci

Loading