Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyvault: fixing the duplicate constant types #21877

Closed
wants to merge 1 commit into from

Conversation

aristosvo
Copy link

@aristosvo aristosvo commented Dec 13, 2022

Fixes this:

$ autorest --tag=package-preview-7.4-preview.1 --go --verbose --use-onever --version=2.0.4421 --go.license-header=MICROSOFT_MIT_NO_VERSION --enum-prefix --openapi-type=data-plane --output-folder=../../sdk/keyvault/7.4/keyvault readme.md

FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'ActionType' and different values: EmailContacts,AutoRenew vs. rotate,notify

By adding this to a preview version I hoped to circumvent the freeze on API SDK output as imposed on #21137, let me know if this is the case or otherwise to request this change for the final version.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 13, 2022

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.2)] new version base version
certificates.json 7.4-preview.1(759ead1) 7.4-preview.1(main)
keys.json 7.4-preview.1(759ead1) 7.4-preview.1(main)
Rule Message
1047 - XmsEnumChanged The new version has a different x-ms-enum 'name' than the previous one.
New: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1624:9
Old: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1624:9
1047 - XmsEnumChanged The new version has a different x-ms-enum 'name' than the previous one.
New: Microsoft.KeyVault/preview/7.4-preview.1/keys.json#L2222:9
Old: Microsoft.KeyVault/preview/7.4-preview.1/keys.json#L2222:9
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.0.0) new version base version
package-preview-7.4-preview.1 package-preview-7.4-preview.1(759ead1) package-preview-7.4-preview.1(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
MissingTypeObject The schema 'CertificateAttributes' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1247
MissingTypeObject The schema 'CertificateItem' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1312
MissingTypeObject The schema 'CertificateIssuerItem' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1338
MissingTypeObject The schema 'CertificateBundle' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1351
MissingTypeObject The schema 'DeletedCertificateBundle' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1403
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1414
ValidFormats 'unixtime' is not a known format.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1416
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1420
ValidFormats 'unixtime' is not a known format.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1422
MissingTypeObject The schema 'DeletedCertificateItem' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1429
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1440
ValidFormats 'unixtime' is not a known format.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1442
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1446
ValidFormats 'unixtime' is not a known format.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1448
MissingTypeObject The schema 'CertificateOperation' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1455
MissingTypeObject The schema 'CertificatePolicy' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1499
MissingTypeObject The schema 'X509CertificateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1540
MissingTypeObject The schema 'IssuerParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1590
MissingTypeObject The schema 'LifetimeAction' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1609
MissingTypeObject The schema 'Action' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1622
MissingTypeObject The schema 'Trigger' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1639
MissingTypeObject The schema 'SubjectAlternativeNames' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1656
MissingTypeObject The schema 'IssuerBundle' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1682
MissingTypeObject The schema 'IssuerAttributes' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1709
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1715
ValidFormats 'unixtime' is not a known format.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1717
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1721
ValidFormats 'unixtime' is not a known format.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1723
MissingTypeObject The schema 'IssuerCredentials' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1730
MissingTypeObject The schema 'OrganizationDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1744
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 13 Errors, 0 Warnings failed [Detail]
Rule Message
INVALID_FORMAT Object didn't pass validation for format byte: MIICODCCAeagAwIBAgIQqHmpBAv+CY9IJFoUhlbziTAJBgUrDgMCHQUAMBYxFDASBgNVBAMTC1Jvb3QgQWdlbmN5MB4XDTE1MDQyOTIxNTM0MVoXDTM5MTIzMTIzNTk1OVowFzEVMBMGA1UEAxMMS2V5VmF1bHRUZXN0MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA5bVAT73zr4+N4WVv2+SvTunAw08ksS4BrJW/nNliz3S9XuzMBMXvmYzU5HJ8TtEgluBiZZYd5qsMJD+OXHSNbsLdmMhni0jYX09h3XlC2VJw2sGKeYF+xEaavXm337aZZaZyjrFBrrUl51UePaN+kVFXNlBb3N3TYpqa7KokXenJQuR+i9Gv9a77c0UsSsDSryxppYhKK7HvTZCpKrhVtulF5iPMswWe9np3uggfMamyIsK/0L7X9w9B2qN7993RR0A00nOk4H6CnkuwO77dSsD0KJsk6FyAoZBzRXDZh9+d9R76zCL506NcQy/jl0lCiQYwsUX73PG5pxOh02OwKwIDAQABo0swSTBHBgNVHQEEQDA+gBAS5AktBh0dTwCNYSHcFmRjoRgwFjEUMBIGA1UEAxMLUm9vdCBBZ2VuY3mCEAY3bACqAGSKEc+41KpcNfQwCQYFKw4DAh0FAANBAGqIjo2geVagzuzaZOe1ClGKhZeiCKfWAxklaGN+qlGUbVS4IN4V1lot3VKnzabasmkEHeNxPwLn1qvSD0cX9CE=
Url: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1380:16
ExampleUrl: preview/7.4-preview.1/examples/DeleteCertificate-example.json#L17:16
INVALID_FORMAT Object didn't pass validation for format byte: MIIC4zCCAcsCAQAwGjEYMBYGA1UEAwwPKi5taWNyb3NvZnQuY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAqe8aINnShK+wQC8QU7fwsviQc9+yiOnqU3adXA6qNjn21HTdRBa7cyQIk1STxHIBLTT/GaEJwqsUi6UvZaPEHokOWsr1bP9M7xOPTicBcRyMrr6bOxsmGczYtu1z2TzzXDD7q7IEignE7/LowGEaIADCIU9iuWk7TiJ+1Q/VLh/B3xPsgVjY+n7zEQ53gBiDHSl7XfELfwmslOQ28TVNogUyXsxHcVxQQYJeI7HqqY448LeleK69Ld86lkBixLEm1pD7HSbEx3WI2lyUQAGR6hD3YFaiIWVpQeEyI7p1jmtQlnfZdEL4q9wdlEEcwd3h3PAZpEBhCixahF54fci3pwIDAQABoIGDMIGABgkqhkiG9w0BCQ4xczBxMA4GA1UdDwEB/wQEAwIFoDAdBgNVHSUEFjAUBggrBgEFBQcDAQYIKwYBBQUHAwIwNQYDVR0RBC4wLIIWb25lZHJpdmUubWljcm9zb2Z0LmNvbYISeGJveC5taWNyb3NvZnQuY29tMAkGA1UdEwQCMAAwDQYJKoZIhvcNAQELBQADggEBACiLeghirF+yCuYGVUPDB3wKQJn2iLY1za9ncxCehIVqOkFK09AphzoxF6Yid90AKCaa/dT/Ohm7oTyVQ+YcZnT00LUNFVG48AOE8YDiw9tjAG9OORsAz80xnv2qaLw2TCVIQ6NjrI83LqAm1GJ8rAnpdD/ZTuWM7TvSO5g/jm/Q0oSuKpMgj3YxpwgB9Ac6YEfVzOnm76OkUcpvR5MS4BoTfRv4thdSnU+uwqxM+HtdSVTbHQeC2U/hM1cyzDMpl1rZRklmiEOoPUeDasEIBVTJhAxR8xAeKJJD7Wzj4mJPw4UMvF8zQZzW8EKYvB1hkVYY+HQ85L+XcXd8lco7hU4=
Url: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1467:16
ExampleUrl: preview/7.4-preview.1/examples/CreateCertificate-example.json#L39:16
INVALID_FORMAT Object didn't pass validation for format byte: MIIC...
Url: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1380:16
ExampleUrl: preview/7.4-preview.1/examples/ImportCertificate-example.json#L29:16
INVALID_FORMAT Object didn't pass validation for format byte: MIICODCCAeagAwIBAgIQqHmpBAv+CY9IJFoUhlbziTAJBgUrDgMCHQUAMBYxFDASBgNVBAMTC1Jvb3QgQWdlbmN5MB4XDTE1MDQyOTIxNTM0MVoXDTM5MTIzMTIzNTk1OVowFzEVMBMGA1UEAxMMS2V5VmF1bHRUZXN0MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA5bVAT73zr4+N4WVv2+SvTunAw08ksS4BrJW/nNliz3S9XuzMBMXvmYzU5HJ8TtEgluBiZZYd5qsMJD+OXHSNbsLdmMhni0jYX09h3XlC2VJw2sGKeYF+xEaavXm337aZZaZyjrFBrrUl51UePaN+kVFXNlBb3N3TYpqa7KokXenJQuR+i9Gv9a77c0UsSsDSryxppYhKK7HvTZCpKrhVtulF5iPMswWe9np3uggfMamyIsK/0L7X9w9B2qN7993RR0A00nOk4H6CnkuwO77dSsD0KJsk6FyAoZBzRXDZh9+d9R76zCL506NcQy/jl0lCiQYwsUX73PG5pxOh02OwKwIDAQABo0swSTBHBgNVHQEEQDA+gBAS5AktBh0dTwCNYSHcFmRjoRgwFjEUMBIGA1UEAxMLUm9vdCBBZ2VuY3mCEAY3bACqAGSKEc+41KpcNfQwCQYFKw4DAh0FAANBAGqIjo2geVagzuzaZOe1ClGKhZeiCKfWAxklaGN+qlGUbVS4IN4V1lot3VKnzabasmkEHeNxPwLn1qvSD0cX9CE=
Url: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1380:16
ExampleUrl: preview/7.4-preview.1/examples/UpdateCertificate-example.json#L25:16
INVALID_FORMAT Object didn't pass validation for format byte: MIICODCCAeagAwIBAgIQqHmpBAv+CY9IJFoUhlbziTAJBgUrDgMCHQUAMBYxFDASBgNVBAMTC1Jvb3QgQWdlbmN5MB4XDTE1MDQyOTIxNTM0MVoXDTM5MTIzMTIzNTk1OVowFzEVMBMGA1UEAxMMS2V5VmF1bHRUZXN0MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA5bVAT73zr4+N4WVv2+SvTunAw08ksS4BrJW/nNliz3S9XuzMBMXvmYzU5HJ8TtEgluBiZZYd5qsMJD+OXHSNbsLdmMhni0jYX09h3XlC2VJw2sGKeYF+xEaavXm337aZZaZyjrFBrrUl51UePaN+kVFXNlBb3N3TYpqa7KokXenJQuR+i9Gv9a77c0UsSsDSryxppYhKK7HvTZCpKrhVtulF5iPMswWe9np3uggfMamyIsK/0L7X9w9B2qN7993RR0A00nOk4H6CnkuwO77dSsD0KJsk6FyAoZBzRXDZh9+d9R76zCL506NcQy/jl0lCiQYwsUX73PG5pxOh02OwKwIDAQABo0swSTBHBgNVHQEEQDA+gBAS5AktBh0dTwCNYSHcFmRjoRgwFjEUMBIGA1UEAxMLUm9vdCBBZ2VuY3mCEAY3bACqAGSKEc+41KpcNfQwCQYFKw4DAh0FAANBAGqIjo2geVagzuzaZOe1ClGKhZeiCKfWAxklaGN+qlGUbVS4IN4V1lot3VKnzabasmkEHeNxPwLn1qvSD0cX9CE=
Url: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1380:16
ExampleUrl: preview/7.4-preview.1/examples/GetCertificate-example.json#L15:16
INVALID_FORMAT Object didn't pass validation for format byte: MIIC4zCCAcsCAQAwGjEYMBYGA1UEAwwPKi5taWNyb3NvZnQuY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAxxM2zqnPtpH8aiHX5TdEoZLO0Y6fsjk9QcjKgnHomrwUc9vK20UYYEPKt9aGOT7HNx0do8OulPCnLPrKowci8UHu1qRW/qHvsOJQ/UrQoMCHxtXptVc7Avx8WQb045sCdgp/Cl4xO8LMZa70kE4dghZU9zmNZk8wqDIxyYdh1lqqfGe49EWOxcfszTeeKs8KCsQznjExbsudBHLLWoX4VFTGMe3VcIPcV6iFf70buHKznDMXFiRC0IYwkc/GyWIadB1CSEae8k/0evsPI5lYYZLaO/kLffEUtzysqxZNCQR+S0eVPTGTLHa+fndnPPs65XZDzSZi2fZL01oXUfCAQQIDAQABoIGDMIGABgkqhkiG9w0BCQ4xczBxMA4GA1UdDwEB/wQEAwIFoDAdBgNVHSUEFjAUBggrBgEFBQcDAQYIKwYBBQUHAwIwNQYDVR0RBC4wLIIWb25lZHJpdmUubWljcm9zb2Z0LmNvbYISeGJveC5taWNyb3NvZnQuY29tMAkGA1UdEwQCMAAwDQYJKoZIhvcNAQELBQADggEBAKto/ZF9+02fQ3sLuIsRuap/O/AZz3IhAubNfyCaWvVGVAQz/Aqpf5c/liyKhxqRG6LR9Zu50oxRK5222ezR+56vJikjdXRVShf2xYsMm1CbCM1JuzsnkTeoUHHE12xx1srH/9TH+DVZIk6NXxc4wVIagbpwxiS5gR3Nly5k0ZVv7R1B79J0GUqSwK6qjuooWrBsYMEx319hz8fB/Y4jnPE8p+Cnn3AGEqnebVngXncq/QnHxnrRVfvKFVySqRvlsvM8buILmBbIaywEUqwhNtZX2i9E7reEJ8aeZcf+lAeKF3YDvffaXGTc75aiZlBk30Lv/hn0vs9T0/FedUnIae4=
Url: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1467:16
ExampleUrl: preview/7.4-preview.1/examples/UpdateCertificateOperation-example.json#L17:16
INVALID_FORMAT Object didn't pass validation for format byte: MIIC4zCCAcsCAQAwGjEYMBYGA1UEAwwPKi5taWNyb3NvZnQuY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAqe8aINnShK+wQC8QU7fwsviQc9+yiOnqU3adXA6qNjn21HTdRBa7cyQIk1STxHIBLTT/GaEJwqsUi6UvZaPEHokOWsr1bP9M7xOPTicBcRyMrr6bOxsmGczYtu1z2TzzXDD7q7IEignE7/LowGEaIADCIU9iuWk7TiJ+1Q/VLh/B3xPsgVjY+n7zEQ53gBiDHSl7XfELfwmslOQ28TVNogUyXsxHcVxQQYJeI7HqqY448LeleK69Ld86lkBixLEm1pD7HSbEx3WI2lyUQAGR6hD3YFaiIWVpQeEyI7p1jmtQlnfZdEL4q9wdlEEcwd3h3PAZpEBhCixahF54fci3pwIDAQABoIGDMIGABgkqhkiG9w0BCQ4xczBxMA4GA1UdDwEB/wQEAwIFoDAdBgNVHSUEFjAUBggrBgEFBQcDAQYIKwYBBQUHAwIwNQYDVR0RBC4wLIIWb25lZHJpdmUubWljcm9zb2Z0LmNvbYISeGJveC5taWNyb3NvZnQuY29tMAkGA1UdEwQCMAAwDQYJKoZIhvcNAQELBQADggEBACiLeghirF+yCuYGVUPDB3wKQJn2iLY1za9ncxCehIVqOkFK09AphzoxF6Yid90AKCaa/dT/Ohm7oTyVQ+YcZnT00LUNFVG48AOE8YDiw9tjAG9OORsAz80xnv2qaLw2TCVIQ6NjrI83LqAm1GJ8rAnpdD/ZTuWM7TvSO5g/jm/Q0oSuKpMgj3YxpwgB9Ac6YEfVzOnm76OkUcpvR5MS4BoTfRv4thdSnU+uwqxM+HtdSVTbHQeC2U/hM1cyzDMpl1rZRklmiEOoPUeDasEIBVTJhAxR8xAeKJJD7Wzj4mJPw4UMvF8zQZzW8EKYvB1hkVYY+HQ85L+XcXd8lco7hU4=
Url: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1467:16
ExampleUrl: preview/7.4-preview.1/examples/GetCertificateOperation-example.json#L14:16
INVALID_FORMAT Object didn't pass validation for format byte: MIIC4zCCAcsCAQAwGjEYMBYGA1UEAwwPKi5taWNyb3NvZnQuY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEApf+kGcL+5uivj/ToYbQ15zcx3caEnpzXaX2eJgL0/Kwaz4u2/bNJ9+hoXnlOFFbCp4canVoNvgu8fw5NOu9U3gJNFQwjHeAqfsg8okZGkIk0riIpp4MMb/4GQb2y3B28AcTu2FANdzLoZzBqmQs51KBe1RONkdtqDYXIvnb5G+9+P7PCy5G//Ga0JAP6Y6P8+TrE9JLEj6Sny0ljLMpMyt4rIRAtNfKYSeiWVQmYX4jZfImIW3iq91zwMsRlrzTm80mNfHPCv7V/8NmYuh0MQgCr49lLbbKCgzDyo9h8sblVQvR5TAylpIk7bSQNf4tSdVNHnsF6CJWu6Pg31hyMpQIDAQABoIGDMIGABgkqhkiG9w0BCQ4xczBxMA4GA1UdDwEB/wQEAwIFoDAdBgNVHSUEFjAUBggrBgEFBQcDAQYIKwYBBQUHAwIwNQYDVR0RBC4wLIIWb25lZHJpdmUubWljcm9zb2Z0LmNvbYISeGJveC5taWNyb3NvZnQuY29tMAkGA1UdEwQCMAAwDQYJKoZIhvcNAQELBQADggEBAHVjmYFs3FmecaJ1ExhK1WCFJaQJUTVbPJ1xJ93UJlLivhzI1yhQO9nMC2DKV+E+UCxceqjae6OG5LUhXfYAziS0HTc80+ZcUqrZRb5ZRt+8HU0TPbTDDqjj8wMZ4VlgQ3eXGAGesMfZV3AqWwa5itofvqm8KAmL4Yn/XMSHcKfRx3h9WnC6RXgZ8WNYK+r5o+gHlmuF7/AaNFh8UjIsjjOZQ0Yin/vA4yBEYTt1/OC7pScs3bdL9CIf4rC98qaMSf4B2W/vfrXUo0gGPYcep25jy7xnIltSY80Trn3Mty5YQ0IT+KPQcJKhbryGg6bIy4jJDwS7zkn51MR1q3kNoOA=
Url: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1467:16
ExampleUrl: preview/7.4-preview.1/examples/DeleteCertificateOperation-example.json#L14:16
INVALID_FORMAT Object didn't pass validation for format byte: MIICxTCCAb....trimmed for brevitiy...EPAQj8=
Url: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1902:20
ExampleUrl: preview/7.4-preview.1/examples/MergeCertificate-example.json#L6:19
INVALID_FORMAT Object didn't pass validation for format byte: ……de34534……
Url: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1380:16
ExampleUrl: preview/7.4-preview.1/examples/MergeCertificate-example.json#L18:16
INVALID_FORMAT Object didn't pass validation for format byte: MIIDMjCCAhqgAwIBAgIQGn/FrGQZT/Cd9kgXIsytEjANBgkqhkiG9w0BAQsFADAWMRQwEgYDVQQDEwtleGFtcGxlLmNvbTAeFw0xODA0MTcxODI2MjZaFw0xOTA0MTcxODM2MjZaMBYxFDASBgNVBAMTC2V4YW1wbGUuY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAsODIu9EJhfnn57k4++j6dC1M6Egi9aZucFQ9Jc29vFG9L9BkzllPGluKKdH1ypsrAUif7yGaq5d1nDyLhZUncU8dV/YIA7oll/fC+d0H4A37kVbM/60zXhXnKRx+DRZ2hJQzNBOodCaZpyZZEuYvtWdSCSILpa0R7yXYevjLaG5LfckOzuurXqeos7WB+l2q1c+6zx1KbNXbBl7QOz2nzk9oJU7CdhPOc+LOLppmsXRwwluKtmCDyKdrKAF/dANp5zGXFsognQcRctLSGQp8FbgBVQyZ+v81n9bPpSaBoUQMcH4uG9jPO6CWwbDSWE+FVYAm5kgjuW/1hqRSnOEV8QIDAQABo3wwejAOBgNVHQ8BAf8EBAMCBaAwCQYDVR0TBAIwADAdBgNVHSUEFjAUBggrBgEFBQcDAQYIKwYBBQUHAwIwHwYDVR0jBBgwFoAUaYJoBFokrORdsxOTA8sgrosMOmgwHQYDVR0OBBYEFGmCaARaJKzkXbMTkwPLIK6LDDpoMA0GCSqGSIb3DQEBCwUAA4IBAQAxL3t0kV1dq/PGUztjW+qK6Nh4sx7jsU59JtjON6zcibJ4hM+Q3Z+cEvW9zuGkuTbLz6fKNL9VnkF1LnlWTsyRmS7bF15/7iOgfdrr0vkJKVM1Zv/tqKEpBJ7Cbc0vW/VJQxZN+OlqGNc9bcx3cnqkRwpkgM25T0dVpoWtCgMwayUtbPFbTZWHHbpzHLF2BzYf5HyW1BoKXcVPM3r/rS7RETasRRsz2GqXXdfhjCd+HKVyv5kD9N3WcFNUsaq3TqAUZyOx9bO0Cn3gkmgz05JpfhPEylXwVpVAccOoXsNoFdxEKGO0w7pk7PwOhsW8sFprdXWp6OxtL0rrCNFF/llT
Url: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1380:16
ExampleUrl: preview/7.4-preview.1/examples/RestoreCertificate-example.json#L16:16
INVALID_FORMAT Object didn't pass validation for format byte: MIICODCCAeagAwIBAgIQqHmpBAv+CY9IJFoUhlbziTAJBgUrDgMCHQUAMBYxFDASBgNVBAMTC1Jvb3QgQWdlbmN5MB4XDTE1MDQyOTIxNTM0MVoXDTM5MTIzMTIzNTk1OVowFzEVMBMGA1UEAxMMS2V5VmF1bHRUZXN0MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA5bVAT73zr4+N4WVv2+SvTunAw08ksS4BrJW/nNliz3S9XuzMBMXvmYzU5HJ8TtEgluBiZZYd5qsMJD+OXHSNbsLdmMhni0jYX09h3XlC2VJw2sGKeYF+xEaavXm337aZZaZyjrFBrrUl51UePaN+kVFXNlBb3N3TYpqa7KokXenJQuR+i9Gv9a77c0UsSsDSryxppYhKK7HvTZCpKrhVtulF5iPMswWe9np3uggfMamyIsK/0L7X9w9B2qN7993RR0A00nOk4H6CnkuwO77dSsD0KJsk6FyAoZBzRXDZh9+d9R76zCL506NcQy/jl0lCiQYwsUX73PG5pxOh02OwKwIDAQABo0swSTBHBgNVHQEEQDA+gBAS5AktBh0dTwCNYSHcFmRjoRgwFjEUMBIGA1UEAxMLUm9vdCBBZ2VuY3mCEAY3bACqAGSKEc+41KpcNfQwCQYFKw4DAh0FAANBAGqIjo2geVagzuzaZOe1ClGKhZeiCKfWAxklaGN+qlGUbVS4IN4V1lot3VKnzabasmkEHeNxPwLn1qvSD0cX9CE=
Url: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1380:16
ExampleUrl: preview/7.4-preview.1/examples/GetDeletedCertificate-example.json#L18:16
INVALID_FORMAT Object didn't pass validation for format byte: MIICODCCAeagAwIBAgIQqHmpBAv+CY9IJFoUhlbziTAJBgUrDgMCHQUAMBYxFDASBgNVBAMTC1Jvb3QgQWdlbmN5MB4XDTE1MDQyOTIxNTM0MVoXDTM5MTIzMTIzNTk1OVowFzEVMBMGA1UEAxMMS2V5VmF1bHRUZXN0MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA5bVAT73zr4+N4WVv2+SvTunAw08ksS4BrJW/nNliz3S9XuzMBMXvmYzU5HJ8TtEgluBiZZYd5qsMJD+OXHSNbsLdmMhni0jYX09h3XlC2VJw2sGKeYF+xEaavXm337aZZaZyjrFBrrUl51UePaN+kVFXNlBb3N3TYpqa7KokXenJQuR+i9Gv9a77c0UsSsDSryxppYhKK7HvTZCpKrhVtulF5iPMswWe9np3uggfMamyIsK/0L7X9w9B2qN7993RR0A00nOk4H6CnkuwO77dSsD0KJsk6FyAoZBzRXDZh9+d9R76zCL506NcQy/jl0lCiQYwsUX73PG5pxOh02OwKwIDAQABo0swSTBHBgNVHQEEQDA+gBAS5AktBh0dTwCNYSHcFmRjoRgwFjEUMBIGA1UEAxMLUm9vdCBBZ2VuY3mCEAY3bACqAGSKEc+41KpcNfQwCQYFKw4DAh0FAANBAGqIjo2geVagzuzaZOe1ClGKhZeiCKfWAxklaGN+qlGUbVS4IN4V1lot3VKnzabasmkEHeNxPwLn1qvSD0cX9CE=
Url: Microsoft.KeyVault/preview/7.4-preview.1/certificates.json#L1380:16
ExampleUrl: preview/7.4-preview.1/examples/RecoverDeletedCertificate-example.json#L14:16
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi, @aristosvo Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 13, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 13, 2022

    Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Dec 13, 2022
    @ghost
    Copy link

    ghost commented Dec 13, 2022

    Thank you for your contribution aristosvo! We will review the pull request and get back to you soon.

    @ghost ghost added the KeyVault label Dec 13, 2022
    Copy link
    Contributor

    @jlichwa jlichwa left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    It is a breaking change. Enums cannot be changed and it is not duplicate, since it is for 3 separate SDKs (keys, certificates, secrets). In any subsequent versions only incremental changes are allowed.

    @jlichwa jlichwa self-requested a review December 13, 2022 19:31
    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure data-plane labels Dec 13, 2022
    @openapi-workflow-bot
    Copy link

    Hi @aristosvo, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    Hi @aristosvo, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    Copy link
    Contributor

    @jlichwa jlichwa left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    No changes are allowed, since it will break the clients.

    @aristosvo
    Copy link
    Author

    But this is still in preview. Where can we change it so Track1 is still properly supported?

    @jlichwa
    Copy link
    Contributor

    jlichwa commented Dec 13, 2022

    @aristosvo breaking change policy applies to current and future versions. Backward compatibility is required in all subsequent versions for at least 3 years after deprecation.

    @jlichwa
    Copy link
    Contributor

    jlichwa commented Dec 13, 2022

    I recommend to reach out to Azure support and setup meeting with Key Vault PG to discuss alternative options.

    @aristosvo
    Copy link
    Author

    aristosvo commented Dec 13, 2022

    I've put in the effort to implement it based on hacking the Track1 output here. I'm at least representing 76 Azure clients (hashicorp/terraform-provider-azurerm#14471 with 76 👍🏽) which would like to see this implemented rather today than tomorrow (and are asking me to speed up 🤣 ). This feature was requested more that a year ago!

    Jumping through hoops again by opening up a service request just gives me extra work, while voluntarily creating value for the Azure eco-system as a whole feels a bit weird to be honest. Can we please fast track this in some way?

    @aristosvo aristosvo closed this Dec 13, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure customer-reported Issues that are reported by GitHub users external to the Azure organization. data-plane KeyVault
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants