Network feature: Setting custom ipsec policy for Virtual Network Gateway P2S clients. #2341

Nilambari · 2018-01-26T00:51:42Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

… for setting custom ipsec policy for Virtual Network Gateway P2S client.

…adme file

AutorestCI · 2018-01-26T01:08:00Z

Did a commit to SDK for Python:
Azure/azure-sdk-for-python@25d08a3

AutorestCI · 2018-01-26T01:14:20Z

Did a commit to SDK for Python:
Azure/azure-sdk-for-go@1b2fa69

anuchandy · 2018-01-26T02:52:33Z

...tion/network/resource-manager/Microsoft.Network/stable/2018-01-01/virtualNetworkGateway.json

@@ -675,7 +675,98 @@
        "x-ms-long-running-operation": true
      }
    },
-    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/connections/{virtualNetworkGatewayConnectionName}/vpndeviceconfigurationscript": {
+	"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/setvpnclientipsecparameters": {


Please fix indentation

anuchandy · 2018-01-26T02:54:27Z

...tion/network/resource-manager/Microsoft.Network/stable/2018-01-01/virtualNetworkGateway.json

+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getvpnclientipsecparameters": {
+      "post": {


You mean GET? please confirm..

Or is this operation a Long Running get (expressed via POST)? if so annotate it accordingly

Yes, it’s a LRO POST. Annotated accordingly.

anuchandy · 2018-01-26T02:58:17Z

...tion/network/resource-manager/Microsoft.Network/stable/2018-01-01/virtualNetworkGateway.json

          "enum": [
            "None",
            "PFS1",
            "PFS2",
            "PFS2048",
            "ECP256",
            "ECP384",
-            "PFS24"
+            "PFS24",
+			"PFS14",


Fix the indentation

azuresdkciprbot · 2018-01-26T20:08:22Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 85
After the PR: Warning(s): 0 Error(s): 85

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-01-26T20:17:12Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 85
After the PR: Warning(s): 0 Error(s): 85

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2018-01-26T20:19:26Z

This commit was treated and no generation was made for Azure/azure-sdk-for-python

AutorestCI · 2018-01-26T20:25:59Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

AutorestCI · 2018-01-26T20:35:50Z

This commit was treated and no generation was made for Azure/azure-sdk-for-python

AutorestCI · 2018-01-26T20:47:44Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

Nilambari · 2018-01-29T20:16:54Z

Just talked to Deepak, looks like I need to wait for swagger changes till NRP changes do not go live so I will cancel current PR: #2341 and will reopen once NRP deployment starts.

Nilambari added 4 commits January 25, 2018 16:06

#1443089: copied files from 2017-11-01

fd1bb5f

#1443089: Update version to 2018-01-01 in the new folder

ef9ffa4

#1443089: [Network-2018-01-01] Add new field vpnclientIpsecParameters…

c590908

… for setting custom ipsec policy for Virtual Network Gateway P2S client.

#1443089: [Network-2018-01-01] Update version to 2018-01-01 in the re…

8414f44

…adme file

azuresdkci assigned anuchandy Jan 26, 2018

AutorestCI mentioned this pull request Jan 26, 2018

Automatic PR of restapi_auto_Nilambari_master8 into master Azure/azure-sdk-for-python#1836

Closed

AutorestCI mentioned this pull request Jan 26, 2018

Automatic PR of restapi_auto_Nilambari_master8 into dev Azure/azure-sdk-for-go#998

Closed

anuchandy requested changes Jan 26, 2018

View reviewed changes

anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 26, 2018

anuchandy requested a review from ravbhatnagar January 26, 2018 04:20

#1443089: Incorporate code review comments

d6c9c0b

#1443089: Fix identation

dd39735

Nilambari closed this Jan 29, 2018

anuchandy mentioned this pull request Feb 21, 2018

Network feature: Setting custom ipsec policy for Virtual Network Gateway P2S clients. #2521

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Network feature: Setting custom ipsec policy for Virtual Network Gateway P2S clients. #2341

Network feature: Setting custom ipsec policy for Virtual Network Gateway P2S clients. #2341

Nilambari commented Jan 26, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Jan 26, 2018

AutorestCI commented Jan 26, 2018

anuchandy Jan 26, 2018

Nilambari Jan 26, 2018

anuchandy Jan 26, 2018

anuchandy Jan 26, 2018 •

edited

Loading

Nilambari Jan 26, 2018

anuchandy Jan 26, 2018

Nilambari Jan 26, 2018

azuresdkciprbot commented Jan 26, 2018

azuresdkciprbot commented Jan 26, 2018

AutorestCI commented Jan 26, 2018

AutorestCI commented Jan 26, 2018

AutorestCI commented Jan 26, 2018

AutorestCI commented Jan 26, 2018

Nilambari commented Jan 29, 2018

Network feature: Setting custom ipsec policy for Virtual Network Gateway P2S clients. #2341

Network feature: Setting custom ipsec policy for Virtual Network Gateway P2S clients. #2341

Conversation

Nilambari commented Jan 26, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented Jan 26, 2018

AutorestCI commented Jan 26, 2018

anuchandy Jan 26, 2018

Choose a reason for hiding this comment

Nilambari Jan 26, 2018

Choose a reason for hiding this comment

anuchandy Jan 26, 2018

Choose a reason for hiding this comment

anuchandy Jan 26, 2018 • edited Loading

Choose a reason for hiding this comment

Nilambari Jan 26, 2018

Choose a reason for hiding this comment

anuchandy Jan 26, 2018

Choose a reason for hiding this comment

Nilambari Jan 26, 2018

Choose a reason for hiding this comment

azuresdkciprbot commented Jan 26, 2018

azuresdkciprbot commented Jan 26, 2018

AutorestCI commented Jan 26, 2018

AutorestCI commented Jan 26, 2018

AutorestCI commented Jan 26, 2018

AutorestCI commented Jan 26, 2018

Nilambari commented Jan 29, 2018

Nilambari commented Jan 26, 2018 •

edited by azuresdkci

Loading

anuchandy Jan 26, 2018 •

edited

Loading