Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ExpressRouteCrossConnection Route Table Summary Record #2574

Merged
merged 4 commits into from
Mar 5, 2018
Merged

Update ExpressRouteCrossConnection Route Table Summary Record #2574

merged 4 commits into from
Mar 5, 2018

Conversation

gimotwanMSFT
Copy link
Contributor

Update CrossConnection Route Table Summary Record to reflect better naming for attributes in the backend.
Fix the name for CrossConnection Put Operation

Fix the name for CrossConnection Put Operation
@AutorestCI
Copy link

AutorestCI commented Mar 1, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Mar 1, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

"description": "A list of the routes table."
},
"nextLink": {
"type": "string",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be marked as readonly

},
"description": "Response for ListRoutesTable associated with the Express Route Cross Connections."
},

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove blank line

@dsgouda dsgouda self-assigned this Mar 2, 2018
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part apart from the linter validation error pointed below

"properties": {
"neighbor": {
"type": "string",
"description": "Neighbor"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a more meaningful description

@AutorestCI
Copy link

AutorestCI commented Mar 5, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit b91f5af into Azure:Network-2018-02-01 Mar 5, 2018
dsgouda pushed a commit that referenced this pull request Mar 23, 2018
… 2018 (#2642)

* Add support for Express Route Circuit Connection resource as a child of Express Route Circuit Peering in 2018-02-01 API (#2358)

* copy all files from 2018-01-01 to 2018-02-01

* update api version to 2018 in all files

* add express route circuit connection as child of express route bgp peering

* update readme.md

* add examples

* fix travis build error

* fix travis build error

* fix indentation errors

* update reference to circuit connections in peering

* fix indentation

* Merge Express Route Circuit Connection to Networking2018-02-01 (#2370)

* copy all files from 2018-01-01 to 2018-02-01

* update api version to 2018 in all files

* add express route circuit connection as child of express route bgp peering

* update readme.md

* add examples

* fix travis build error

* fix travis build error

* fix indentation errors

* update reference to circuit connections in peering

* fix indentation

* fix indentation

* fix indentation'

* get latest file

* Fix indentation

* fix key

* fix indentation and example

* fix indentation

* fix indentation

* make circuit con singular

* add fix as PR #2364 (#2376)

* Network feature: Setting custom ipsec policy for Virtual Network Gateway P2S clients. (#2521)

* 1443089: Network feature: Setting custom ipsec policy for Virtual Network Gateway P2S clients.

* 1443089:Fix network ReadMe file.

* 1443089:Fix network ReadMe file.

* Temporary bug fix

* Add support for Express Route Provider APIs (#2532)

* Add support for Express Route Provider APIs

A new top level NRP resource ExpressRouteCrossConnection is being
introduced with this change. This resource shadows the customer
ExpressRouteCircuit resouce in the customer subscription and enables
the     provider to perform CRUD operations on some of the
sub-resources, such as peerings on the ExpressRoute Circuit

* remove wrong enum values from circuit connection status and fix enum … (#2572)

* remove wrong enum values from circuit connection status and fix enum name

* Update ExpressRouteCrossConnection Route Table Summary Record (#2574)

* Update CrossConnection Route Table Summary record

* [Network-2018-02-01] DDoS Protection Plan resource (#2567)

* Initial version

* Add eol

* Add extra property in example

* Add default values for fields

* Rename operation IDs

* Make 'id' read-only for all network resources

* Revert "Make 'id' read-only for all network resources"

* Fix reference

* making peer express route circuit peering and express route circuit peering as references (#2696)

* Express Route Cross Connection Swagger changes as per PM requirements (#2644)

* Fixed operationIds for non-CRUD operations in ExpressRouteCrossConnections (#2720)

* Making travis run > 10 mins (#2739)
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
Add ExtendedLocations to AzureArcData resources, also bumped API Version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants