Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mgmt containerregistry, add readOnly #25757

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

XiaofeiCao
Copy link
Contributor

@XiaofeiCao XiaofeiCao commented Sep 12, 2023

Azure/azure-sdk-for-java#36688 (comment)

For mitigating duplicate generated models due to two properties change to readOnly.

JS and Go made the same effort. https://github.com/Azure/azure-rest-api-specs/blob/main/specification/containerregistry/resource-manager/readme.go.md

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 12, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 12, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
compared tags (via openapi-validator v2.1.4) new version base version
default default(8311736) default(main)
️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/containerregistry/resource-manager/readme.md
tag: specification/containerregistry/resource-manager/readme.md#tag-package-2023-08-preview
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 12, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking


️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 2dbdf35. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]  notice
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.6.7 -> 10.1.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.1.0` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-containerregistry [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation group ArchiveVersionsOperations
    info	[Changelog]   - Added operation group ArchivesOperations
️⚠️ azure-sdk-for-java warning [Detail]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 2dbdf35. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/containerregistry/armcontainerregistry [View full logs]  [Release SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Type of `ErrorResponse.Error` has been changed from `*ErrorResponseBody` to `*ErrorDetail`
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New enum type `PackageSourceType` with values `PackageSourceTypeRemote`
    info	[Changelog] - New function `NewArchiveVersionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ArchiveVersionsClient, error)`
    info	[Changelog] - New function `*ArchiveVersionsClient.BeginCreate(context.Context, string, string, string, string, string, *ArchiveVersionsClientBeginCreateOptions) (*runtime.Poller[ArchiveVersionsClientCreateResponse], error)`
    info	[Changelog] - New function `*ArchiveVersionsClient.BeginDelete(context.Context, string, string, string, string, string, *ArchiveVersionsClientBeginDeleteOptions) (*runtime.Poller[ArchiveVersionsClientDeleteResponse], error)`
    info	[Changelog] - New function `*ArchiveVersionsClient.Get(context.Context, string, string, string, string, string, *ArchiveVersionsClientGetOptions) (ArchiveVersionsClientGetResponse, error)`
    info	[Changelog] - New function `*ArchiveVersionsClient.NewListPager(string, string, string, string, *ArchiveVersionsClientListOptions) *runtime.Pager[ArchiveVersionsClientListResponse]`
    info	[Changelog] - New function `NewArchivesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ArchivesClient, error)`
    info	[Changelog] - New function `*ArchivesClient.BeginCreate(context.Context, string, string, string, string, Archive, *ArchivesClientBeginCreateOptions) (*runtime.Poller[ArchivesClientCreateResponse], error)`
    info	[Changelog] - New function `*ArchivesClient.BeginDelete(context.Context, string, string, string, string, *ArchivesClientBeginDeleteOptions) (*runtime.Poller[ArchivesClientDeleteResponse], error)`
    info	[Changelog] - New function `*ArchivesClient.Get(context.Context, string, string, string, string, *ArchivesClientGetOptions) (ArchivesClientGetResponse, error)`
    info	[Changelog] - New function `*ArchivesClient.NewListPager(string, string, string, *ArchivesClientListOptions) *runtime.Pager[ArchivesClientListResponse]`
    info	[Changelog] - New function `*ArchivesClient.Update(context.Context, string, string, string, string, ArchiveUpdateParameters, *ArchivesClientUpdateOptions) (ArchivesClientUpdateResponse, error)`
    info	[Changelog] - New function `*ClientFactory.NewArchiveVersionsClient() *ArchiveVersionsClient`
    info	[Changelog] - New function `*ClientFactory.NewArchivesClient() *ArchivesClient`
    info	[Changelog] - New struct `Archive`
    info	[Changelog] - New struct `ArchiveListResult`
    info	[Changelog] - New struct `ArchivePackageSourceProperties`
    info	[Changelog] - New struct `ArchiveProperties`
    info	[Changelog] - New struct `ArchiveUpdateParameters`
    info	[Changelog] - New struct `ArchiveUpdateProperties`
    info	[Changelog] - New struct `ArchiveVersion`
    info	[Changelog] - New struct `ArchiveVersionListResult`
    info	[Changelog] - New struct `ArchiveVersionProperties`
    info	[Changelog] - New struct `DebianArchivePackageSourceProperties`
    info	[Changelog] - New struct `DebianArchiveProperties`
    info	[Changelog] - New struct `ErrorAdditionalInfo`
    info	[Changelog] - New struct `ErrorDetail`
    info	[Changelog] - New struct `ErrorResponseForContainerRegistry`
    info	[Changelog]
    info	[Changelog] Total 1 breaking change(s), 43 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 2dbdf35. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-containerregistry [View full logs]  [Release SDK Changes] Breaking Change Detected
    Only show 120 items here, please refer to log for details.
    info	[Changelog]   - Added Interface ExportPipelinesDeleteOptionalParams
    info	[Changelog]   - Added Interface ExportPipelinesGetOptionalParams
    info	[Changelog]   - Added Interface ExportPipelinesListNextOptionalParams
    info	[Changelog]   - Added Interface ExportPipelinesListOptionalParams
    info	[Changelog]   - Added Interface ExportPipelineTargetProperties
    info	[Changelog]   - Added Interface ImportPipeline
    info	[Changelog]   - Added Interface ImportPipelineListResult
    info	[Changelog]   - Added Interface ImportPipelinesCreateHeaders
    info	[Changelog]   - Added Interface ImportPipelinesCreateOptionalParams
    info	[Changelog]   - Added Interface ImportPipelinesDeleteHeaders
    info	[Changelog]   - Added Interface ImportPipelinesDeleteOptionalParams
    info	[Changelog]   - Added Interface ImportPipelinesGetOptionalParams
    info	[Changelog]   - Added Interface ImportPipelinesListNextOptionalParams
    info	[Changelog]   - Added Interface ImportPipelinesListOptionalParams
    info	[Changelog]   - Added Interface ImportPipelineSourceProperties
    info	[Changelog]   - Added Interface LoggingProperties
    info	[Changelog]   - Added Interface LoginServerProperties
    info	[Changelog]   - Added Interface ParentProperties
    info	[Changelog]   - Added Interface PipelineRun
    info	[Changelog]   - Added Interface PipelineRunListResult
    info	[Changelog]   - Added Interface PipelineRunRequest
    info	[Changelog]   - Added Interface PipelineRunResponse
    info	[Changelog]   - Added Interface PipelineRunsCreateHeaders
    info	[Changelog]   - Added Interface PipelineRunsCreateOptionalParams
    info	[Changelog]   - Added Interface PipelineRunsDeleteHeaders
    info	[Changelog]   - Added Interface PipelineRunsDeleteOptionalParams
    info	[Changelog]   - Added Interface PipelineRunsGetOptionalParams
    info	[Changelog]   - Added Interface PipelineRunsListNextOptionalParams
    info	[Changelog]   - Added Interface PipelineRunsListOptionalParams
    info	[Changelog]   - Added Interface PipelineRunSourceProperties
    info	[Changelog]   - Added Interface PipelineRunTargetProperties
    info	[Changelog]   - Added Interface PipelineSourceTriggerDescriptor
    info	[Changelog]   - Added Interface PipelineSourceTriggerProperties
    info	[Changelog]   - Added Interface PipelineTriggerDescriptor
    info	[Changelog]   - Added Interface PipelineTriggerProperties
    info	[Changelog]   - Added Interface ProgressProperties
    info	[Changelog]   - Added Interface SoftDeletePolicy
    info	[Changelog]   - Added Interface StatusDetailProperties
    info	[Changelog]   - Added Interface SyncProperties
    info	[Changelog]   - Added Interface SyncUpdateProperties
    info	[Changelog]   - Added Interface TlsCertificateProperties
    info	[Changelog]   - Added Interface TlsProperties
    info	[Changelog]   - Added Type Alias ActivationStatus
    info	[Changelog]   - Added Type Alias ArchivesCreateResponse
    info	[Changelog]   - Added Type Alias ArchivesDeleteResponse
    info	[Changelog]   - Added Type Alias ArchivesGetResponse
    info	[Changelog]   - Added Type Alias ArchivesListNextResponse
    info	[Changelog]   - Added Type Alias ArchivesListResponse
    info	[Changelog]   - Added Type Alias ArchivesUpdateResponse
    info	[Changelog]   - Added Type Alias ArchiveVersionsCreateResponse
    info	[Changelog]   - Added Type Alias ArchiveVersionsDeleteResponse
    info	[Changelog]   - Added Type Alias ArchiveVersionsGetResponse
    info	[Changelog]   - Added Type Alias ArchiveVersionsListNextResponse
    info	[Changelog]   - Added Type Alias ArchiveVersionsListResponse
    info	[Changelog]   - Added Type Alias AuditLogStatus
    info	[Changelog]   - Added Type Alias AzureADAuthenticationAsArmPolicyStatus
    info	[Changelog]   - Added Type Alias CacheRulesCreateResponse
    info	[Changelog]   - Added Type Alias CacheRulesDeleteResponse
    info	[Changelog]   - Added Type Alias CacheRulesGetResponse
    info	[Changelog]   - Added Type Alias CacheRulesListNextResponse
    info	[Changelog]   - Added Type Alias CacheRulesListResponse
    info	[Changelog]   - Added Type Alias CacheRulesUpdateResponse
    info	[Changelog]   - Added Type Alias CertificateType
    info	[Changelog]   - Added Type Alias ConnectedRegistriesCreateResponse
    info	[Changelog]   - Added Type Alias ConnectedRegistriesGetResponse
    info	[Changelog]   - Added Type Alias ConnectedRegistriesListNextResponse
    info	[Changelog]   - Added Type Alias ConnectedRegistriesListResponse
    info	[Changelog]   - Added Type Alias ConnectedRegistriesUpdateResponse
    info	[Changelog]   - Added Type Alias ConnectedRegistryMode
    info	[Changelog]   - Added Type Alias ConnectionState
    info	[Changelog]   - Added Type Alias CredentialHealthStatus
    info	[Changelog]   - Added Type Alias CredentialName
    info	[Changelog]   - Added Type Alias CredentialSetsCreateResponse
    info	[Changelog]   - Added Type Alias CredentialSetsDeleteResponse
    info	[Changelog]   - Added Type Alias CredentialSetsGetResponse
    info	[Changelog]   - Added Type Alias CredentialSetsListNextResponse
    info	[Changelog]   - Added Type Alias CredentialSetsListResponse
    info	[Changelog]   - Added Type Alias CredentialSetsUpdateResponse
    info	[Changelog]   - Added Type Alias ExportPipelinesCreateResponse
    info	[Changelog]   - Added Type Alias ExportPipelinesGetResponse
    info	[Changelog]   - Added Type Alias ExportPipelinesListNextResponse
    info	[Changelog]   - Added Type Alias ExportPipelinesListResponse
    info	[Changelog]   - Added Type Alias ImportPipelinesCreateResponse
    info	[Changelog]   - Added Type Alias ImportPipelinesGetResponse
    info	[Changelog]   - Added Type Alias ImportPipelinesListNextResponse
    info	[Changelog]   - Added Type Alias ImportPipelinesListResponse
    info	[Changelog]   - Added Type Alias LogLevel
    info	[Changelog]   - Added Type Alias PackageSourceType
    info	[Changelog]   - Added Type Alias PipelineOptions
    info	[Changelog]   - Added Type Alias PipelineRunsCreateResponse
    info	[Changelog]   - Added Type Alias PipelineRunsGetResponse
    info	[Changelog]   - Added Type Alias PipelineRunsListNextResponse
    info	[Changelog]   - Added Type Alias PipelineRunsListResponse
    info	[Changelog]   - Added Type Alias PipelineRunSourceType
    info	[Changelog]   - Added Type Alias PipelineRunTargetType
    info	[Changelog]   - Added Type Alias PipelineSourceType
    info	[Changelog]   - Added Type Alias TlsStatus
    info	[Changelog]   - Interface Policies has a new optional parameter azureADAuthenticationAsArmPolicy
    info	[Changelog]   - Interface Policies has a new optional parameter softDeletePolicy
    info	[Changelog]   - Interface Registry has a new optional parameter anonymousPullEnabled
    info	[Changelog]   - Interface RegistryUpdateParameters has a new optional parameter anonymousPullEnabled
    info	[Changelog]   - Added Enum KnownActivationStatus
    info	[Changelog]   - Added Enum KnownAuditLogStatus
    info	[Changelog]   - Added Enum KnownAzureADAuthenticationAsArmPolicyStatus
    info	[Changelog]   - Added Enum KnownCertificateType
    info	[Changelog]   - Added Enum KnownConnectedRegistryMode
    info	[Changelog]   - Added Enum KnownConnectionState
    info	[Changelog]   - Added Enum KnownCredentialHealthStatus
    info	[Changelog]   - Added Enum KnownCredentialName
    info	[Changelog]   - Added Enum KnownLogLevel
    info	[Changelog]   - Added Enum KnownPackageSourceType
    info	[Changelog]   - Added Enum KnownPipelineOptions
    info	[Changelog]   - Added Enum KnownPipelineRunSourceType
    info	[Changelog]   - Added Enum KnownPipelineRunTargetType
    info	[Changelog]   - Added Enum KnownPipelineSourceType
    info	[Changelog]   - Added Enum KnownTlsStatus
    info	[Changelog]
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Type of parameter error of interface ErrorResponse is changed from ErrorResponseBody to ErrorDetail
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 2dbdf35. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.1.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.1.0` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    warn	No file changes detected after generation
  • ️✔️containerregistry [View full logs
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs]Release - Generate from 2dbdf35. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ️✔️Az.containerregistry.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.containerregistry.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 12, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/containerregistry/armcontainerregistry https://apiview.dev/Assemblies/Review/00ff7f8b0f134812a83a812b3c388336
Java azure-resourcemanager-containerregistry-generated https://apiview.dev/Assemblies/Review/d8e62873c68445da9c847f7ca4779227
.Net Azure.ResourceManager.ContainerRegistry There is no API change compared with the previous version
JavaScript @azure/arm-containerregistry https://apiview.dev/Assemblies/Review/658a24d8182e45f0b63a8ed16f0fd6e1

@XiaofeiCao XiaofeiCao marked this pull request as ready for review September 12, 2023 06:16
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 12, 2023
@XiaofeiCao XiaofeiCao removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMReview labels Sep 12, 2023
@XiaofeiCao
Copy link
Contributor Author

Only for java SDK. No need for ARM review.

@XiaofeiCao XiaofeiCao merged commit 2dbdf35 into Azure:main Sep 12, 2023
29 of 30 checks passed
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-BreakingChange-Go CI-BreakingChange-JavaScript ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants