-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mgmt containerregistry, add readOnly #25757
Merged
XiaofeiCao
merged 2 commits into
Azure:main
from
XiaofeiCao:mgmt_containerregistry_add_readonly
Sep 12, 2023
Merged
Mgmt containerregistry, add readOnly #25757
XiaofeiCao
merged 2 commits into
Azure:main
from
XiaofeiCao:mgmt_containerregistry_add_readonly
Sep 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
compared tags (via openapi-validator v2.1.4) | new version | base version |
---|---|---|
default | default(8311736) | default(main) |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/containerregistry/resource-manager/readme.md tag: specification/containerregistry/resource-manager/readme.md#tag-package-2023-08-preview |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
weidongxu-microsoft
approved these changes
Sep 12, 2023
AzureRestAPISpecReview
added
ARMReview
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
Sep 12, 2023
XiaofeiCao
removed
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
ARMReview
labels
Sep 12, 2023
Only for java SDK. No need for ARM review. |
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This was referenced Sep 12, 2023
This was referenced Sep 12, 2023
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI-BreakingChange-Go
CI-BreakingChange-JavaScript
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure/azure-sdk-for-java#36688 (comment)
For mitigating duplicate generated models due to two properties change to
readOnly
.JS and Go made the same effort. https://github.com/Azure/azure-rest-api-specs/blob/main/specification/containerregistry/resource-manager/readme.go.md