hdinsight: documenting the cluster kind #26838
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Generation Artifacts
|
Generated ApiView
|
microsoft-github-policy-service
bot
added
the
customer-reported
|
Thank you for your contribution tombuildsstuff! We will review the pull request and get back to you soon. |
There's a fixed list of possible values for this - making this an enum - as such this should be documented as an Enum.
tombuildsstuff
force-pushed
the
b/hdinsight-kind-should-be-documented
branch
from
56e95aa to
2005e96
Compare
AzureRestAPISpecReview
added
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
This was referenced Nov 24, 2023
tombuildsstuff
added a commit
to hashicorp/terraform-provider-azurerm
that referenced
this pull request
Nov 24, 2023
… lower-cased due to an issue in the API Spec The API Specification defines `tier` as a Constant which can be recased - however the `kind` is defined as a string, thus can't be. I've opened hashicorp/pandora#3404 (to workaround it) and Azure/azure-rest-api-specs#26838 (to fix it) - once those are threaded through both of these should be normalized.
tombuildsstuff
added a commit
to hashicorp/terraform-provider-azurerm
that referenced
this pull request
Nov 30, 2023
… lower-cased due to an issue in the API Spec The API Specification defines `tier` as a Constant which can be recased - however the `kind` is defined as a string, thus can't be. I've opened hashicorp/pandora#3404 (to workaround it) and Azure/azure-rest-api-specs#26838 (to fix it) - once those are threaded through both of these should be normalized.
tombuildsstuff
added a commit
to hashicorp/terraform-provider-azurerm
that referenced
this pull request
Dec 14, 2023
… lower-cased due to an issue in the API Spec The API Specification defines `tier` as a Constant which can be recased - however the `kind` is defined as a string, thus can't be. I've opened hashicorp/pandora#3404 (to workaround it) and Azure/azure-rest-api-specs#26838 (to fix it) - once those are threaded through both of these should be normalized.
tombuildsstuff
added a commit
to hashicorp/terraform-provider-azurerm
that referenced
this pull request
Dec 14, 2023
… lower-cased due to an issue in the API Spec The API Specification defines `tier` as a Constant which can be recased - however the `kind` is defined as a string, thus can't be. I've opened hashicorp/pandora#3404 (to workaround it) and Azure/azure-rest-api-specs#26838 (to fix it) - once those are threaded through both of these should be normalized.
tombuildsstuff
added a commit
to hashicorp/terraform-provider-azurerm
that referenced
this pull request
Dec 14, 2023
… lower-cased due to an issue in the API Spec The API Specification defines `tier` as a Constant which can be recased - however the `kind` is defined as a string, thus can't be. I've opened hashicorp/pandora#3404 (to workaround it) and Azure/azure-rest-api-specs#26838 (to fix it) - once those are threaded through both of these should be normalized.
tombuildsstuff
added a commit
to hashicorp/terraform-provider-azurerm
that referenced
this pull request
Jan 25, 2024
… lower-cased due to an issue in the API Spec The API Specification defines `tier` as a Constant which can be recased - however the `kind` is defined as a string, thus can't be. I've opened hashicorp/pandora#3404 (to workaround it) and Azure/azure-rest-api-specs#26838 (to fix it) - once those are threaded through both of these should be normalized.
tombuildsstuff
added a commit
to hashicorp/terraform-provider-azurerm
that referenced
this pull request
Jan 26, 2024
… lower-cased due to an issue in the API Spec The API Specification defines `tier` as a Constant which can be recased - however the `kind` is defined as a string, thus can't be. I've opened hashicorp/pandora#3404 (to workaround it) and Azure/azure-rest-api-specs#26838 (to fix it) - once those are threaded through both of these should be normalized.
rizkybiz
pushed a commit
to rizkybiz/terraform-provider-azurerm
that referenced
this pull request
Jan 30, 2024
… lower-cased due to an issue in the API Spec The API Specification defines `tier` as a Constant which can be recased - however the `kind` is defined as a string, thus can't be. I've opened hashicorp/pandora#3404 (to workaround it) and Azure/azure-rest-api-specs#26838 (to fix it) - once those are threaded through both of these should be normalized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
ARMReviewlabel.Click here to see the diagram footnotes
Diagram footnotes
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.