-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Subscription RP] Add AdditionalParameters property to SubscriptionCreationParameters #2736
Conversation
…to support Microsoft-internal subscription creation scenarios.
Automation for azure-libraries-for-javaNothing to generate for azure-libraries-for-java |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
CC @lmazuel as he's reviewed previous PRs for this swagger. |
@olydis if you don't mind, I indeed reviewed the previous one and even suggested to use additionalProperty on an email thread, I steal you this review ;) |
@annatisch FYI |
@@ -172,6 +172,12 @@ | |||
"MS-AZR-0017P", | |||
"MS-AZR-0148P" | |||
] | |||
}, | |||
"additionalParameters":{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have an actual "additionalParameters" node in your JSON? Could you update an example with this node, I'm always more confident when I see an example if "additionalProperties" is used (regular source of trouble :))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I messed it up too. :) Added an example and made sure it's passing validation.
This property will be used for Microsoft-internal subscription creation scenarios.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger