Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subscription RP] Add AdditionalParameters property to SubscriptionCreationParameters #2736

Merged
merged 4 commits into from
Mar 23, 2018

Conversation

wilcobmsft
Copy link
Member

@wilcobmsft wilcobmsft commented Mar 22, 2018

This property will be used for Microsoft-internal subscription creation scenarios.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

…to support Microsoft-internal subscription creation scenarios.
@AutorestCI
Copy link

AutorestCI commented Mar 22, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented Mar 22, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Mar 22, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2241

@AutorestCI
Copy link

AutorestCI commented Mar 22, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1404

@wilcobmsft
Copy link
Member Author

CC @lmazuel as he's reviewed previous PRs for this swagger.

@lmazuel
Copy link
Member

lmazuel commented Mar 22, 2018

@olydis if you don't mind, I indeed reviewed the previous one and even suggested to use additionalProperty on an email thread, I steal you this review ;)

@lmazuel lmazuel assigned lmazuel and unassigned olydis Mar 22, 2018
@lmazuel
Copy link
Member

lmazuel commented Mar 22, 2018

@annatisch FYI

@@ -172,6 +172,12 @@
"MS-AZR-0017P",
"MS-AZR-0148P"
]
},
"additionalParameters":{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have an actual "additionalParameters" node in your JSON? Could you update an example with this node, I'm always more confident when I see an example if "additionalProperties" is used (regular source of trouble :))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I messed it up too. :) Added an example and made sure it's passing validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants