Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppConfig] Migrate App Configuration swagger to TypeSpec #28634

Merged
merged 53 commits into from
May 14, 2024

Conversation

catalinaperalta
Copy link
Member

@catalinaperalta catalinaperalta commented Apr 9, 2024

Migrating App Configuration's latest stable API version 2023-11-01 to TypeSpec

Copy link

openapi-pipeline-app bot commented Apr 9, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Apr 9, 2024

Swagger Validation Report

️❌BreakingChange: 259 Errors, 0 Warnings failed [Detail]
Compared specs (v0.10.8) new version base version
appconfiguration.json 2023-11-01(709ccc8) 2023-11-01(main)

Only 30 items are listed, please refer to log for more details.

Rule Message
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L66:9
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L19:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L28:3
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L86:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L219:9
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L142:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L28:3
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L257:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L610:9
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L361:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L793:9
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L457:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L909:9
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L542:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L28:3
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L622:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1955:9
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L704:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L28:3
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L771:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L2214:9
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L815:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L2407:9
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L902:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L2501:9
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L980:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L28:3
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1064:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1170:9
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1135:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L28:3
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1205:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1378:9
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1264:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1477:9
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1341:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1619:9
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1420:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L28:3
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1511:9
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SyncTokens' removed or renamed?
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L3307:3
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L2003:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ApiVersion' removed or renamed?
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L3307:3
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L2003:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'Endpoint' removed or renamed?
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L3307:3
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L2003:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'KeyValueFields' removed or renamed?
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L3307:3
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L2003:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'LabelFields' removed or renamed?
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L3307:3
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L2003:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SnapshotFields' removed or renamed?
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L3307:3
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L2003:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'Status' removed or renamed?
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L3307:3
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L2003:3
1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L90:11
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L23:9
1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L71:9
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L23:9
1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L82:11
Old: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L36:11
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 46 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2023-11-01 package-2023-11-01(709ccc8) package-2023-11-01(main)

[must fix]The following errors/warnings are introduced by current PR:

Only 30 items are listed, please refer to log for more details.

Rule Message Related RPC [For API reviewers]
⚠️ SecurityDefinitionDescription Security definition should have a description.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L45
⚠️ SecurityDefinitionDescription Security definition should have a description.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L50
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L62
⚠️ ParameterNamesConvention Parameter name 'After' should be camel case.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L83
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L147
⚠️ ErrorResponse Error response schema should contain an object property named error.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L202
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L215
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L419
⚠️ ErrorResponse Error response schema should contain an object property named error.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L587
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L606
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L619
⚠️ ParameterNamesConvention Parameter name '$Select' should not begin with '$' or '@'.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L634
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L789
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L810
⚠️ RequestBodyOptional The body parameter is not marked as required.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L855
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L905
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L918
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1005
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1013
⚠️ ErrorResponse Error response schema should contain an object property named error.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1147
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1166
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1280
⚠️ ErrorResponse Error response schema should contain an object property named error.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1361
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1374
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1387
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1473
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1486
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1574
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1615
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L1793


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L62
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L63
⚠️ OperationId OperationId for get method on a collection should contain 'List'
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L63
⚠️ PaginationResponse Response body schema of pageable response should contain top-level array property value
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L110
⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L131
⚠️ ErrorResponse Error response schema should contain an object property named error.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L133
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L148
⚠️ ParameterNamesConvention Parameter name 'After' should be camel case.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L171
⚠️ SuccessResponseBody All success responses except 202 & 204 should define a response body.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L191
⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L200
⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L215
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L216
⚠️ OperationId OperationId for get method on a collection should contain 'List'
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L216
⚠️ ParameterNamesConvention Parameter name 'After' should be camel case.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L251
⚠️ ParameterNamesConvention Parameter name '$Select' should not begin with '$' or '@'.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L267
⚠️ PaginationResponse Response body schema of pageable response should contain top-level array property value
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L372
⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L397
⚠️ ErrorResponse Error response schema should contain an object property named error.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L399
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L420
⚠️ ParameterNamesConvention Parameter name 'After' should be camel case.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L450
⚠️ ParameterNamesConvention Parameter name '$Select' should not begin with '$' or '@'.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L466
⚠️ SuccessResponseBody All success responses except 202 & 204 should define a response body.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L572
⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L585
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L607
⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L770
⚠️ ErrorResponse Error response schema should contain an object property named error.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L772
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L790
⚠️ OperationId OperationId for put method should contain 'Create' or 'Update'
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L790
⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L889
⚠️ ErrorResponse Error response schema should contain an object property named error.
Location: Microsoft.AppConfiguration/stable/2023-11-01/appconfiguration.json#L891
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Apr 9, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from 943e06fb2662094b1c199d7a4258ff61c4aebf18. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh]  notice
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
    cmderr	[automation_init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
    cmderr	[automation_init.sh] npm notice Run `npm install -g npm@10.7.0` to update!
    cmderr	[automation_init.sh] npm notice
    warn		specification/appconfiguration/data-plane/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-appconfiguration [Preview SDK Changes]
    • azure-appconfiguration-1.0.0b1.zip
    • azure_appconfiguration-1.0.0b1-py3-none-any.whl
    info	[Changelog] data-plan skip changelog generation temporarily
️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed in generating from 943e06fb2662094b1c199d7a4258ff61c4aebf18. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    warn		specification/appconfiguration/data-plane/readme.md skipped due to azure-sdk-for-net-track2 not found in swagger-to-sdk
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  131 |                GeneratePackage `
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  131 |                GeneratePackage `
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact
  • Azure.Data.AppConfiguration [Preview SDK Changes]
    info	[Changelog]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 943e06fb2662094b1c199d7a4258ff61c4aebf18. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    warn		specification/appconfiguration/data-plane/readme.md skipped due to azure-sdk-for-js not found in swagger-to-sdk
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure-rest/azure-appconfiguration-rest [Preview SDK Changes]
    • azure-rest-azure-appconfiguration-rest-1.0.0-beta.1.tgz
    info	[Changelog]
    error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️❌ azure-sdk-for-java failed [Detail]
  • Failed in generating from 943e06fb2662094b1c199d7a4258ff61c4aebf18. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    warn		specification/appconfiguration/data-plane/readme.md skipped due to azure-sdk-for-java not found in swagger-to-sdk
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    cmderr	[generate.py] [COMPILE] Maven build fail.
    cmderr	[generate.py] One reason of the compilation failure is that the existing code customization in SDK repository being incompatible with the class generated from updated TypeSpec source. In such case, you can ignore the failure, and fix the customization in SDK repository.
    cmderr	[generate.py] You can inquire in "Language - Java" Teams channel. Please include the link of this Pull Request in the query.
  • azure-data-appconfiguration [Preview SDK Changes]
    • pom.xml
Posted by Swagger Pipeline | How to fix these errors?

@catalinaperalta catalinaperalta marked this pull request as ready for review May 3, 2024 22:46
@catalinaperalta catalinaperalta requested a review from a team as a code owner May 3, 2024 22:46
@catalinaperalta catalinaperalta requested review from tg-msft and mikekistler and removed request for a team May 3, 2024 22:46
@mikekistler mikekistler added the BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. label May 4, 2024
Copy link
Member

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@catalinaperalta catalinaperalta merged commit 3531504 into main May 14, 2024
29 of 32 checks passed
@catalinaperalta catalinaperalta deleted the feature/appconfig-tsp branch May 14, 2024 17:17
Francisco-Gamino pushed a commit to Francisco-Gamino/azure-rest-api-specs that referenced this pull request Jun 5, 2024
* initial commit + cleanup

* add docs + cleanup linter warnings

* add auth + update swagger

* convert models to resources

* update routes with standard ops + more accuracy

* regenerate openapi

* add examples

* flavor: azure

* tsp format

* add spec examples

* fix accept header + spec consistency

* fix nextLink + headers

* use encodedName

* fix accept header

* fix enums

* format

* move accept header

* remove comment

* format

* spelling

* test examples

* fix examples

* wip

* content type header

* fix delete content type + getlabels op

* clean up

* update suppression

* add consumes

* fix error

* rename alias

* alias sync token header

* tsp compile

* fix errors

* improvements

* more improvements

* fix datetimes

* client generation fixes

* more clean up

* add scope + request id headers

* add service op template

* improve template

* client request id header

* property type fix

* tsp compile

* client.tsp

* tsp update

---------

Co-authored-by: Catalina Peralta <caperal@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants