Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eng/scripts/DirStructureStats.ps1 #29317

Closed
wants to merge 2 commits into from

Conversation

konrad-jamrozik
Copy link

No description provided.

Copy link

openapi-pipeline-app bot commented Jun 4, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Jun 4, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️⌛Automated merging requirements met pending [Detail]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Jun 4, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Jun 4, 2024

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@konrad-jamrozik konrad-jamrozik added Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. labels Jun 4, 2024
Copy link
Member

@mikeharder mikeharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do this in pwsh or node? I'd lean towards node.

@weshaggard
Copy link
Member

weshaggard commented Jun 5, 2024

What is the context for these?
I also have https://github.com/Azure/azure-sdk/blob/main/eng/scripts/Update-Spec-Versions.ps1 which builds an index of the specs. I'd like use to have one source of truth if possible for how we determine different aspects. If needed we could move my script to the specs repo.

@konrad-jamrozik
Copy link
Author

@mikeharder @weshaggard my intent with these scripts was to share a "starting point" scripts people can use for manual analysis. Like: you dot-source the functions I shared, run them, get the table of results, and do manual post-processing by hand with search-and-replace in notepad++ or whatever (that's how I do it). This is also the reason for using PowerShell, not Node - this is supposed to be easily runnable by hand. Of course I can keep these scripts to myself only, but I figured I might as well share them with the team.

Given this context, do have a better idea how to share them?

@weshaggard
Copy link
Member

I don't have any problems including them here but I'm mostly just wanting us to try and get to a point where we can easily have shared code that understands the discovery mechanism of specs.

@konrad-jamrozik
Copy link
Author

I'll do the scripts consolidation as part of:

@mikeharder
Copy link
Member

mikeharder commented Jun 6, 2024

Given this context, do have a better idea how to share them?

I think it's premature to add them to the repo, until we have a better idea who else will be using them, and how often. For now, I would share them via another artifact in GitHub, like a closed issue in this repo, or a Public Gist. This is my opinion, but if others disagree, I won't block.

@mikeharder mikeharder self-requested a review June 6, 2024 04:42
@mikeharder mikeharder dismissed their stale review June 6, 2024 04:51

I no longer object

@konrad-jamrozik
Copy link
Author

I'll convert this to Gist. Thanks!

@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/dir_stats_scripts branch July 12, 2024 21:54
@konrad-jamrozik konrad-jamrozik restored the users/kojamroz/dir_stats_scripts branch July 12, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. PipelineBotTrigger Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants