-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SKU property to site. Add description for supported values of kin… #29354
Merged
naveedaz
merged 6 commits into
Azure:release-web-2024-04-01
from
naveedaz:release-web-2024-04-01
Jun 10, 2024
Merged
Add SKU property to site. Add description for supported values of kin… #29354
naveedaz
merged 6 commits into
Azure:release-web-2024-04-01
from
naveedaz:release-web-2024-04-01
Jun 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d property on app
Next Steps to Merge⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛ |
Swagger Validation Report
|
Compared specs (v0.10.9) | new version | base version |
---|---|---|
CommonDefinitions.json | 2024-04-01(4d05d62) | 2023-12-01(main) |
️⚠️
LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) | new version | base version |
---|---|---|
package-2024-04 | package-2024-04(4d05d62) | package-2024-04(release-web-2024-04-01) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
GetCollectionResponseSchema |
The response in the GET collection operation 'Recommendations_ListRecommendedRulesForHostingEnvironment' does not match the response definition in the individual GET operation 'Recommendations_GetRuleDetailsByHostingEnvironment' . Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L17 |
GetCollectionResponseSchema |
The response in the GET collection operation 'Recommendations_ListRecommendedRulesForWebApp' does not match the response definition in the individual GET operation 'Recommendations_GetRuleDetailsByWebApp' . Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L17 |
GetCollectionResponseSchema |
The response in the GET collection operation 'WebApps_ListRelayServiceConnections' does not match the response definition in the individual GET operation 'WebApps_GetRelayServiceConnection' . Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L17 |
GetCollectionResponseSchema |
The response in the GET collection operation 'WebApps_ListRelayServiceConnectionsSlot' does not match the response definition in the individual GET operation 'WebApps_GetRelayServiceConnectionSlot' . Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L17 |
GetCollectionResponseSchema |
The response in the GET collection operation 'WebApps_ListPremierAddOns' does not match the response definition in the individual GET operation 'WebApps_GetPremierAddOn' . Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L17 |
GetCollectionResponseSchema |
The response in the GET collection operation 'WebApps_ListPremierAddOnsSlot' does not match the response definition in the individual GET operation 'WebApps_GetPremierAddOnSlot' . Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L17 |
GuidUsage |
Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L684 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L713 |
ProvisioningStateValidation |
ProvisioningState must have terminal states: Succeeded, Failed and Canceled. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L981 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L1024 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L1800 |
NestedResourcesMustHaveListOperation |
The nested resource 'HybridConnection' does not have list operation, please add it. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L1819 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L1978 |
GuidUsage |
Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L2252 |
GuidUsage |
Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L3097 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L3605 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L4147 |
NestedResourcesMustHaveListOperation |
The nested resource 'VnetGateway' does not have list operation, please add it. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L4314 |
NestedResourcesMustHaveListOperation |
The nested resource 'VnetInfoResource' does not have list operation, please add it. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L4391 |
NestedResourcesMustHaveListOperation |
The nested resource 'VnetRoute' does not have list operation, please add it. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L4408 |
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L125 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L147 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L190 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L286 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L291 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L306 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L325 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L334 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L343 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L382 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌
SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️⌛
PR Summary pending [Detail]
️⌛
Automated merging requirements met pending [Detail]
Swagger Generation Artifacts
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
AzureRestAPISpecReview
added
ARMReview
resource-manager
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
Jun 6, 2024
This was referenced Jun 6, 2024
rkmanda
approved these changes
Jun 9, 2024
rkmanda
added
the
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
label
Jun 9, 2024
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Jun 9, 2024
…st-api-specs into release-web-2024-04-01
naveedaz
merged commit Jun 10, 2024
5dc4d55
into
Azure:release-web-2024-04-01
18 of 29 checks passed
naveedaz
added a commit
that referenced
this pull request
Sep 26, 2024
* Release web 2024 04 01 (#28952) * Copy files from stable/2023-12-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-04-01 Updated the API version from stable/2023-12-01 to stable/2024-04-01. * Added tag for 2024-04-01 in readme file * Copy files from stable/2023-12-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-04-01 Updated the API version from stable/2023-12-01 to stable/2024-04-01. * Added tag for 2024-04-01 in readme file * Copy files from stable/2023-12-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-04-01 Updated the API version from stable/2023-12-01 to stable/2024-04-01. * Added tag for 2024-04-01 in readme file * Fix RP merge issue * Fix prettier failute * Fix spellcheck for sitecontainers * Fix prettier check failures * Fix ALL prettier check failures * Add LeastRequestsWithTieBreaker (#29128) * Add LeastRequestsWithTieBreaker * Change to target 2024-04-01 --------- Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> * Update 2023-12-01 Microsoft.Web functionAppConfig definition (#29226) (#29350) * Update 2023-12-01 Microsoft.Web functionAppConfig definition (#29226) * Rename enum to functionsDeploymentStorageType * Update enum name to camel case * Update enum names to camel case * Port changes to 2024-04-01 API version * Rename storageType to FunctionsDeploymentStorageType * Update enum name's to use amelcase casing --------- Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * Add SKU property to site. Add description for supported values of kin… (#29354) * Add SKU property to site. Add description for supported values of kind property on app * Fix typo * Fix prettier * User/rohinisharma/update instance info (#29333) * Adding parameter to Website Instance Info obj * Prettier --------- Co-authored-by: Rohini Sharma <rohinisharma@microsoft.com> Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * [AppServices] Add AutoGeneratedDomainNameLabelScope to Websites (#29649) * [DNL] Add AutoGeneratedDomainNameLabelScope to Websites * fix casing * fix prettier * Add e2e tls to latest releases (#29904) Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> * Add updatemachinekey api (#29730) * Add updatemachinekey api * fix json formatting * Change api version * Add machinekey to allowed words * action verb at end of address * Change post address to conform to arm --------- Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * Developer/nineela/autogenerateddomainnamelabelscope edit 2 (#30047) * [DNL] Add AutoGeneratedDomainNameLabelScope to Websites * Minor comment update * Add IP Mode to Websites (#29089) * Add IP Mode to Websites * Target 2024-04-01 * Fix linter --------- Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig (#30050) * Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig (#29907) * Set format to int32 for all number types in the functionAppConfig * Update types to integer. --------- Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * Update types to integer and set format to int32 for all number types in the functionAppConfig --------- Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * Add CipherSuites object to support discoverability API (#30067) Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> Co-authored-by: Naveed Aziz <naveeda@microsoft.com> --------- Co-authored-by: Chris Rosenblatt <rosench13@gmail.com> Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> Co-authored-by: Francisco Gamino <Francisco-Gamino@users.noreply.github.com> Co-authored-by: rohinisharma <rohini2@illinois.edu> Co-authored-by: Rohini Sharma <rohinisharma@microsoft.com> Co-authored-by: nineela <82120829+nineela@users.noreply.github.com> Co-authored-by: andrewschuck <115187222+andrewschuck@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
resource-manager
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d property on app
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.