Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] pr remove body parameter #29800

Closed
wants to merge 2 commits into from
Closed

[Test] pr remove body parameter #29800

wants to merge 2 commits into from

Conversation

weidongxu-microsoft
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 12, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is public specs repo main branch which not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 12, 2024 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
Compared specs (v0.10.12) new version base version
generated.json 2023-06-01-preview(897a85f) 2023-06-01-preview(main)
generated.json 2023-07-01-preview(897a85f) 2023-07-01-preview(main)
generated.json 2024-02-15-preview(897a85f) 2024-02-15-preview(main)
generated.json 2024-03-01-preview(897a85f) 2024-03-01-preview(main)
generated.json 2024-04-01-preview(897a85f) 2024-04-01-preview(main)
generated.json 2024-05-01-preview(897a85f) 2024-05-01-preview(main)
generated.json 2023-05-15(897a85f) 2023-05-15(main)
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️⚠️LintDiff: 6 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
release_2023_05_15_autogen release_2023_05_15_autogen(897a85f) release_2023_05_15_autogen(main)
release_2023_06_01_preview_autogen release_2023_06_01_preview_autogen(897a85f) release_2023_06_01_preview_autogen(main)
release_2023_07_01_preview_autogen release_2023_07_01_preview_autogen(897a85f) release_2023_07_01_preview_autogen(main)
release_2024_02_15_preview_autogen release_2024_02_15_preview_autogen(897a85f) release_2024_02_15_preview_autogen(main)
release_2024_03_01_preview_autogen release_2024_03_01_preview_autogen(897a85f) release_2024_03_01_preview_autogen(main)
release_2024_05_01_preview_autogen release_2024_05_01_preview_autogen(897a85f) release_2024_05_01_preview_autogen(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ ParameterDescription Parameter should have a description.
Location: inference/preview/2023-06-01-preview/generated.json#L77
⚠️ ParameterDescription Parameter should have a description.
Location: inference/preview/2023-07-01-preview/generated.json#L77
⚠️ ParameterDescription Parameter should have a description.
Location: inference/preview/2024-02-15-preview/generated.json#L404
⚠️ ParameterDescription Parameter should have a description.
Location: inference/preview/2024-03-01-preview/generated.json#L404
⚠️ ParameterDescription Parameter should have a description.
Location: inference/preview/2024-05-01-preview/generated.json#L438
⚠️ ParameterDescription Parameter should have a description.
Location: inference/stable/2023-05-15/generated.json#L77


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: inference/preview/2023-06-01-preview/generated.json#L426
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: inference/preview/2023-06-01-preview/generated.json#L497
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: inference/preview/2023-06-01-preview/generated.json#L796
❌ DefaultInEnum Default value should appear in the enum constraint for a schema
Location: inference/preview/2023-06-01-preview/generated.json#L1292
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: inference/preview/2023-06-01-preview/generated.json#L1356
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: inference/preview/2023-07-01-preview/generated.json#L426
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: inference/preview/2023-07-01-preview/generated.json#L497
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: inference/preview/2023-07-01-preview/generated.json#L849
❌ DefaultInEnum Default value should appear in the enum constraint for a schema
Location: inference/preview/2023-07-01-preview/generated.json#L1389
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: inference/preview/2023-07-01-preview/generated.json#L1453
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: inference/preview/2024-02-15-preview/generated.json#L2053
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: inference/preview/2024-02-15-preview/generated.json#L2696
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: inference/preview/2024-02-15-preview/generated.json#L3698
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: inference/preview/2024-03-01-preview/generated.json#L2053
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: inference/preview/2024-03-01-preview/generated.json#L2696
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: inference/preview/2024-03-01-preview/generated.json#L3729
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: inference/preview/2024-05-01-preview/generated.json#L2344
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: inference/preview/2024-05-01-preview/generated.json#L2987
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: inference/preview/2024-05-01-preview/generated.json#L4065
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: inference/stable/2023-05-15/generated.json#L317
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: inference/stable/2023-05-15/generated.json#L602
⚠️ SecurityDefinitionDescription Security definition should have a description.
Location: inference/preview/2023-06-01-preview/generated.json#L46
⚠️ SecurityDefinitionDescription Security definition should have a description.
Location: inference/preview/2023-06-01-preview/generated.json#L51
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: inference/preview/2023-06-01-preview/generated.json#L64
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: inference/preview/2023-06-01-preview/generated.json#L70
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: inference/preview/2023-06-01-preview/generated.json#L115
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: inference/preview/2023-06-01-preview/generated.json#L121
⚠️ PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
Location: inference/preview/2023-06-01-preview/generated.json#L166
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: inference/preview/2023-06-01-preview/generated.json#L167
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: inference/preview/2023-06-01-preview/generated.json#L173
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand] 
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 12, 2024 •
edited
Loading

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand] 
 Please click here to preview with your @microsoft account.
️❌ azure-sdk-for-net-track2 failed [Detail]
    For more instructions, please refer to the FAQ .
  • ❌Failed in generating from fd8e0c9dcbe287ce5cf412fd1bce75a9947bcc37. SDK Automation 14.0.0 
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn		Warning: azure-sdk-for-net-track2 cannot be found in specification/cognitiveservices/data-plane/AzureOpenAI/inference/readme.md. This SDK will be skipped from SDK generation. Please add the right config to the readme file according to this guidance https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/code-gen/configure-go-sdk.md#swagger-to-sdk.
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] [Warn]: Enum 'ServiceApiVersions' must have a description
cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice
cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice To update run: npm install -g npm@10.8.2
cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:144
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  144 |              GeneratePackage `
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |              ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to build project. exit code: False
  • ❌Azure.AI.OpenAI [Preview SDK Changes] 
    info	[Changelog]
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from fd8e0c9dcbe287ce5cf412fd1bce75a9947bcc37. SDK Automation 14.0.0 
    command	./eng/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
warn		Warning: azure-sdk-for-java cannot be found in specification/cognitiveservices/data-plane/AzureOpenAI/inference/readme.md. This SDK will be skipped from SDK generation. Please add the right config to the readme file according to this guidance https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/code-gen/configure-go-sdk.md#swagger-to-sdk.
command	./eng/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
command	./eng/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
info	[Changelog]
command	./eng/automation/install_instruction.py ../azure-sdk-for-java_tmp/installInstructionInput.json ../azure-sdk-for-java_tmp/installInstructionOutput.json
  • ️✔️azure-ai-openai [Preview SDK Changes] 
    info	[Changelog]
️❌ azure-sdk-for-js failed [Detail]
    For more instructions, please refer to the FAQ .
  • ❌Failed in generating from fd8e0c9dcbe287ce5cf412fd1bce75a9947bcc37. SDK Automation 14.0.0 
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
warn		Warning: azure-sdk-for-js cannot be found in specification/cognitiveservices/data-plane/AzureOpenAI/inference/readme.md. This SDK will be skipped from SDK generation. Please add the right config to the readme file according to this guidance https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/code-gen/configure-go-sdk.md#swagger-to-sdk.
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Error:
cmderr	[automation_generate.sh] [ERROR] Error:
cmderr	[automation_generate.sh] [ERROR] An error occurred while run build for typespec project: "specification/cognitiveservices/OpenAI.Inference":
cmderr	[automation_generate.sh] [ERROR] An error occurred while run build for typespec project: "specification/cognitiveservices/OpenAI.Inference":
cmderr	[automation_generate.sh] [ERROR] Err: Error: Command failed: rush build -t @azure/openai
cmderr	[automation_generate.sh] [ERROR] Err: Error: Command failed: rush build -t @azure/openai
cmderr	[automation_generate.sh] [ERROR] Stderr: "null"
cmderr	[automation_generate.sh] [ERROR] Stderr: "null"
cmderr	[automation_generate.sh] [ERROR] Stdout: "null"
cmderr	[automation_generate.sh] [ERROR] Stdout: "null"
cmderr	[automation_generate.sh] [ERROR] ErrorStack: "Error: Command failed: rush build -t @azure/openai
cmderr	[automation_generate.sh] [ERROR] ErrorStack: "Error: Command failed: rush build -t @azure/openai
cmderr	[automation_generate.sh] [ERROR]     at checkExecSyncError (node:child_process:885:11)
cmderr	[automation_generate.sh] [ERROR]     at checkExecSyncError (node:child_process:885:11)
cmderr	[automation_generate.sh] [ERROR]     at execSync (node:child_process:957:15)
cmderr	[automation_generate.sh] [ERROR]     at execSync (node:child_process:957:15)
cmderr	[automation_generate.sh] [ERROR]     at /home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/llc/generateRLCInPipeline/generateRLCInPipeline.js:209:42
cmderr	[automation_generate.sh] [ERROR]     at /home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/llc/generateRLCInPipeline/generateRLCInPipeline.js:209:42
cmderr	[automation_generate.sh] [ERROR]     at Generator.next (<anonymous>)
cmderr	[automation_generate.sh] [ERROR]     at Generator.next (<anonymous>)
cmderr	[automation_generate.sh] [ERROR]     at fulfilled (/home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:112:62)
cmderr	[automation_generate.sh] [ERROR]     at fulfilled (/home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:112:62)
cmderr	[automation_generate.sh] [ERROR]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"
cmderr	[automation_generate.sh] [ERROR]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
  • ❌@azure/openai [Preview SDK Changes] 
    info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 12, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Java azure-ai-openai https://apiview.dev/Assemblies/Review/0b875c11102a447c8807ad710b3d4e7c?revisionId=dd9a383ec0cb4144bdbebcfa8dcf673b
TypeSpec OpenAI.Inference https://apiview.dev/Assemblies/Review/b8c186a18c34460e831aaed4436c9b43?revisionId=26f3420fbf3c44faab4b6319fbfaa8e5
Swagger AzureOpenAI https://apiview.dev/Assemblies/Review/6693675ace534d4aa3159f202a195962?revisionId=8dece788a8b34e6bb4c50d545164e092

This was referenced Jul 12, 2024
Closed
Closed
Closed
@weidongxu-microsoft weidongxu-microsoft mentioned this pull request Jul 12, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangyuan yangyuan Awaiting requested review from yangyuan yangyuan will be requested when the pull request is marked ready for review yangyuan is a code owner

Assignees
No one assigned
Labels
data-plane TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weidongxu-microsoft @AzureRestAPISpecReview