Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverting cspell.json changes #30285

Merged
merged 2 commits into from
Aug 21, 2024
Merged

reverting cspell.json changes #30285

merged 2 commits into from
Aug 21, 2024

Conversation

ravigautam1896
Copy link
Contributor

@ravigautam1896 ravigautam1896 commented Aug 21, 2024 •
edited
Loading

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 21, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 21, 2024 •
edited
Loading

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@ravigautam1896 ravigautam1896 marked this pull request as ready for review August 21, 2024 15:38
@jeremyfrosti jeremyfrosti merged commit 08acca3 into Azure:release-sql-Microsoft.Sql-2024-05-01-preview Aug 21, 2024
27 of 28 checks passed
ravigautam1896 added a commit that referenced this pull request Sep 16, 2024
@ravigautam1896 @psong-ms
@UrosKrsticMIPerf @ivanarandjelovic @akromm @rkmanda @mikeharder
Release sql microsoft.sql 2024 05 01 preview (#30510)
4092328 
* Adding folders and examples changes for Version 2024-05-01 preview version (#29200)

* Adds base for updating Microsoft.Sql from version preview/2023-08-01-preview to version 2024-05-01-preview

* Updates API version in new specs and examples

* Updates readme

* addressing comments

* resolving spell check errors

* resolving LroLocationheader errors

* supress errors from DatabaseAdvisiors.json

* reverting the supression

---------

Co-authored-by: Ravi Gautam <ravigautam@microsoft.com>

* Update for Import/Export with Managed Identity (#29596)

* Update for Import/Export with Managed Identity

* Fix the example reference and update description

* Set the additionalProperties type to string for DatabaseAdvisors API (#29823)

* Set the new additionalProperties type to string

* Remove the required type for additionalProperties, just keep them true

* Dev/ivarandj/instance pool operations api (#29932)

* Add instance pool operations swagger and examples

* Address prettier check errors

* Fix Swagger LintDiff errors

* Fix parameter names to match parameter patterns

* Remove validation for resourceGroupName parameter as it fails Swagger ModelValidation (and it should not be failing)

* Replace bool with enum (PR review remark)

---------

Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com>

* Adding updated DatabaseOperations.json file (#29956)

* Adding updated DatabaseOperations.json file

* Trying to fix ModelValidation error

* Reverting testing change

---------

Co-authored-by: Roopesh Manda <rmanda@microsoft.com>

* Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview (#30030)

* taking changes from dsmaindev side

* removing further DatabaseAdvisor.json changes

* resolving spellcheck validation

* resolving ModelValidation errors

* resolving avocado errors

* resolving LRO Headers Validation and xmsEnum Validation

* resolving indentation

---------

Co-authored-by: Ravi Gautam <ravigautam@microsoft.com>

* resolve merge conflict for cSpell.json (#30179)

Co-authored-by: Ravi Gautam <ravigautam@microsoft.com>

* reverting cspell.json changes (#30285)

* reverting cspell.json changes

* revert changes2

---------

Co-authored-by: Ravi Gautam <ravigautam@microsoft.com>

* Fix lintdiff enum errpr (#30383)

Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com>

---------

Co-authored-by: Ravi Gautam <ravigautam@microsoft.com>
Co-authored-by: psong-ms <147777703+psong-ms@users.noreply.github.com>
Co-authored-by: UrosKrsticMIPerf <150959695+UrosKrsticMIPerf@users.noreply.github.com>
Co-authored-by: Ivan Arandjelovic <ivan.arandjelovic@gmail.com>
Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com>
Co-authored-by: akromm <87152103+akromm@users.noreply.github.com>
Co-authored-by: Roopesh Manda <rmanda@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
jaskisin pushed a commit to jaskisin/azure-rest-api-specs that referenced this pull request Sep 16, 2024
@ravigautam1896 @psong-ms
@UrosKrsticMIPerf @ivanarandjelovic @akromm @rkmanda @mikeharder
Release sql microsoft.sql 2024 05 01 preview (Azure#30510)
2c14479 
* Adding folders and examples changes for Version 2024-05-01 preview version (Azure#29200)

* Adds base for updating Microsoft.Sql from version preview/2023-08-01-preview to version 2024-05-01-preview

* Updates API version in new specs and examples

* Updates readme

* addressing comments

* resolving spell check errors

* resolving LroLocationheader errors

* supress errors from DatabaseAdvisiors.json

* reverting the supression

---------

Co-authored-by: Ravi Gautam <ravigautam@microsoft.com>

* Update for Import/Export with Managed Identity (Azure#29596)

* Update for Import/Export with Managed Identity

* Fix the example reference and update description

* Set the additionalProperties type to string for DatabaseAdvisors API (Azure#29823)

* Set the new additionalProperties type to string

* Remove the required type for additionalProperties, just keep them true

* Dev/ivarandj/instance pool operations api (Azure#29932)

* Add instance pool operations swagger and examples

* Address prettier check errors

* Fix Swagger LintDiff errors

* Fix parameter names to match parameter patterns

* Remove validation for resourceGroupName parameter as it fails Swagger ModelValidation (and it should not be failing)

* Replace bool with enum (PR review remark)

---------

Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com>

* Adding updated DatabaseOperations.json file (Azure#29956)

* Adding updated DatabaseOperations.json file

* Trying to fix ModelValidation error

* Reverting testing change

---------

Co-authored-by: Roopesh Manda <rmanda@microsoft.com>

* Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview (Azure#30030)

* taking changes from dsmaindev side

* removing further DatabaseAdvisor.json changes

* resolving spellcheck validation

* resolving ModelValidation errors

* resolving avocado errors

* resolving LRO Headers Validation and xmsEnum Validation

* resolving indentation

---------

Co-authored-by: Ravi Gautam <ravigautam@microsoft.com>

* resolve merge conflict for cSpell.json (Azure#30179)

Co-authored-by: Ravi Gautam <ravigautam@microsoft.com>

* reverting cspell.json changes (Azure#30285)

* reverting cspell.json changes

* revert changes2

---------

Co-authored-by: Ravi Gautam <ravigautam@microsoft.com>

* Fix lintdiff enum errpr (Azure#30383)

Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com>

---------

Co-authored-by: Ravi Gautam <ravigautam@microsoft.com>
Co-authored-by: psong-ms <147777703+psong-ms@users.noreply.github.com>
Co-authored-by: UrosKrsticMIPerf <150959695+UrosKrsticMIPerf@users.noreply.github.com>
Co-authored-by: Ivan Arandjelovic <ivan.arandjelovic@gmail.com>
Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com>
Co-authored-by: akromm <87152103+akromm@users.noreply.github.com>
Co-authored-by: Roopesh Manda <rmanda@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyfrosti jeremyfrosti jeremyfrosti approved these changes

@ericshape ericshape Awaiting requested review from ericshape

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ravigautam1896 @jeremyfrosti