Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EG] Resource Notifications required/optional #31334

Merged
merged 4 commits into from
Dec 13, 2024
Merged

[EG] Resource Notifications required/optional #31334

merged 4 commits into from
Dec 13, 2024

Conversation

l0lawrence
Copy link
Member

@l0lawrence l0lawrence commented Oct 30, 2024 •
edited
Loading

ResourceInfo: mandatory
Id, name, type - mandatory
Location, tags, properties: optional
ApiVersion: mandatory
OperationalInfo: mandatory
ResourceEventTime: mandatory

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 30, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named SDK azure-sdk-for-go has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 3 in the PR workflow diagram

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 30, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
.Net Azure.Messaging.EventGrid.SystemEvents https://apiview.dev/Assemblies/Review/3e102a891e5445af8be8cde833dbb702?revisionId=e16a1033781f4fc5a5a496ef241d4c97
TypeSpec Azure.Messaging.EventGrid.SystemEvents https://apiview.dev/Assemblies/Review/bf48b2982ff74cd796f5900a221af2d5?revisionId=9072c1ad1e084983b04e4ebc009db633

@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane TypeSpec Authored with TypeSpec labels Oct 30, 2024
This was referenced Oct 30, 2024
Closed
Closed
@l0lawrence l0lawrence force-pushed the resource_notifications_required branch from a199f33 to af82e3d Compare November 19, 2024 17:59
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.ApiCenter

@azure-sdk azure-sdk mentioned this pull request Nov 19, 2024
Closed
@l0lawrence l0lawrence marked this pull request as ready for review December 10, 2024 22:03
@lmazuel lmazuel added BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior PublishToCustomers Acknowledgement the changes will be published to Azure customers. and removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required labels Dec 13, 2024
@lmazuel lmazuel merged commit 495c999 into Azure:main Dec 13, 2024
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshLove-msft JoshLove-msft JoshLove-msft approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@jsquire jsquire Awaiting requested review from jsquire jsquire is a code owner

Assignees
No one assigned
Labels
BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior data-plane Event Grid PublishToCustomers Acknowledgement the changes will be published to Azure customers. TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@l0lawrence @azure-sdk @JoshLove-msft @lmazuel @AzureRestAPISpecReview