Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useless config #31776

Merged
merged 1 commit into from
Dec 5, 2024
Merged

remove useless config #31776

merged 1 commit into from
Dec 5, 2024

Conversation

tadelesh
Copy link
Member

@tadelesh tadelesh commented Dec 5, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    update tspconfig.yaml for go

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Dec 5, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Dec 5, 2024

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/commonedgesitemanageroperations/armcommonedgesitemanageroperations https://apiview.dev/Assemblies/Review/2ab0fefa2b784af0a4500f886f513585?revisionId=74ad9e2640cc4de78d114f41100c3e15
Go sdk/resourcemanager/computefleet/armcomputefleet https://apiview.dev/Assemblies/Review/d735ff32937b476cb8320846d8f090fb?revisionId=ac0d1039946644a4b5ce512074c9e9fb
Go sdk/resourcemanager/connectedcache/armconnectedcache There is no API change compared with the previous version
Go sdk/resourcemanager/contoso/armcontoso https://apiview.dev/Assemblies/Review/19034274c42f494b900a3f8af06c5461?revisionId=7c3fb115fd9646dea1dba41db3640a9d
Go sdk/resourcemanager/devopsinfrastructure/armdevopsinfrastructure https://apiview.dev/Assemblies/Review/6f45301e365a498191b3b0e8522c7c20?revisionId=2c835fcad9dc4d4e944a1397baa9e867
Go sdk/resourcemanager/durabletask/armdurabletask https://apiview.dev/Assemblies/Review/885ee126e175429ba5db6db1e6f39e4a?revisionId=07fdd75380f248b9a2e34ba4d6584a62
Go sdk/resourcemanager/edgezones/armedgezones There is no API change compared with the previous version
Go sdk/resourcemanager/fabric/armfabric There is no API change compared with the previous version
Go sdk/resourcemanager/healthdataaiservices/armhealthdataaiservices There is no API change compared with the previous version
Go sdk/resourcemanager/hybridconnectivity/armhybridconnectivity https://apiview.dev/Assemblies/Review/467cd7415c594de3b94f4e8e4ff6b1be?revisionId=2529940b039b4832a9a31c0192c824d2
Go sdk/resourcemanager/iotoperations/armiotoperations https://apiview.dev/Assemblies/Review/e7201948d0214fdfa9767bfbe86b0bb9?revisionId=63007104214c44dfb7ef3ec08a1b919d
Go sdk/resourcemanager/mongocluster/armmongocluster https://apiview.dev/Assemblies/Review/b4d2bfc01ecb45d69db8ed292bcdf07d?revisionId=278921910bac4c899e072350094f4323
Go sdk/resourcemanager/neonpostgres/armneonpostgres There is no API change compared with the previous version
Go sdk/resourcemanager/sitemanager/armsitemanager https://apiview.dev/Assemblies/Review/72a9a19f642a4523baaabef4cf6166cc?revisionId=1e95d956d1e84dcc9e67f3d261fe9501
Go sdk/resourcemanager/standbypool/armstandbypool There is no API change compared with the previous version
Go sdk/resourcemanager/terraform/armterraform There is no API change compared with the previous version
Go sdk/resourcemanager/trustedsigning/armtrustedsigning https://apiview.dev/Assemblies/Review/771cca5f112542e6b88cb4a067eed15e?revisionId=fa1088c69a8b499781a5ecc2e32d7700
Go sdk/resourcemanager/workloadssapvirtualinstance/armworkloadssapvirtualinstance https://apiview.dev/Assemblies/Review/4b0b418f02214b1cb1bd4429ea03b3c5?revisionId=a29c070aa02a461785d7c3d7c5009e6d
.Net Azure.ResourceManager.CommonEdgeSiteManagerOperations https://apiview.dev/Assemblies/Review/d0ddeae889ce49e0a057706d7fb7d2ab?revisionId=32edc003fb5c4faf81690e9b27f15a83
.Net Azure.ResourceManager.Contoso https://apiview.dev/Assemblies/Review/7b224f26902a447c92903baab61d49c7?revisionId=58013b7f878f490ca9400a98cbb76960
.Net Azure.ResourceManager.DevOpsInfrastructure There is no API change compared with the previous version
.Net Azure.ResourceManager.DurableTask https://apiview.dev/Assemblies/Review/676804b68e83400cb1470b65e56306c9?revisionId=c8b9e640681b4fb4bba9ed85ce2c164b
.Net Azure.ResourceManager.Fabric There is no API change compared with the previous version
.Net Azure.ResourceManager.MongoCluster https://apiview.dev/Assemblies/Review/069e466f47da47f793462e050d4cf99f?revisionId=a3680a8be501414aa146dacc1f444003
.Net Azure.ResourceManager.NeonPostgres There is no API change compared with the previous version
.Net Azure.ResourceManager.SiteManager https://apiview.dev/Assemblies/Review/4443b818f7fc4e9385b1475b2d87e50b?revisionId=522e616bc2034e3dad0cabec61d1cc07
.Net Azure.ResourceManager.Terraform There is no API change compared with the previous version
Java azure-resourcemanager-commonedgesitemanageroperations https://apiview.dev/Assemblies/Review/45fb7269d2aa4a909b68a9fc4dc2d00c?revisionId=e63e2d894c7344fe900d52b28b270ed4
Java azure-resourcemanager-computefleet There is no API change compared with the previous version
Java azure-resourcemanager-connectedcache There is no API change compared with the previous version
Java azure-resourcemanager-contoso https://apiview.dev/Assemblies/Review/f958535e0c7e4c1e85a46c1363c6e2bb?revisionId=ccf94559efa04fc4a131d56497680de5
Java azure-resourcemanager-devopsinfrastructure There is no API change compared with the previous version
Java azure-resourcemanager-durabletask https://apiview.dev/Assemblies/Review/42d7667bb2f64d29a0be89a6184a6700?revisionId=4b5f9abfb54e44599bab45e416f8e4af
Java azure-resourcemanager-edgezones https://apiview.dev/Assemblies/Review/f6fbc4f31dc6440cae66bb02f57a6c85?revisionId=58d9b5447e3d4a2ba6aff6c89c49fd7a
Java azure-resourcemanager-fabric There is no API change compared with the previous version
Java azure-resourcemanager-healthdataaiservices There is no API change compared with the previous version
Java azure-resourcemanager-iotoperations There is no API change compared with the previous version
Java azure-resourcemanager-mongocluster https://apiview.dev/Assemblies/Review/89671bc422414e0f9adb9c49282e7e7f?revisionId=8d8b6aee7af84f61881c1c921bbbe01d
Java azure-resourcemanager-neonpostgres There is no API change compared with the previous version
Java azure-resourcemanager-sitemanager https://apiview.dev/Assemblies/Review/5e68408b1f514ec0ba387f32eb2857b1?revisionId=081cf8caa19d466a8a84bf693fbeff74
Java azure-resourcemanager-standbypool There is no API change compared with the previous version
Java azure-resourcemanager-terraform There is no API change compared with the previous version
Java azure-resourcemanager-trustedsigning https://apiview.dev/Assemblies/Review/9d10da6041f14593be143ffd3e4a6728?revisionId=c6f4bd899428472caa77cfcc589a36be
Java azure-resourcemanager-workloadssapvirtualinstance https://apiview.dev/Assemblies/Review/37dd904b3d2645f88d4d767d916757c2?revisionId=20559139cb06492ba4c20cd1554e80a7
JavaScript @azure/arm-commonedgesitemanageroperations https://apiview.dev/Assemblies/Review/cb53d59f55844d74a3124e21848a85a7?revisionId=c67858a86a1f40a7802ab4bf7414bf4f
JavaScript @azure/arm-computefleet https://apiview.dev/Assemblies/Review/188df6dd79f149f6b31814188a80ea1e?revisionId=4a42d76c54004171b222e20401ad996f
JavaScript @azure/arm-contoso https://apiview.dev/Assemblies/Review/7667e852608e438dbcca91be6fd43b63?revisionId=62860f5a49504f07a502e3a9ae12c398
JavaScript @azure/arm-devopsinfrastructure https://apiview.dev/Assemblies/Review/16bd85170f8c4709a8821d4b9e0360ab?revisionId=b1004e33a14642ceb20e7e3cd4120f5a
JavaScript @azure/arm-durabletask https://apiview.dev/Assemblies/Review/b3aef685146a4337ac40d4d05e3ef17f?revisionId=82719d8e1479478c88e610f948a56094
JavaScript @azure/arm-edgezones https://apiview.dev/Assemblies/Review/cc23885e5f204fccb0c36eeecf17e45c?revisionId=d36814bde66743049e2b8a16b5a6e0be
JavaScript @azure/arm-fabric https://apiview.dev/Assemblies/Review/f68a76478c9f41bdae55f8e8310aca31?revisionId=87ed34cf94154de187834030368a04d4
JavaScript @azure/arm-healthdataaiservices https://apiview.dev/Assemblies/Review/dd87545fc25c468783d62ae4e998893f?revisionId=916fc93f902e4091bacf4aff02025694
JavaScript @azure/arm-hybridconnectivity https://apiview.dev/Assemblies/Review/244085e470344d229bc90c8196caf8af?revisionId=ac69a29ffb70411785065ec628e41a7f
JavaScript @azure/arm-iotoperations https://apiview.dev/Assemblies/Review/3497f183f9b842898633d9bc7bf2541d?revisionId=77751a897a3b493cbdac7ced499e4715
JavaScript @azure/arm-mongocluster https://apiview.dev/Assemblies/Review/95e9252dfc364a5fab7e6ea4e75639a9?revisionId=92de0d265f58440798aa46847a41840d
JavaScript @azure/arm-sitemanager https://apiview.dev/Assemblies/Review/932a5d7082944042a11a50d2ec27b68d?revisionId=3c5fef3f8bfd4ebe8a4680ddd69bdd0f
JavaScript @azure/arm-standbypool https://apiview.dev/Assemblies/Review/3dc88e5f58304d89b95c951bdf4deac9?revisionId=78cd0b6ddc4d40339db2d4b47305078b
JavaScript @azure/arm-terraform https://apiview.dev/Assemblies/Review/cb15cab5823140eea4aac7c417d8aa46?revisionId=203244cba7294313a79f58c2e87ad391
JavaScript @azure/arm-trustedsigning https://apiview.dev/Assemblies/Review/ff2bfff556b24002a03fd681d94c283c?revisionId=baa55f962ba84c7abd4e6786f04f94d1
JavaScript @azure/arm-workloadssapvirtualinstance https://apiview.dev/Assemblies/Review/7e44ad83bb8b4da8919dfdd64022f85a?revisionId=e27e225013084d12abf6e006deae34ee

@AzureRestAPISpecReview AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label Dec 5, 2024
This was referenced Dec 5, 2024
@tadelesh tadelesh merged commit 7ecaa83 into main Dec 5, 2024
27 of 29 checks passed
@tadelesh tadelesh deleted the update_go_tsp_config branch December 5, 2024 08:01
@wanlwanl
Copy link
Member

wanlwanl commented Dec 6, 2024

python never finish, sdk automation stage get cancelled in about 2 hours. looks like it's timeout.
and only tspconfig files is modified, there's no need to generate for other languages.

danieljurek pushed a commit to danieljurek/azure-rest-api-specs that referenced this pull request Dec 9, 2024
danieljurek pushed a commit to danieljurek/azure-rest-api-specs that referenced this pull request Dec 9, 2024
@maririos
Copy link
Member

@tadelesh thank you so much for this change!

digvijaymali94 pushed a commit to digvijaymali94/azure-rest-api-specs that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants