Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeSpecRequirement] Add upgrade notice to brownfield specs #31814

Merged
merged 74 commits into from
Dec 10, 2024

Conversation

mikeharder
Copy link
Member

@mikeharder mikeharder commented Dec 9, 2024

  • Fixes [Se] Implementation of TypeSpec 'infoblurb' Mechanism in Brownfield PRs #30370
  • add-label-artifact: Composite action to upload an artifact representing an issue label
  • update-labels: Compose action and workflow to add/remove labels based on artifact names
    • Runs in workflow_run context with write permissions
  • context.js: Shared code to extract inputs from different types of github context
  • .github/package.json: Dev dependencies to provide intellisense and formatting when editing github-script
  • typespec-requirement.yaml: Call add-label-artifact to add label "brownfield" (to be used by other automation)
  • TypeSpec-Requirement.ps1: Log notice and set GITHUB_OUTPUT to add label

Verification Runs (could only be performed in fork, since workflow_run only triggers in default branch)

Copy link

openapi-pipeline-app bot commented Dec 9, 2024

Next Steps to Merge

⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛

Copy link

openapi-pipeline-app bot commented Dec 9, 2024

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions but otherwise looks reasonable.

@mikeharder mikeharder merged commit e6bf6e8 into Azure:main Dec 10, 2024
35 of 36 checks passed
@mikeharder mikeharder deleted the brownfield-notice-workflow-run branch January 30, 2025 18:44
grangasamy-msft pushed a commit that referenced this pull request Feb 5, 2025
- add-label-artifact: Composite action to upload an artifact representing an issue label
- update-labels: Compose action and workflow to add/remove labels based on artifact names
  - Runs in `workflow_run` context with write permissions
- context.js: Shared code to extract inputs from different types of github context
- .github/package.json: Dev dependencies to provide intellisense and formatting when editing github-script
- typespec-requirement.yaml: Call add-label-artifact to add label "brownfield" (to be used by other automation)
- TypeSpec-Requirement.ps1: Log notice and set GITHUB_OUTPUT to add label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Se] Implementation of TypeSpec 'infoblurb' Mechanism in Brownfield PRs
2 participants