Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eg sysevents package updates #32368

Merged
merged 6 commits into from
Jan 29, 2025
Merged

Eg sysevents package updates #32368

merged 6 commits into from
Jan 29, 2025
+207 −0

Conversation

billwert
Copy link
Contributor

Adds Java config for Azure.Messaging.SystemEvents

@billwert billwert requested a review from samvaity January 28, 2025 21:03
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 28, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named SDK azure-sdk-for-go has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 3 in the PR workflow diagram

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 28, 2025 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
.Net Azure.Messaging.EventGrid.SystemEvents https://apiview.dev/Assemblies/Review/3e102a891e5445af8be8cde833dbb702?revisionId=3aff5d66d81741b2923a42477508d0dd
Python azure-eventgrid https://apiview.dev/Assemblies/Review/c554ddbabc6e40348998b1656e0ff585?revisionId=9a355c8403b94fbaa0fa94dfd086ec87
TypeSpec Azure.Messaging.EventGrid.SystemEvents Create ApiView failed. To get help, please see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).

@l0lawrence
Copy link
Member

Can you run
npm ci
npx tsv specification/eventgrid/Azure.Messaging.EventGrid.SystemEvents

most likely is complaining about prettier formatting

@AzureRestAPISpecReview AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label Jan 28, 2025
@azure-sdk azure-sdk mentioned this pull request Jan 28, 2025
Closed
@lmazuel lmazuel self-assigned this Jan 28, 2025
@azure-sdk azure-sdk mentioned this pull request Jan 28, 2025
Closed
@billwert billwert force-pushed the eg-sysevents-package-updates branch from 53dfe75 to b59eb8f Compare January 28, 2025 21:16
This was referenced Jan 28, 2025
Closed
Closed
samvaity
samvaity approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@samvaity samvaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@lmazuel lmazuel merged commit 3d89480 into Azure:main Jan 29, 2025
23 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0lawrence l0lawrence l0lawrence approved these changes

@samvaity samvaity samvaity approved these changes

@lmazuel lmazuel lmazuel approved these changes

@jsquire jsquire Awaiting requested review from jsquire jsquire is a code owner

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft JoshLove-msft is a code owner

Assignees

@lmazuel lmazuel

Labels
Event Grid TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@billwert @l0lawrence @lmazuel @samvaity @AzureRestAPISpecReview