Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nivishenker/default disabled #32667

Open
wants to merge 6 commits into
base: kamboj-prjwl/release-network-Microsoft.Network-2024-07-01
Choose a base branch
from
Open

Nivishenker/default disabled #32667

wants to merge 6 commits into from

Conversation

NiviShenker
Copy link
Contributor

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 18, 2025 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 18, 2025 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/network/armnetwork There is no API change compared with the previous version
JavaScript @azure/arm-network https://apiview.dev/Assemblies/Review/c13fd66ecbcc4c2a9995c8a1f4187240?revisionId=417e6963ceff4f7ea57cd54ad246636f

This was referenced Feb 18, 2025
Draft
Draft
@cshahra
Copy link
Contributor

cshahra commented Feb 19, 2025

looks good to me

@NiviShenker NiviShenker marked this pull request as ready for review February 19, 2025 07:40
@azure-sdk azure-sdk mentioned this pull request Feb 19, 2025
Draft
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 19, 2025
This was referenced Feb 19, 2025
Draft
Draft
rkmanda
rkmanda approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@rkmanda rkmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 21, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkmanda rkmanda rkmanda approved these changes

@kamboj-prjwl kamboj-prjwl Awaiting requested review from kamboj-prjwl kamboj-prjwl is a code owner

Assignees
No one assigned
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Network resource-manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NiviShenker @cshahra @rkmanda @AzureRestAPISpecReview