add Azure Monitor Action Group 2018-09-01 API for armrole receiver #3770
Conversation
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-nodeA PR has been created for you: |
Automation for azure-sdk-for-javaA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goA PR has been created for you: |
|
@RyanD1 has this new API version been reviewed by ARM? |
|
@jhendrixMSFT the change for ARM template schema is still under review, will update in this PR once it goes through. |
jhendrixMSFT
added
WaitForARMFeedback
There was a problem hiding this comment.
@RyanD1 - please take a look at these comments. @simongdavies FYI
| "200": { | ||
| "description": "The receiver was successfully enabled." | ||
| }, | ||
| "409": { |
There was a problem hiding this comment.
This should be covered in the default response. So you can remove the 409 response.
| "description": "An action group resource.", | ||
| "allOf": [ | ||
| { | ||
| "$ref": "#/definitions/Resource" |
There was a problem hiding this comment.
This should be referenced from https://github.com/Azure/azure-rest-api-specs/blob/master/specification/common-types/resource-management/v1/types.json
| "maxLength": 12, | ||
| "description": "The short name of the action group. This will be used in SMS messages." | ||
| }, | ||
| "enabled": { |
There was a problem hiding this comment.
bools are typically not recommended. They are less descriptive and dont allow for future expansion of states. Can you make it a string enum?
| "default": true, | ||
| "description": "Indicates whether this action group is enabled. If an action group is not enabled, then none of its receivers will receive communications." | ||
| }, | ||
| "emailReceivers": { |
There was a problem hiding this comment.
Did you consider modeling the receivers as a resource type with a kind property to disambiguate which kind of receiver it is.
There was a problem hiding this comment.
So this would make the api something like this - .../actionGroups/{groupName}/receivers/{receiverName}.
| "type": "string", | ||
| "description": "JSON blob for the configurations of the ITSM action. CreateMultipleWorkItems option will be part of this blob as well." | ||
| }, | ||
| "region": { |
There was a problem hiding this comment.
can we make this an enum?
| "httpTriggerUrl" | ||
| ] | ||
| }, | ||
| "ArmRoleReceiver": { |
There was a problem hiding this comment.
What is an armRolereceiver?
| } | ||
| } | ||
| }, | ||
| "ActionGroupPatchBody": { |
There was a problem hiding this comment.
It would make it easier to update the receivers if Patch supported that. Else, everytime user needs to update some receiver - either add new receivers, or remove a receiver, or update some setting of already added receiver, they will have to re-PUT the entire action group again.
|
@RyanD1 any update on ARM's feedback? |
|
@RyanD1 ping |
|
Closing due to inactivity. Please reopen when ready to engage. |
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger