Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.MachineLearning to add version 2017-01-01 #5241

Merged
merged 6 commits into from
Mar 20, 2019
Merged

[Hub Generated] Review request for Microsoft.MachineLearning to add version 2017-01-01 #5241

merged 6 commits into from
Mar 20, 2019

Conversation

xinzouMicrosoft-zz
Copy link
Contributor

@xinzouMicrosoft-zz xinzouMicrosoft-zz commented Feb 21, 2019 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@AutorestCI
Copy link

AutorestCI commented Feb 21, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Feb 21, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1657

@AutorestCI
Copy link

AutorestCI commented Feb 21, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2253

@AutorestCI
Copy link

AutorestCI commented Feb 21, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Feb 21, 2019 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#4978

@AutorestCI
Copy link

AutorestCI commented Feb 21, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4335

@anuchandy
Copy link
Member

@ravbhatnagar, @xinzouMicrosoft sent suppression approval request, please see email with subject "Violations Suppression requested for PR (Provide PR #)", could you take a look?

@xinzouMicrosoft-zz
Copy link
Contributor Author

xinzouMicrosoft-zz commented Feb 28, 2019 via email

This was referenced Mar 15, 2019
Closed
Merged
Closed
@AutorestCI AutorestCI mentioned this pull request Mar 15, 2019
Merged
adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 15, 2019
@adxsdknet
.NET SDK Resource Provider:'MachineLearning'
72de60d 
REST Spec PR 'Azure/azure-rest-api-specs#5241'
REST Spec PR Author 'xinzouMicrosoft'
REST Spec PR Last commit
@adxsdknet
Copy link

adxsdknet commented Mar 15, 2019 •
edited
Loading

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5467
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@72de60d
adxsdknet/azure-sdk-for-net@353784c

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 15, 2019
@adxsdknet
.NET SDK Resource Provider:'MachineLearning'
353784c 
REST Spec PR 'Azure/azure-rest-api-specs#5241'
REST Spec PR Author 'xinzouMicrosoft'
REST Spec PR Last commit
@sanjaiganesh sanjaiganesh added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 15, 2019
This was referenced Mar 19, 2019
Closed
Closed
anuchandy
anuchandy approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no breaking change in the server side, this PR updates swagger to match with service behavior, the service side logic don’t require the properties originally marked as required in PATCH operation.

@anuchandy anuchandy merged commit a36c4d6 into Azure:master Mar 20, 2019
This was referenced Mar 20, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuchandy anuchandy anuchandy approved these changes

@ravbhatnagar ravbhatnagar Awaiting requested review from ravbhatnagar

@sanjaiganesh sanjaiganesh Awaiting requested review from sanjaiganesh

Assignees

@anuchandy anuchandy

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xinzouMicrosoft-zz @AutorestCI @azuresdkci @anuchandy @adxsdknet @sanjaiganesh @xinzouMicrosoft