[Retargeting to master] Removing x-ms-pageable for Get Server Variables APIs #5439

nirkum18 · 2019-03-20T20:22:57Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-03-20T20:24:51Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmplpmewjpa/rest/specification/network/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmplpmewjpa/sdk', '--use=@microsoft.azure/autorest.python@~3.0.56', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4302/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4302)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (~3.0.56->3.0.58)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2018-12"} .

<--- Last few GCs --->

[21426:0x344de60]    78828 ms: Mark-sweep 1376.9 (1462.4) -> 1376.8 (1462.9) MB, 1710.6 / 0.0 ms  allocation failure GC in old space requested
[21426:0x344de60]    80338 ms: Mark-sweep 1376.8 (1462.9) -> 1376.8 (1422.4) MB, 1509.6 / 0.0 ms  last resort GC in old space requested
[21426:0x344de60]    81529 ms: Mark-sweep 1376.8 (1422.4) -> 1376.8 (1421.9) MB, 1191.4 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x2adf050a5879 <JSObject>
    1: set [native weak-collection.js:~27] [pc=0x3084a889dd49](this=0x83703906b31 <JSWeakMap>,key=0x3feb7bc990e1 <Object map = 0x1049741e82d1>,value=0x2a86d0deb789 <JSProxy>)
    2: /* anonymous */(aka /* anonymous */) [/root/.autorest/@microsoft.azure_autorest-core@2.0.4302/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~104] [pc=0x3084a889666d](this=0x3944ffd022d1 <undefined>...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8c21ec [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
 6: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::NewInternal(v8::internal::Isolate*, int, v8::internal::PretenureFlag) [node]
 7: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::New(v8::internal::Isolate*, int, v8::internal::PretenureFlag, v8::internal::MinimumCapacity) [node]
 8: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::EnsureCapacity(v8::internal::Handle<v8::internal::ObjectHashTable>, int, v8::internal::PretenureFlag) [node]
 9: v8::internal::ObjectHashTable::Put(v8::internal::Handle<v8::internal::ObjectHashTable>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
10: v8::internal::JSWeakCollection::Set(v8::internal::Handle<v8::internal::JSWeakCollection>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
11: v8::internal::Runtime_WeakCollectionSet(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x3084a85842fd

AutorestCI · 2019-03-20T20:25:12Z

Automation for azure-sdk-for-js

Encountered a Subprocess error: (azure-sdk-for-js)

Command: ['/usr/local/bin/autorest', '/tmp/tmpsgpy963s/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--typescript', '--typescript-sdks-folder=/tmp/tmpsgpy963s/azure-sdk-for-js', '--use=@microsoft.azure/autorest.typescript@2.1.1']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4299/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4299)
   Loading AutoRest extension '@microsoft.azure/autorest.typescript' (2.1.1->2.1.1)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.51->2.3.51)

<--- Last few GCs --->

[8645:0x2925860]   108011 ms: Mark-sweep 1400.0 (1477.9) -> 1400.0 (1477.9) MB, 1706.4 / 0.0 ms  allocation failure GC in old space requested
[8645:0x2925860]   109684 ms: Mark-sweep 1400.0 (1477.9) -> 1399.9 (1443.9) MB, 1672.7 / 0.0 ms  last resort GC in old space requested
[8645:0x2925860]   111336 ms: Mark-sweep 1399.9 (1443.9) -> 1399.9 (1443.9) MB, 1651.1 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x65a2c025879 <JSObject>
    1: add [native weak-collection.js:~64] [pc=0x1f130b163b49](this=0x16910e96a9f9 <JSWeakSet>,j=0x25bfdb9f0239 <JSProxy>)
    2: losslessJsonSerializable(aka losslessJsonSerializable) [/root/.autorest/@microsoft.azure_autorest-core@2.0.4299/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~232] [pc=0x1f130b4480fb](this=0x3819e90022d1 <undefined>,o=0x25bfdb9f0239 <JSProxy>)
    3:...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8cbf4c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
 6: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::NewInternal(v8::internal::Isolate*, int, v8::internal::PretenureFlag) [node]
 7: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::New(v8::internal::Isolate*, int, v8::internal::PretenureFlag, v8::internal::MinimumCapacity) [node]
 8: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::EnsureCapacity(v8::internal::Handle<v8::internal::ObjectHashTable>, int, v8::internal::PretenureFlag) [node]
 9: v8::internal::ObjectHashTable::Put(v8::internal::Handle<v8::internal::ObjectHashTable>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
10: v8::internal::JSWeakCollection::Set(v8::internal::Handle<v8::internal::JSWeakCollection>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
11: v8::internal::Runtime_WeakCollectionSet(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x1f130b0042fd

azuresdkci · 2019-03-20T20:25:28Z

Can one of the admins verify this patch?

AutorestCI · 2019-03-20T20:26:09Z

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmp8shfth4i/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmp8shfth4i/azure-sdk-for-node', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@2.2.131']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4289/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4289)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (2.2.131->2.2.131)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)

<--- Last few GCs --->

[30314:0x27c3860]    88876 ms: Mark-sweep 1373.9 (1461.4) -> 1373.8 (1463.9) MB, 2219.6 / 0.0 ms  allocation failure GC in old space requested
[30314:0x27c3860]    90862 ms: Mark-sweep 1373.8 (1463.9) -> 1373.8 (1426.9) MB, 1985.9 / 0.0 ms  last resort GC in old space requested
[30314:0x27c3860]    92780 ms: Mark-sweep 1373.8 (1426.9) -> 1373.8 (1421.9) MB, 1917.2 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0xffbb5aa5879 <JSObject>
    1: set [native weak-collection.js:~27] [pc=0x3d73769f6f69](this=0x3dcc15d3f811 <JSWeakMap>,key=0x3e3efed39729 <Object map = 0x20e3736d8369>,value=0x2a660a2cee41 <JSProxy>)
    2: /* anonymous */(aka /* anonymous */) [/root/.autorest/@microsoft.azure_autorest-core@2.0.4289/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~104] [pc=0x3d7376c2532d](this=0x196244d022d1 <undefined>...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8cbf4c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
 6: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::NewInternal(v8::internal::Isolate*, int, v8::internal::PretenureFlag) [node]
 7: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::New(v8::internal::Isolate*, int, v8::internal::PretenureFlag, v8::internal::MinimumCapacity) [node]
 8: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::EnsureCapacity(v8::internal::Handle<v8::internal::ObjectHashTable>, int, v8::internal::PretenureFlag) [node]
 9: v8::internal::ObjectHashTable::Put(v8::internal::Handle<v8::internal::ObjectHashTable>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
10: v8::internal::JSWeakCollection::Set(v8::internal::Handle<v8::internal::JSWeakCollection>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
11: v8::internal::Runtime_WeakCollectionSet(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x3d73768042fd

dsgouda · 2019-03-20T20:27:39Z

@sergey-shandar please disregard the net sdk automation failure here

AutorestCI · 2019-03-20T20:31:01Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2125

adxsdknet · 2019-03-20T20:40:08Z

Automation for azure-sdk-for-net

A PR has been created for you:
https://github.com/azure/azure-sdk-for-net/pull/-1
.NET SDK Commits:
https://github.com/adxsdknet/azure-sdk-for-net/pull/-1/commits/

AutorestCI · 2019-03-20T20:50:15Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI · 2019-03-20T21:40:56Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3043

jhendrixMSFT · 2019-03-22T16:27:44Z

@AutorestCI regenerate azure-sdk-for-go

removing x-ms-pageable

c1e0278

nirkum18 requested a review from MikhailTryakhov as a code owner March 20, 2019 20:22

azuresdkci assigned sergey-shandar Mar 20, 2019

azuresdkci requested a review from sergey-shandar March 20, 2019 20:23

dsgouda mentioned this pull request Mar 20, 2019

Removing x-ms-pageable for Get Server Variables APIs #5433

Closed

5 tasks

AutorestCI mentioned this pull request Mar 20, 2019

[AutoPR network/resource-manager] [Retargeting to master] Removing x-ms-pageable for Get Server Variables APIs Azure/azure-sdk-for-ruby#2350

Merged

AutorestCI mentioned this pull request Mar 20, 2019

[AutoPR network/resource-manager] [Retargeting to master] Removing x-ms-pageable for Get Server Variables APIs Azure/azure-sdk-for-java#3160

Merged

lmazuel approved these changes Mar 21, 2019

View reviewed changes

lmazuel merged commit 13937ec into Azure:master Mar 21, 2019

anton-evseev mentioned this pull request Mar 25, 2019

Cherry pick: Remove x-ms-pageable from Get Server Variables APIs #5463

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Retargeting to master] Removing x-ms-pageable for Get Server Variables APIs #5439

[Retargeting to master] Removing x-ms-pageable for Get Server Variables APIs #5439

nirkum18 commented Mar 20, 2019 •

edited

Loading

AutorestCI commented Mar 20, 2019 •

edited

Loading

AutorestCI commented Mar 20, 2019 •

edited

Loading

azuresdkci commented Mar 20, 2019

AutorestCI commented Mar 20, 2019 •

edited

Loading

dsgouda commented Mar 20, 2019

AutorestCI commented Mar 20, 2019 •

edited

Loading

adxsdknet commented Mar 20, 2019

AutorestCI commented Mar 20, 2019 •

edited

Loading

AutorestCI commented Mar 20, 2019 •

edited

Loading

jhendrixMSFT commented Mar 22, 2019

[Retargeting to master] Removing x-ms-pageable for Get Server Variables APIs #5439

[Retargeting to master] Removing x-ms-pageable for Get Server Variables APIs #5439

Conversation

nirkum18 commented Mar 20, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Mar 20, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Mar 20, 2019 • edited Loading

Automation for azure-sdk-for-js

azuresdkci commented Mar 20, 2019

AutorestCI commented Mar 20, 2019 • edited Loading

Automation for azure-sdk-for-node

dsgouda commented Mar 20, 2019

AutorestCI commented Mar 20, 2019 • edited Loading

Automation for azure-sdk-for-ruby

adxsdknet commented Mar 20, 2019

Automation for azure-sdk-for-net

AutorestCI commented Mar 20, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Mar 20, 2019 • edited Loading

Automation for azure-sdk-for-java

jhendrixMSFT commented Mar 22, 2019

nirkum18 commented Mar 20, 2019 •

edited

Loading

AutorestCI commented Mar 20, 2019 •

edited

Loading

AutorestCI commented Mar 20, 2019 •

edited

Loading

AutorestCI commented Mar 20, 2019 •

edited

Loading

AutorestCI commented Mar 20, 2019 •

edited

Loading

AutorestCI commented Mar 20, 2019 •

edited

Loading

AutorestCI commented Mar 20, 2019 •

edited

Loading