[Hub Generated][Do not Merge] Review request for Microsoft.PolicyInsights to add version preview/2017-08-09-preview #5651

najagasi · 2019-04-15T21:05:11Z

If you are a MSFT employee you can view your work branch via this link.

Do not merge

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

azuresdkci · 2019-04-15T21:05:28Z

Can one of the admins verify this patch?

AutorestCI · 2019-04-15T21:05:54Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout b5f907852b51acfdad7d95ab9f87d5152eeece57
  stderr: 'fatal: reference is not a tree: b5f907852b51acfdad7d95ab9f87d5152eeece57'

AutorestCI · 2019-04-15T21:06:04Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout b5f907852b51acfdad7d95ab9f87d5152eeece57
  stderr: 'fatal: reference is not a tree: b5f907852b51acfdad7d95ab9f87d5152eeece57'

AutorestCI · 2019-04-15T21:06:29Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout b5f907852b51acfdad7d95ab9f87d5152eeece57
  stderr: 'fatal: reference is not a tree: b5f907852b51acfdad7d95ab9f87d5152eeece57'

AutorestCI · 2019-04-15T21:07:56Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout b5f907852b51acfdad7d95ab9f87d5152eeece57
  stderr: 'fatal: reference is not a tree: b5f907852b51acfdad7d95ab9f87d5152eeece57'

AutorestCI · 2019-04-15T21:09:29Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout b5f907852b51acfdad7d95ab9f87d5152eeece57
  stderr: 'fatal: reference is not a tree: b5f907852b51acfdad7d95ab9f87d5152eeece57'

REST Spec PR 'Azure/azure-rest-api-specs#5651' REST Spec PR Author 'najagasi' REST Spec PR Last commit

adxsdknet · 2019-04-15T21:12:46Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5810
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@dcda66f
adxsdknet/azure-sdk-for-net@954c4f4

kpajdzik · 2019-04-22T16:11:10Z

...ights/resource-manager/Microsoft.PolicyInsights/preview/2018-07-01-preview/policyEvents.json

+          "type": "string"
+        },
+        "policyDefinitionAction": {
+          "description": "Policy definition action, i.e. effect.",


Can this be enum constrained?

kpajdzik · 2019-04-22T16:11:27Z

...ights/resource-manager/Microsoft.PolicyInsights/preview/2018-07-01-preview/policyEvents.json

+          "type": "string"
+        },
+        "policyDefinitionCategory": {
+          "description": "Policy definition category.",


Same here - can this be enum constrained?

kpajdzik · 2019-04-22T16:19:36Z

LGTM. Waiting for ARM review.

kpajdzik · 2019-04-24T01:26:53Z

@najagasi, could you rebase this pull request? The diff makes it really hard to review.

kpajdzik · 2019-04-30T19:28:51Z

@najagasi, any updates here?

…vide nextLink

REST Spec PR 'Azure/azure-rest-api-specs#5651' REST Spec PR Author 'najagasi' REST Spec PR Last commit

kpajdzik · 2019-05-01T04:19:13Z

...ights/resource-manager/Microsoft.PolicyInsights/preview/2018-07-01-preview/policyEvents.json

+          "nextLinkName": "@odata.nextLink"
+        },
+        "x-ms-examples": {
+          "Query at resource scope": { "$ref": "./examples/PolicyEvents_QueryResourceScope.json" },


Nit - I think that would look better formatted like other objects.

najagasi · 2019-05-07T17:01:32Z

I am waiting for some other code fixes before I can request for merging the PR.
I will open the PR again when those changes are in.

ravbhatnagar · 2019-05-15T17:54:29Z

Only change seems to be adding the pagination in both policyStates and policyEvents. Signing off from ARM side.

kpajdzik · 2019-05-20T22:11:40Z

I am waiting for some other code fixes before I can request for merging the PR.
I will open the PR again when those changes are in.

Is it still not ready to be merged?

kpajdzik · 2019-05-28T22:08:53Z

I am waiting for some other code fixes before I can request for merging the PR.
I will open the PR again when those changes are in.

@najagasi, Can this be merged?

kpajdzik · 2019-05-31T15:56:18Z

@najagasi, ping

kpajdzik · 2019-06-03T16:06:06Z

Lack of activity. Please reopen when ready to merge.

azuresdkci assigned kpajdzik Apr 15, 2019

azuresdkci requested a review from kpajdzik April 15, 2019 21:05

najagasi changed the title ~~[Hub Generated] Review request for Microsoft.PolicyInsights to add version preview/2017-08-09-preview~~ [Hub Generated][Do not Merge] Review request for Microsoft.PolicyInsights to add version preview/2017-08-09-preview Apr 15, 2019

AutorestCI mentioned this pull request Apr 15, 2019

[AutoPR policyinsights/resource-manager] [Hub Generated] Review request for Microsoft.PolicyInsights to add version preview/2017-08-09-preview Azure/azure-sdk-for-python#4854

Closed

AutorestCI mentioned this pull request Apr 15, 2019

[AutoPR policyinsights/resource-manager] [Hub Generated] Review request for Microsoft.PolicyInsights to add version preview/2017-08-09-preview Azure/azure-sdk-for-js#2254

Closed

AutorestCI mentioned this pull request Apr 15, 2019

[AutoPR policyinsights/resource-manager] [Hub Generated] Review request for Microsoft.PolicyInsights to add version preview/2017-08-09-preview Azure/azure-sdk-for-go#4547

Closed

AutorestCI mentioned this pull request Apr 15, 2019

[AutoPR policyinsights/resource-manager] [Hub Generated] Review request for Microsoft.PolicyInsights to add version preview/2017-08-09-preview Azure/azure-sdk-for-java#3378

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 15, 2019

.NET SDK Resource Provider:'PolicyInsights'

dcda66f

REST Spec PR 'Azure/azure-rest-api-specs#5651' REST Spec PR Author 'najagasi' REST Spec PR Last commit

kpajdzik added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 22, 2019

kpajdzik reviewed Apr 22, 2019

View reviewed changes

najagasi requested review from amarzavery, ankushbindlish2, BrianBlum, DavidLiCIG, lmazuel, MikhailTryakhov, naveedaz, solankisamir, wilcobmsft, yangyuan and yugangw-msft as code owners April 24, 2019 00:17

Namrata Jagasia added 6 commits April 30, 2019 16:51

PolicyInsights PolicyStates, PolicyEvents version 2018-07-01-Prev pro…

fa804ff

…vide nextLink

fix version in policyEvents

68bd95a

add examples

23e14bb

fix typo

7d436c2

fix case

a24b465

update apiVersionParameter description

b1808c5

najagasi force-pushed the dev-policyinsights-Microsoft.PolicyInsights-2017-08-09-preview branch from fb37ec0 to b1808c5 Compare April 30, 2019 23:55

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 1, 2019

.NET SDK Resource Provider:'PolicyInsights'

954c4f4

REST Spec PR 'Azure/azure-rest-api-specs#5651' REST Spec PR Author 'najagasi' REST Spec PR Last commit

kpajdzik reviewed May 1, 2019

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 15, 2019

kpajdzik approved these changes May 15, 2019

View reviewed changes

kpajdzik closed this May 20, 2019

kpajdzik reopened this May 20, 2019

AutorestCI mentioned this pull request May 20, 2019

[AutoPR policyinsights/resource-manager] [Hub Generated][Do not Merge] Review request for Microsoft.PolicyInsights to add version preview/2017-08-09-preview Azure/azure-sdk-for-js#3011

Closed

kpajdzik closed this Jun 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated][Do not Merge] Review request for Microsoft.PolicyInsights to add version preview/2017-08-09-preview #5651

[Hub Generated][Do not Merge] Review request for Microsoft.PolicyInsights to add version preview/2017-08-09-preview #5651

najagasi commented Apr 15, 2019 •

edited

Loading

azuresdkci commented Apr 15, 2019

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

adxsdknet commented Apr 15, 2019 •

edited

Loading

kpajdzik Apr 22, 2019

kpajdzik Apr 22, 2019

kpajdzik commented Apr 22, 2019

kpajdzik commented Apr 24, 2019

kpajdzik commented Apr 30, 2019

kpajdzik May 1, 2019

najagasi commented May 7, 2019 •

edited

Loading

ravbhatnagar commented May 15, 2019

kpajdzik commented May 20, 2019

kpajdzik commented May 28, 2019

kpajdzik commented May 31, 2019

kpajdzik commented Jun 3, 2019

[Hub Generated][Do not Merge] Review request for Microsoft.PolicyInsights to add version preview/2017-08-09-preview #5651

[Hub Generated][Do not Merge] Review request for Microsoft.PolicyInsights to add version preview/2017-08-09-preview #5651

Conversation

najagasi commented Apr 15, 2019 • edited Loading

Contribution checklist:

azuresdkci commented Apr 15, 2019

AutorestCI commented Apr 15, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Apr 15, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Apr 15, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Apr 15, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Apr 15, 2019 • edited Loading

Automation for azure-sdk-for-java

adxsdknet commented Apr 15, 2019 • edited Loading

Automation for azure-sdk-for-net

kpajdzik Apr 22, 2019

Choose a reason for hiding this comment

kpajdzik Apr 22, 2019

Choose a reason for hiding this comment

kpajdzik commented Apr 22, 2019

kpajdzik commented Apr 24, 2019

kpajdzik commented Apr 30, 2019

kpajdzik May 1, 2019

Choose a reason for hiding this comment

najagasi commented May 7, 2019 • edited Loading

ravbhatnagar commented May 15, 2019

kpajdzik commented May 20, 2019

kpajdzik commented May 28, 2019

kpajdzik commented May 31, 2019

kpajdzik commented Jun 3, 2019

najagasi commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

adxsdknet commented Apr 15, 2019 •

edited

Loading

najagasi commented May 7, 2019 •

edited

Loading