-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Microsoft.Advisor] Add metadata api #5826
Conversation
Can one of the admins verify this patch? |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-jsThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit
Automation for azure-sdk-for-netA PR has been created for you: |
REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit
REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit
REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit
Can some one provide pointer on how to fix SDK node failure. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/Azure/azure-rest-api-specs/pull/5826/files#diff-d0283661446defbd1a9caf436b028f0cR787
Have you considered having common error response align with what is documented on ARM guidelines
https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content
specification/advisor/resource-manager/Microsoft.Advisor/stable/2017-04-19/advisor.json
Outdated
Show resolved
Hide resolved
specification/advisor/resource-manager/Microsoft.Advisor/stable/2017-04-19/advisor.json
Outdated
Show resolved
Hide resolved
@amarzavery is the Node failure of any concern here. Can you take look and confirm if this failure can be/cannot be ignored |
Please ignore the nodejs failure and move ahead. |
@mudit794 I have not heard back from you regarding aligning to common schema for error response. |
REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit
@shahabhijeet Addressed feedback as per our offline conversation to revert current api error response and add feedback.md for future reference. |
REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit
Node sdk is a know issue and we have travis wide issue. So this PR is ok to be merged. |
* .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit * .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit * .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit * .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit * .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit * .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit
* .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit * .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit * .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit * .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit * .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit * .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.