Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Microsoft.Advisor] Add metadata api #5826

Merged
merged 28 commits into from
May 7, 2019
Merged

[Microsoft.Advisor] Add metadata api #5826

merged 28 commits into from
May 7, 2019

Conversation

mudit794
Copy link
Contributor

@mudit794 mudit794 commented May 1, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented May 1, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2453

This was referenced May 1, 2019
Merged
Merged
@AutorestCI
Copy link

AutorestCI commented May 1, 2019 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#2631

@AutorestCI
Copy link

AutorestCI commented May 1, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5133

@mudit794 mudit794 changed the title Add metadata api [Microsoft.Advisor] Add metadata api May 1, 2019
@AutorestCI AutorestCI mentioned this pull request May 1, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented May 1, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4756

@AutorestCI AutorestCI mentioned this pull request May 1, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented May 1, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3585

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 1, 2019
@adxsdknet
.NET SDK Resource Provider:'Advisor'
2872837 
REST Spec PR 'Azure/azure-rest-api-specs#5826'
REST Spec PR Author 'mudit794'
REST Spec PR Last commit
@adxsdknet
Copy link

adxsdknet commented May 1, 2019 •
edited
Loading

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6029
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@2872837
adxsdknet/azure-sdk-for-net@d2afbfc
adxsdknet/azure-sdk-for-net@251241b
adxsdknet/azure-sdk-for-net@8744968
adxsdknet/azure-sdk-for-net@e1a5d94
adxsdknet/azure-sdk-for-net@f11f2a2

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 2, 2019
@adxsdknet
.NET SDK Resource Provider:'Advisor'
d2afbfc 
REST Spec PR 'Azure/azure-rest-api-specs#5826'
REST Spec PR Author 'mudit794'
REST Spec PR Last commit
adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 2, 2019
@adxsdknet
.NET SDK Resource Provider:'Advisor'
251241b 
REST Spec PR 'Azure/azure-rest-api-specs#5826'
REST Spec PR Author 'mudit794'
REST Spec PR Last commit
@anthony-c-martin anthony-c-martin added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 2, 2019
adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 2, 2019
@adxsdknet
.NET SDK Resource Provider:'Advisor'
8744968 
REST Spec PR 'Azure/azure-rest-api-specs#5826'
REST Spec PR Author 'mudit794'
REST Spec PR Last commit
@mudit794
Copy link
Contributor Author

mudit794 commented May 2, 2019

Can some one provide pointer on how to fix SDK node failure. Thanks

@AutorestCI AutorestCI mentioned this pull request May 3, 2019
Merged
@anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 3, 2019
shahabhijeet
shahabhijeet requested changes May 4, 2019
View reviewed changes
Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Azure/azure-rest-api-specs/pull/5826/files#diff-d0283661446defbd1a9caf436b028f0cR787
Have you considered having common error response align with what is documented on ARM guidelines
https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content

specification/advisor/resource-manager/Microsoft.Advisor/stable/2017-04-19/advisor.json Outdated Show resolved Hide resolved
specification/advisor/resource-manager/Microsoft.Advisor/stable/2017-04-19/advisor.json Outdated Show resolved Hide resolved
@shahabhijeet
Copy link
Member

@amarzavery is the Node failure of any concern here. Can you take look and confirm if this failure can be/cannot be ignored
https://dev.azure.com/azure-sdk/public/_build/results?buildId=26159

@amarzavery
Copy link
Contributor

Please ignore the nodejs failure and move ahead.

@shahabhijeet
Copy link
Member

@mudit794 I have not heard back from you regarding aligning to common schema for error response.

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 6, 2019
@adxsdknet
.NET SDK Resource Provider:'Advisor'
e1a5d94 
REST Spec PR 'Azure/azure-rest-api-specs#5826'
REST Spec PR Author 'mudit794'
REST Spec PR Last commit
@mudit794
Copy link
Contributor Author

mudit794 commented May 6, 2019 •
edited
Loading

@mudit794 I have not heard back from you regarding aligning to common schema for error response.

@mudit794 I have not heard back from you regarding aligning to common schema for error response.

@shahabhijeet Addressed feedback as per our offline conversation to revert current api error response and add feedback.md for future reference.

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 7, 2019
@adxsdknet
.NET SDK Resource Provider:'Advisor'
f11f2a2 
REST Spec PR 'Azure/azure-rest-api-specs#5826'
REST Spec PR Author 'mudit794'
REST Spec PR Last commit
@shahabhijeet shahabhijeet merged commit 0685351 into Azure:master May 7, 2019
@shahabhijeet
Copy link
Member

Node sdk is a know issue and we have travis wide issue. So this PR is ok to be merged.

dsgouda pushed a commit to Azure/azure-sdk-for-net that referenced this pull request May 9, 2019
@adxsdknet @dsgouda
AutoPr-Advisor-mudit794-REST Spec PrNumber 5826 (#6029)
c79e4e1 
* .NET SDK Resource Provider:'Advisor'
REST Spec PR 'Azure/azure-rest-api-specs#5826'
REST Spec PR Author 'mudit794'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Advisor'
REST Spec PR 'Azure/azure-rest-api-specs#5826'
REST Spec PR Author 'mudit794'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Advisor'
REST Spec PR 'Azure/azure-rest-api-specs#5826'
REST Spec PR Author 'mudit794'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Advisor'
REST Spec PR 'Azure/azure-rest-api-specs#5826'
REST Spec PR Author 'mudit794'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Advisor'
REST Spec PR 'Azure/azure-rest-api-specs#5826'
REST Spec PR Author 'mudit794'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Advisor'
REST Spec PR 'Azure/azure-rest-api-specs#5826'
REST Spec PR Author 'mudit794'
REST Spec PR Last commit
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@adxsdknet @mentat9
AutoPr-Advisor-mudit794-REST Spec PrNumber 5826 (Azure#6029)
577942e 
* .NET SDK Resource Provider:'Advisor'
REST Spec PR 'Azure/azure-rest-api-specs#5826'
REST Spec PR Author 'mudit794'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Advisor'
REST Spec PR 'Azure/azure-rest-api-specs#5826'
REST Spec PR Author 'mudit794'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Advisor'
REST Spec PR 'Azure/azure-rest-api-specs#5826'
REST Spec PR Author 'mudit794'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Advisor'
REST Spec PR 'Azure/azure-rest-api-specs#5826'
REST Spec PR Author 'mudit794'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Advisor'
REST Spec PR 'Azure/azure-rest-api-specs#5826'
REST Spec PR Author 'mudit794'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Advisor'
REST Spec PR 'Azure/azure-rest-api-specs#5826'
REST Spec PR Author 'mudit794'
REST Spec PR Last commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Assignees

@shahabhijeet shahabhijeet

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mudit794 @azuresdkci @AutorestCI @adxsdknet @shahabhijeet @amarzavery @anthony-c-martin