Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed eventhub namespace to eventhubs #6446

Merged
merged 1 commit into from
Jul 1, 2019
Merged

changed eventhub namespace to eventhubs #6446

merged 1 commit into from
Jul 1, 2019

Conversation

iscai-msft
Copy link
Contributor

No description provided.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 25, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 0ecb897)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 25, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Jun 25, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 25, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Jun 25, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 25, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3049

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@amarzavery
Copy link
Contributor

@iscai-msft Should the same pattern be followed for other languages? Should the existing packages be deprecated in the favor of new ones?

/cc (individual language sdk owners) @shahabhijeet @lmazuel @anuchandy @sarangan12 @jhendrixMSFT

@jhendrixMSFT
Copy link
Member

It's a breaking change. What's the motivation for this, is it a branding/marketing thing?

@lmazuel
Copy link
Member

lmazuel commented Jul 1, 2019

@jhendrixMSFT @amarzavery merging the PR, did an email right now for the rationale. Thanks!

@lmazuel lmazuel merged commit decff9b into Azure:master Jul 1, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@iscai-msft @celikcigdem
changed eventhub namespace to eventhubs (Azure#6446)
11b8fce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praries880 praries880 Awaiting requested review from praries880

@v-Ajnava v-Ajnava Awaiting requested review from v-Ajnava v-Ajnava is a code owner

@amarzavery amarzavery Awaiting requested review from amarzavery

Assignees

@amarzavery amarzavery

Labels
potential-sdk-breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iscai-msft @AutorestCI @azuresdkci @amarzavery @jhendrixMSFT @lmazuel