-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Microsoft.ApiManagement][2019-12-01] Gateway hostname configuration protocol settings #8938
Conversation
Azure Pipelines successfully started running 1 pipeline(s). |
Can one of the admins verify this patch? |
azure-sdk-for-go
|
azure-cli-extensions
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net
|
azure-sdk-for-js
|
azure-sdk-for-java
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see one comment
@@ -5525,6 +5525,18 @@ | |||
"negotiateClientCertificate": { | |||
"type": "boolean", | |||
"description": "Determines whether gateway requests client certificate" | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding these within an API version can cause undesired effects as customers use mixed SDK versions where only latest can deserialize these properties. Additionally, Azure Policy becomes unpredictable if properties customers use in policy evaluations are added within an API version. Can they be added in a new version?
@solankisamir - please let us know if this PR is still relevant and re-add the ARM review label. removing from now due to no activity for several months. |
6af3972
to
aa9c384
Compare
@ravbhatnagar we have put the changes into new PR #10292 |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.