-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure az_json_writer_append_json_text appends a comma between elements of an array. #1600
Conversation
elements of an array.
cc @kevinior |
@@ -1,7 +1,10 @@ | |||
# Release History | |||
|
|||
## 1.1.0-beta.2 (Unreleased) | |||
## 1.1.0-beta.4 (Unreleased) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was updated to be one higher than the version in the iot_pnp branch which is where earlier betas were shipped out of.
https://github.com/Azure/azure-sdk-for-c/blob/93fb3362a37753c67aca4b52b852441e097f4dbf/CHANGELOG.md#110-beta4-unreleased
FYI @danewalton, when you do your next sync.
@sima-zhu can you please help me understand where this broken link issue is coming from as part of the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean we would want to release next March to publish this bug fix?
I think so. But I will leave it up to Rick to decide, especially if we take it as a hot-fix for 1.0.1. |
cc: @ewertons the link failure you had is showing up in master. What was the fix you applied in your PR? |
@sima-zhu, @weshaggard - why is the generate release artifact passing here. Shouldn't the link verification step catch the same issue. I don't understand the fickleness https://dev.azure.com/azure-sdk/public/_build/results?buildId=733883&view=logs&j=a129effc-2dd1-54d1-fb5a-ad7bdc0e851d&t=ccad100f-2904-5913-2083-c525ad929a03 |
…o FixAppendText
OK, I think it was because the parent of my branch was several months old. Hopefully the merge from master will fix the issue:
|
Alright, syncing with master resolved the issue. My branch was just out-of-sync, and there is no link verification issue. |
Fixes #1574