Fix BOM artifact upload failure on failed cmake #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed, it'll always be generated and uploaded
scbedd
requested review from
benbp,
danieljurek and
weshaggard
as code owners
scbedd
added
the
Central-EngSys
weshaggard
approved these changes
Jan 18, 2022
RickWinter
approved these changes
Jan 18, 2022
vhvb1989
approved these changes
Jan 18, 2022
This was referenced Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example Build Failure
Step progression:
The issue here is that there is no condition on
generate bom. Given that thepublish-artifacttemplate always uploads an artifact (even in failure state), we need to ensure that the artifact upload path isn't actually empty.Simplest way to do that is to adjust
generate bomto always run, rather than getting into the weeds with additional conditions within thepublish-artifacttemplate.