Curl keep alive #5930
Curl keep alive #5930
Conversation
gearama
requested review from
RickWinter,
ahsonkhan and
antkmsft
as code owners
|
Does this fix address issue 5877 |
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
|
I have a few comments, but my biggest concern is that we don't have any tests which validate this code against an actual server which returns keep-alive responses, thus there may be assumptions being made in this implementation which are not supported in actual practice. Do we know if storage or other servers we use returns keep-alive headers which we could use to help test? |
since i agree with this statement, i don't think we should merge this change, even if on surface it might look ok, i'd rather not merge it since we cannot get real life validation of the approach. as such i'll leave it there if someone else wants to take a stab. Also since my vacation is coming up i don't want to merge something of this impact and then vanish for a few weeks. |
| return response; | ||
| } | ||
|
|
||
| // Check if the server supports keep alive and if the headers are consistent between the request and | ||
| // the response. If they are not consistent, the keep alive header in the request is removed.and the |
There was a problem hiding this comment.
| // the response. If they are not consistent, the keep alive header in the request is removed.and the | |
| // the response. If they are not consistent, the keep alive header in the request is removed and the |
| // just in case the server sends the headers in a different case, the case sensitivity of the | ||
| // map is guaranteed for keys not values. So we need to ensure we compare the values in a case | ||
| // insensitive way. |
There was a problem hiding this comment.
Nit,
| // just in case the server sends the headers in a different case, the case sensitivity of the | |
| // map is guaranteed for keys not values. So we need to ensure we compare the values in a case | |
| // insensitive way. | |
| // Case sensitivity only applies to the `Key` in the map. Thus. compare `Value` in a case insensitive manor. |
| { | ||
| // Can't re-used a shut down connection | ||
| // Can't re-used a shut down connection or an expired connection |
There was a problem hiding this comment.
| // Can't re-used a shut down connection or an expired connection | |
| // Can't re-use a shutdown connection or an expired connection |
closes #5877
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.