[apiview] adding pr support

.vscode/cspell.json

@@ -74,6 +74,7 @@
     "avro",
     "antkmsft",
     "azcmagent",
+    "azcopy",
     "azcore",
     "azsdk",
     "azsdkengsys",

eng/pipelines/templates/jobs/archetype-sdk-client.yml

@@ -100,46 +100,20 @@ jobs:
 
         - template: /eng/common/pipelines/templates/steps/set-default-branch.yml
 
-        - task:  UniversalPackages@0
+        - pwsh: azcopy copy "https://azuresdkartifacts.blob.core.windows.net/azure-sdk-for-cpp/parseazuresdkcpp/*" "$(System.DefaultWorkingDirectory)/parser" --recursive
           displayName: Download ApiView Parser.
-          inputs:
-            command: download
-            vstsFeed: 'internal/AzureSDKForCpp'
-            vstsFeedPackage: 'parseazuresdkcpp'
-            downloadDirectory: '$(System.DefaultWorkingDirectory)/parser'
-            vstsPackageVersion: 0.14.0 
-          condition: >-
-              and(
-                succeeded(),
-                ne(variables['Skip.CreateApiReview'], 'true'),
-                ne(variables['Build.Reason'],'PullRequest'),
-                eq(variables['System.TeamProject'], 'internal')
-              )
 
         - task: Powershell@2
           inputs:
-            filePath: $(System.DefaultWorkingDirectory)/eng/scripts/Create-APIReview.ps1
+            filePath: $(System.DefaultWorkingDirectory)/eng/scripts/Generate-APIReview-Token-Files.ps1
             arguments: >
               -ArtifactList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json | Select-Object Name)
               -OutPath $(Build.ArtifactStagingDirectory)
-              -ApiKey "$(azuresdk-apiview-apikey)"
-              -SourceBranch $(Build.SourceBranchName)
-              -DefaultBranch $(DefaultBranch)
               -ParserPath $(System.DefaultWorkingDirectory)/parser/RelWithDebInfo/ParseAzureSdkCpp.exe
               -ServicePath $(Build.SourcesDirectory)/sdk/${{ parameters.ServiceDirectory }}
-              -BuildId $(Build.BuildId)
-              -RepoName "$(Build.Repository.Name)"
             pwsh: true
             workingDirectory: $(Pipeline.Workspace)
-          displayName: Create API Review
-          condition: >-
-            and(
-              succeeded(),
-              ne(variables['Skip.CreateApiReview'], 'true'),
-              ne(variables['Build.Reason'],'PullRequest'),
-              eq(variables['System.TeamProject'], 'internal')
-            )
-
+          displayName: Generate APIReview Token Files
     - job: GenerateReleaseArtifacts
       pool:
         name: $(WINDOWSPOOL)
@@ -228,14 +202,29 @@ jobs:
                 -Name packages/${{ artifact.Name }}
               displayName: Create package info artifact location
 
+            - task: Powershell@2
+              inputs:
+                filePath: $(Build.SourcesDirectory)/eng/common/scripts/Save-Package-Properties.ps1
+                arguments: >
+                  -ServiceDirectory ${{parameters.ServiceDirectory}}
+                  -OutDirectory $(Build.ArtifactStagingDirectory)/PackageInfo
+                pwsh: true
+                workingDirectory: $(Pipeline.Workspace)
+              displayName: Dump Package properties
+
             - pwsh: |
                 $outputPath = Join-Path -Path $(Build.ArtifactStagingDirectory) packages/${{ artifact.Name }}/package-info.json
 
                 $version = eng/scripts/Get-PkgVersion -ServiceDirectory ${{ parameters.ServiceDirectory }} -PackageName ${{ artifact.Path }}
-                $outputObject = @{ version = $version.ToString(); name = '${{ artifact.Name }}'; packageName = "${{ artifact.Name }}_$version"; } | ConvertTo-Json
+                $outputObject = @{ version = $version.ToString(); name = '${{ artifact.Name }}'; ArtifactName = '${{ artifact.Name }}'; packageName = "${{ artifact.Name }}_$version"; DirectoryPath = ""} | ConvertTo-Json
 
                 Set-Content -Path $outputPath -Value $outputObject
 
+                $packageJsonDest = Join-Path -Path $(Build.ArtifactStagingDirectory)/packages "${{ artifact.Name }}"
+                $packageJsonSource = Join-Path -Path $(Build.ArtifactStagingDirectory) PackageInfo
+                Copy-Item $packageJsonSource/${{ artifact.Name }}.json $packageJsonDest -Force
+                Get-ChildItem $packageJsonDest | Rename-Item -NewName {$_ -replace "${{ artifact.Name }}.json","${{ artifact.Name }}_cpp.json"}
+
                 # Set AZURE_SDK_VERSION for use in Doxygen generation
                 Write-Host "##vso[task.setvariable variable=AZURE_SDK_VERSION]$version"
               displayName: Create package info JSON file for ${{ artifact.Name }}
@@ -334,10 +323,51 @@ jobs:
               continueOnError: true
               condition: and(succeeded(), eq(variables['VerifyChangeLogForRelease'], 'true'))
 
+        - pwsh: |
+            $packageJsonDest = Join-Path -Path $(Build.ArtifactStagingDirectory) packages/PackageInfo
+            $packageJsonSource = Join-Path -Path $(Build.ArtifactStagingDirectory) PackageInfo
+            mkdir $packageJsonDest
+            Copy-Item $packageJsonSource/* $packageJsonDest -Force
+            Get-ChildItem $packageJsonDest | Rename-Item -NewName {$_ -replace ".json","_cpp.json"}
+          displayName: Copy PackageJson
         - template: /eng/common/pipelines/templates/steps/publish-1es-artifact.yml
           parameters:
             ArtifactPath: $(Build.ArtifactStagingDirectory)/packages
             ArtifactName: packages
+        - template: /eng/common/pipelines/templates/steps/publish-1es-artifact.yml
+          parameters:
+            ArtifactPath: $(Build.ArtifactStagingDirectory)/PackageInfo
+            ArtifactName: PackageInfo
+
+        - task: Powershell@2
+          inputs:
+            filePath: $(System.DefaultWorkingDirectory)/eng/common/scripts/Create-APIReview.ps1
+            arguments: >
+              -ArtifactList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json | Select-Object Name)
+              -OutPath $(Build.ArtifactStagingDirectory)
+              -ApiKey "$(azuresdk-apiview-apikey)"
+              -SourceBranch $(Build.SourceBranchName)
+              -DefaultBranch $(DefaultBranch)
+              -ParserPath $(System.DefaultWorkingDirectory)/parser/RelWithDebInfo/ParseAzureSdkCpp.exe
+              -ServicePath $(Build.SourcesDirectory)/sdk/${{ parameters.ServiceDirectory }}
+              -BuildId $(Build.BuildId)
+              -RepoName "$(Build.Repository.Name)"
+            pwsh: true
+            workingDirectory: $(Pipeline.Workspace)
+          displayName: Create API Review
+          condition: >-
+            and(
+              succeeded(),
+              ne(variables['Skip.CreateApiReview'], 'true'),
+              ne(variables['Build.Reason'],'PullRequest'),
+              eq(variables['System.TeamProject'], 'internal')
+            )
+        - ${{ if eq(variables['Build.Reason'], 'PullRequest') }}:
+          - ${{ each artifact in parameters.Artifacts }}:
+            - template: /eng/common/pipelines/templates/steps/detect-api-changes.yml
+              parameters:
+                ArtifactName: ${{ artifact.Name }}
+                condition: succeeded()
 
         - template: /eng/common/pipelines/templates/steps/publish-1es-artifact.yml
           parameters:

eng/scripts/Create-APIReview.ps1

@@ -39,7 +39,7 @@ foreach ($artifact in $ArtifactList)
     $parentPath = Split-Path $ParserPath  -Parent
     Write-Host "Contents in $($parentPath)"
     Get-ChildItem -Path $parentPath -Recurse
-    & $ParserPath -o $OutPath/$ArtifactName/$ArtifactName.json $SourcePath
+    & $ParserPath -o $OutPath/$ArtifactName/${ArtifactName}_cpp.json $SourcePath
     if ($LASTEXITCODE -ne 0)
 	{
 		Write-Host "Failed to generate API review file for $($ArtifactName)"

eng/scripts/Generate-APIReview-Token-Files.ps1

@@ -0,0 +1,38 @@
+Param(
+    [Parameter(Mandatory=$True)]
+    [array] $ArtifactList,
+    [Parameter(Mandatory=$True)]
+    [string] $OutPath,
+    [Parameter(Mandatory=$True)]
+    [string] $ParserPath,
+    [Parameter(Mandatory=$True)]
+    [string] $ServicePath
+)
+
+Write-Host "$PSScriptRoot"
+. (Join-Path $PSScriptRoot .. common scripts common.ps1)
+
+foreach ($artifact in $ArtifactList)
+{
+    $ArtifactName = $artifact.name
+    Write-Host "Generating artifact for $ArtifactName"
+    $SourcePath = Join-Path $ServicePath $ArtifactName "inc"
+    $apiviewSettings = Join-Path $SourcePath "ApiViewSettings.json"
+    if (!(Test-Path $apiviewSettings))
+    {
+        Write-Host "ApiViewSettings.json file is not found in $($SourcePath). APIView settings file is required to generate API review file."
+        exit 1
+    }
+
+    Write-Host "Creating API review artifact for $ArtifactName"
+    New-Item -ItemType Directory -Path "$OutPath/$ArtifactName" -Force
+    $parentPath = Split-Path $ParserPath  -Parent
+    Write-Host "Contents in ${parentPath}:"
+    Get-ChildItem -Path $parentPath -Recurse
+    & $ParserPath -o "$OutPath/$ArtifactName/${ArtifactName}_cpp.json" $SourcePath
+    if ($LASTEXITCODE -ne 0)
+	{
+		Write-Host "Failed to generate API review file for $($ArtifactName)"
+		exit 1
+	}
+}

eng/scripts/Language-Settings.ps1

@@ -106,7 +106,7 @@ function SetPackageVersion ($PackageName, $Version, $ServiceDirectory, $ReleaseD
 
 function Find-cpp-Artifacts-For-Apireview($ArtifactPath, $PackageName)
 {
-  $artifact = @(Get-ChildItem -Path (Join-Path $ArtifactPath $PackageName) -Filter "*.json")
+  $artifact = @(Get-ChildItem -Path (Join-Path "$ArtifactPath/packages" $PackageName) -Filter "${PackageName}_cpp.json")
   if ($artifact)
   {
     $packages = @{

sdk/template/azure-template/src/template_client.cpp

@@ -1,5 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
+// Just Triggering Testings.
 
 #include "azure/template/template_client.hpp"