[apiview] adding pr support

eng/pipelines/templates/jobs/archetype-sdk-client.yml

@@ -108,38 +108,18 @@ jobs:
             vstsFeedPackage: 'parseazuresdkcpp'
             downloadDirectory: '$(System.DefaultWorkingDirectory)/parser'
             vstsPackageVersion: 0.13.0 
-          condition: >-
-              and(
-                succeeded(),
-                ne(variables['Skip.CreateApiReview'], 'true'),
-                ne(variables['Build.Reason'],'PullRequest'),
-                eq(variables['System.TeamProject'], 'internal')
-              )
+          condition: succeeded()
 
         - task: Powershell@2
           inputs:
-            filePath: $(System.DefaultWorkingDirectory)/eng/scripts/Create-APIReview.ps1
+            filePath: $(System.DefaultWorkingDirectory)/eng/scripts/Generate-APIReview-Token-Files.ps1
             arguments: >
               -ArtifactList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json | Select-Object Name)
               -OutPath $(Build.ArtifactStagingDirectory)
-              -ApiKey "$(azuresdk-apiview-apikey)"
-              -SourceBranch $(Build.SourceBranchName)
-              -DefaultBranch $(DefaultBranch)
               -ParserPath $(System.DefaultWorkingDirectory)/parser/RelWithDebInfo/ParseAzureSdkCpp.exe
               -ServicePath $(Build.SourcesDirectory)/sdk/${{ parameters.ServiceDirectory }}
-              -BuildId $(Build.BuildId)
-              -RepoName "$(Build.Repository.Name)"
             pwsh: true
             workingDirectory: $(Pipeline.Workspace)
-          displayName: Create API Review
-          condition: >-
-            and(
-              succeeded(),
-              ne(variables['Skip.CreateApiReview'], 'true'),
-              ne(variables['Build.Reason'],'PullRequest'),
-              eq(variables['System.TeamProject'], 'internal')
-            )
-
     - job: GenerateReleaseArtifacts
       pool:
         name: $(WINDOWSPOOL)
@@ -338,6 +318,35 @@ jobs:
           parameters:
             ArtifactPath: $(Build.ArtifactStagingDirectory)/packages
             ArtifactName: packages
+
+        - task: Powershell@2
+          inputs:
+            filePath: $(System.DefaultWorkingDirectory)/eng/common/scripts/Create-APIReview.ps1
+            arguments: >
+              -ArtifactList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json | Select-Object Name)
+              -OutPath $(Build.ArtifactStagingDirectory)
+              -ApiKey "$(azuresdk-apiview-apikey)"
+              -SourceBranch $(Build.SourceBranchName)
+              -DefaultBranch $(DefaultBranch)
+              -ParserPath $(System.DefaultWorkingDirectory)/parser/RelWithDebInfo/ParseAzureSdkCpp.exe
+              -ServicePath $(Build.SourcesDirectory)/sdk/${{ parameters.ServiceDirectory }}
+              -BuildId $(Build.BuildId)
+              -RepoName "$(Build.Repository.Name)"
+            pwsh: true
+            workingDirectory: $(Pipeline.Workspace)
+          displayName: Create API Review
+          condition: >-
+            and(
+              succeeded(),
+              ne(variables['Skip.CreateApiReview'], 'true'),
+              ne(variables['Build.Reason'],'PullRequest'),
+              eq(variables['System.TeamProject'], 'internal')
+            )
+        - ${{ if eq(variables['Build.Reason'], 'PullRequest') }}:
+          - template: /eng/common/pipelines/templates/steps/detect-api-changes.yml
+            parameters:
+              Artifacts: ${{ parameters.Artifacts }}
+              condition: succeeded()
 
         - template: /eng/common/pipelines/templates/steps/publish-1es-artifact.yml
           parameters:

eng/scripts/Create-APIReview.ps1

@@ -39,7 +39,7 @@ foreach ($artifact in $ArtifactList)
     $parentPath = Split-Path $ParserPath  -Parent
     Write-Host "Contents in $($parentPath)"
     Get-ChildItem -Path $parentPath -Recurse
-    & $ParserPath -o $OutPath/$ArtifactName/$ArtifactName.json $SourcePath
+    & $ParserPath -o $OutPath/$ArtifactName/$ArtifactName_cpp.json $SourcePath
     if ($LASTEXITCODE -ne 0)
 	{
 		Write-Host "Failed to generate API review file for $($ArtifactName)"

eng/scripts/Generate-APIReview-Token-Files.ps1

@@ -0,0 +1,38 @@
+Param(
+    [Parameter(Mandatory=$True)]
+    [array] $ArtifactList,
+    [Parameter(Mandatory=$True)]
+    [string] $OutPath,
+    [Parameter(Mandatory=$True)]
+    [string] $ParserPath,
+    [Parameter(Mandatory=$True)]
+    [string] $ServicePath
+)
+
+Write-Host "$PSScriptRoot"
+. (Join-Path $PSScriptRoot .. common scripts common.ps1)
+
+foreach ($artifact in $ArtifactList)
+{
+    $ArtifactName = $artifact.name
+    Write-Host "Generating artifact for $ArtifactName"
+    $SourcePath = Join-Path $ServicePath $ArtifactName "inc"
+    $apiviewSettings = Join-Path $SourcePath "ApiViewSettings.json"
+    if (!(Test-Path $apiviewSettings))
+    {
+        Write-Host "ApiViewSettings.json file is not found in $($SourcePath). APIView settings file is required to generate API review file."
+        exit 1
+    }
+
+    Write-Host "Creating API review artifact for $($ArtifactName)"
+    New-Item -ItemType Directory -Path $OutPath/$ArtifactName -force
+    $parentPath = Split-Path $ParserPath  -Parent
+    Write-Host "Contents in $($parentPath)"
+    Get-ChildItem -Path $parentPath -Recurse
+    & $ParserPath -o $OutPath/$ArtifactName/$ArtifactName_cpp.json $SourcePath
+    if ($LASTEXITCODE -ne 0)
+	{
+		Write-Host "Failed to generate API review file for $($ArtifactName)"
+		exit 1
+	}
+}

eng/scripts/Language-Settings.ps1

@@ -106,7 +106,7 @@ function SetPackageVersion ($PackageName, $Version, $ServiceDirectory, $ReleaseD
 
 function Find-cpp-Artifacts-For-Apireview($ArtifactPath, $PackageName)
 {
-  $artifact = @(Get-ChildItem -Path (Join-Path $ArtifactPath $PackageName) -Filter "*.json")
+  $artifact = @(Get-ChildItem -Path (Join-Path $ArtifactPath $PackageName) -Filter "*_cpp.json")
   if ($artifact)
   {
     $packages = @{

sdk/template/azure-template/src/template_client.cpp

@@ -1,5 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
+// Just Triggering Testing Pipelines
 
 #include "azure/template/template_client.hpp"