Allow x-vss-e2eid response header to be logged in AzurePipelinesCredential for diagnostics. #6001
+161
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntial for diagnostics.
antkmsft
approved these changes
Sep 18, 2024
|
/azp run cpp - identity |
|
Azure Pipelines successfully started running 1 pipeline(s). |
LarryOsterman
approved these changes
Sep 18, 2024
sdk/identity/azure-identity/inc/azure/identity/azure_pipelines_credential.hpp
Show resolved
Hide resolved
ahsonkhan
requested review from
schaabs,
RickWinter,
gearama and
a team
as code owners
ahsonkhan
requested review from
maorleger,
pvaneck,
billwert,
KarishmaGhiya,
scottaddie and
mpodwysocki
This was referenced Sep 20, 2024
…o APCLogHeaders t status
|
/azp run cpp - identity |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For any responses coming from the OIDC endpoint as part of getting the token from AzurePipelinesCredential, we allow logging the
x-vss-e2eidresponse header so that the service team can use that info for diagnostics and troubleshooting.Fixes #5992
The value of the
activityidandx-vss-e2eidare identical, so it doesn't seem necessary to log both. Also, even though we aren't enabling the header to be logged globally, it is worth noting thatactivityidseems to be used by other management plan services, unlikex-vss-e2eidwhich seems to only be used by Azure Pipelines and the azure devops cli/extension.@manolerazvan, @geekzter, @kboom - please take a look and confirm this header is useful (and safe) to log along with any other headers that you'd find useful for the SDK customers to provide when filing issues.