Skip to content

Commit

Permalink
azsecrets prep for release (#20962)
Browse files Browse the repository at this point in the history
  • Loading branch information
gracewilcox authored Jun 6, 2023
1 parent 21c5900 commit d78d9a6
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 22 deletions.
3 changes: 2 additions & 1 deletion sdk/security/keyvault/azsecrets/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Release History

## 1.0.0 (Unreleased)
## 0.14.0 (2023-06-06)

### Breaking Changes
* Renamed `Client.ListSecrets` to `Client.ListSecretProperties`
Expand All @@ -11,6 +11,7 @@
* Renamed `DeletedSecretItem` to `DeletedSecretProperties`
* Renamed `Kid` to `KID`
* Removed `DeletionRecoveryLevel` type
* Remove `MaxResults` option

### Other Changes
* Updated dependencies
Expand Down
2 changes: 1 addition & 1 deletion sdk/security/keyvault/azsecrets/assets.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "go",
"TagPrefix": "go/security/keyvault/azsecrets",
"Tag": "go/security/keyvault/azsecrets_857c006979"
"Tag": "go/security/keyvault/azsecrets_c3ed1e9c8d"
}
6 changes: 6 additions & 0 deletions sdk/security/keyvault/azsecrets/autorest.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,12 @@ directive:
where: $
transform: return $.replace(/DeletionRecoveryLevel/g, "string");

# Remove MaxResults parameter
- where: "$.paths..*"
remove-parameter:
in: query
name: maxresults

# delete unused error models
- from: models.go
where: $
Expand Down
10 changes: 0 additions & 10 deletions sdk/security/keyvault/azsecrets/client.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions sdk/security/keyvault/azsecrets/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ func TestListDeletedSecrets(t *testing.T) {
})

expected := map[string]struct{}{secret1: {}, secret2: {}}
pager := client.NewListDeletedSecretPropertiesPager(&azsecrets.ListDeletedSecretPropertiesOptions{MaxResults: to.Ptr(int32(1))})
pager := client.NewListDeletedSecretPropertiesPager(nil)
for pager.More() && len(expected) > 0 {
page, err := pager.NextPage(context.Background())
require.NoError(t, err)
Expand Down Expand Up @@ -265,7 +265,7 @@ func TestListSecrets(t *testing.T) {
defer cleanUpSecret(t, client, name)
}

pager := client.NewListSecretPropertiesPager(&azsecrets.ListSecretPropertiesOptions{MaxResults: to.Ptr(int32(1))})
pager := client.NewListSecretPropertiesPager(nil)
for pager.More() {
page, err := pager.NextPage(context.Background())
require.NoError(t, err)
Expand Down Expand Up @@ -302,7 +302,7 @@ func TestListSecretVersions(t *testing.T) {
}
defer cleanUpSecret(t, client, name)

pager := client.NewListSecretPropertiesVersionsPager(name, &azsecrets.ListSecretPropertiesVersionsOptions{MaxResults: to.Ptr(int32(1))})
pager := client.NewListSecretPropertiesVersionsPager(name, nil)
for pager.More() {
page, err := pager.NextPage(context.Background())
require.NoError(t, err)
Expand Down
9 changes: 3 additions & 6 deletions sdk/security/keyvault/azsecrets/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sdk/security/keyvault/azsecrets/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ package azsecrets

const (
moduleName = "azsecrets"
version = "v1.0.0"
version = "v0.14.0"
)

0 comments on commit d78d9a6

Please sign in to comment.