Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build in module-aware mode #11783

Merged
merged 16 commits into from
Jul 22, 2020
Merged

Build in module-aware mode #11783

merged 16 commits into from
Jul 22, 2020

Conversation

jhendrixMSFT
Copy link
Member

Get the list of module directories. For each directory, do
build/vet/test.

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • Apache v2 license headers are included in each file.

@jhendrixMSFT
Build in module-aware mode
b94025e 
Get the list of module directories.  For each directory, do
build/vet/test.
@jhendrixMSFT jhendrixMSFT requested a review from scbedd July 20, 2020 22:38
@jhendrixMSFT
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link

Can one of the admins verify this patch?

@jhendrixMSFT
exclude track 2 content from track 1 CI
28ed37b
@jhendrixMSFT
process coverage per module
85ae1b2 
include all test report.xml files
update azidentity dependencies
@jhendrixMSFT
fix path
2a10243
@jhendrixMSFT
Copy link
Member Author

@scbedd @catalinaperalta should be ready for final review.

catalinaperalta
catalinaperalta approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to the best of my knowledge. Would appreciate @scbedd taking a look.

@jhendrixMSFT jhendrixMSFT merged commit e1ce057 into Azure:track2 Jul 22, 2020
@jhendrixMSFT jhendrixMSFT deleted the track2_gomodci branch July 22, 2020 18:38
@jhendrixMSFT jhendrixMSFT mentioned this pull request Jul 22, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catalinaperalta catalinaperalta catalinaperalta approved these changes

@scbedd scbedd Awaiting requested review from scbedd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhendrixMSFT @azuresdkci @catalinaperalta @scbedd