Refactor azcosmos client constructor #15705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
added
Cosmos
Client
|
@chlowell The recommendation then is to have |
|
Yes. |
ealsur
approved these changes
Oct 5, 2021
|
@chlowell Can you update the README examples please? Then we can merge this in. |
ealsur
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next version of azcore doesn't contain
azcore.Credential, so client constructors must be explicit about the credential types they accept. Pretty straightforward here because there's only one credential type. I renamed the constructor NewCosmosClient -> NewClientWithSharedKey to align with upcoming guidelines for the SDK (the "good" name, NewClient, would go to a constructor takingazcore.TokenCredential, i.e. an Azure AD credential).