Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACR data plane module #19554

Merged
merged 45 commits into from
Feb 1, 2023
Merged

ACR data plane module #19554

merged 45 commits into from
Feb 1, 2023

Conversation

tadelesh
Copy link
Member

@tadelesh tadelesh commented Nov 11, 2022 •
edited
Loading

This is the first preview version of ACR data plane package. Most majority of the operations is auto-generated. Customizations are done by autorest directive. Manual code includes auth policy, client CTOR and blob upload operations.
Resolve: #19483

@tadelesh
Copy link
Member Author

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tadelesh
Copy link
Member Author

/azp run go - azacr - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jhendrixMSFT
Copy link
Member

Should the path be something like this.

/sdk/containerregistry/azacr

IMO acr is too non-descript for the top-level path.

@tadelesh
Copy link
Member Author

tadelesh commented Dec 1, 2022

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tadelesh
Copy link
Member Author

tadelesh commented Dec 1, 2022

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tadelesh tadelesh changed the title [WIP] ACR data plane module ACR data plane module Dec 18, 2022
@tadelesh tadelesh marked this pull request as ready for review December 18, 2022 09:11
@tadelesh
Copy link
Member Author

tadelesh commented Jan 6, 2023

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tadelesh
Copy link
Member Author

tadelesh commented Jan 6, 2023

/azp run go - azcontainerregistry - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jhendrixMSFT
jhendrixMSFT requested changes Jan 19, 2023
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New SDKs should use remote test assets and not check in the recordings. Please see https://github.com/Azure/azure-sdk-tools/blob/main/tools/test-proxy/documentation/asset-sync/README.md#im-a-dev-who-uses-the-test-proxy-currently-how-do-i-externalize-my-recordings for more details.

You can also see an example of this being enabled for azqueue in #19756

@tadelesh
Copy link
Member Author

New SDKs should use remote test assets and not check in the recordings. Please see https://github.com/Azure/azure-sdk-tools/blob/main/tools/test-proxy/documentation/asset-sync/README.md#im-a-dev-who-uses-the-test-proxy-currently-how-do-i-externalize-my-recordings for more details.

You can also see an example of this being enabled for azqueue in #19756

Resolved.

@tadelesh
Copy link
Member Author

@jhendrixMSFT I've resolved all CI failure. Could you help to review again?

@tadelesh tadelesh merged commit 3a39031 into Azure:main Feb 1, 2023
@tadelesh tadelesh deleted the azacr branch March 1, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@benbp benbp Awaiting requested review from benbp

@weshaggard weshaggard Awaiting requested review from weshaggard

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner

@richardpark-msft richardpark-msft Awaiting requested review from richardpark-msft richardpark-msft is a code owner

@JeffreyRichter JeffreyRichter Awaiting requested review from JeffreyRichter

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang

@lirenhe lirenhe Awaiting requested review from lirenhe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ACR dataplane package beta version
2 participants
@tadelesh @jhendrixMSFT