Request.SetBody() allows overwriting with an empty body #19754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
requested review from
RickWinter,
jhendrixMSFT and
richardpark-msft
as code owners
jhendrixMSFT
reviewed
Jan 5, 2023
jhendrixMSFT
reviewed
Jan 5, 2023
jhendrixMSFT
approved these changes
Jan 5, 2023
jhendrixMSFT
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, sending a
Requestwithout its body (Key Vault clients do this) requires copying it and/or modifying the underlyinghttp.RequestbecauseRequest.SetBody()won't overwrite a non-empty body with an empty one. This is apparently an oversight--SetBodywill overwrite a non-empty body or set an empty body, but it won't do both at once.