Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tracing spans to azidentity credentials #21885

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Add tracing spans to azidentity credentials #21885

merged 5 commits into from
Nov 7, 2023

Conversation

jhendrixMSFT
Copy link
Member

Replaced runtime.Pipelines with azcore.Clients.
Removed the pipeline adapter. Now, the confidential and public clients satisfy the MSAL HTTPClient interface.

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to module CHANGELOG.md are included.
  • MIT license headers are included in each file.

@jhendrixMSFT jhendrixMSFT force-pushed the azidentity-tracing-1 branch 2 times, most recently from 80e9f59 to 743c12b Compare November 3, 2023 20:48
@jhendrixMSFT jhendrixMSFT marked this pull request as ready for review November 3, 2023 21:00
@jhendrixMSFT jhendrixMSFT requested review from chlowell, RickWinter and a team as code owners November 3, 2023 21:00
@jhendrixMSFT
Add tracing spans to azidentity credentials
35d8ad5 
Replaced runtime.Pipelines with azcore.Clients.
Removed the pipeline adapter. Now, the confidential and public clients
satisfy the MSAL HTTPClient interface.
@jhendrixMSFT
fix moduleName parameter
a9fe2e5
@jhendrixMSFT jhendrixMSFT merged commit fd6f185 into Azure:main Nov 7, 2023
@jhendrixMSFT jhendrixMSFT deleted the azidentity-tracing-1 branch November 7, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlowell chlowell chlowell approved these changes

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner automatically assigned from Azure/azure-sdk-write-identity

@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan ahsonkhan is a code owner automatically assigned from Azure/azure-sdk-write-identity

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99 xiangyan99 is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees
No one assigned
Labels
Azure.Identity
Projects
Azure Identity SDK Improvements
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhendrixMSFT @chlowell