Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue where bastion ip config name wasnt marshalled to json #5234

Closed
wants to merge 1 commit into from
Closed

fix issue where bastion ip config name wasnt marshalled to json #5234

wants to merge 1 commit into from

Conversation

DanielMabbett
Copy link

@DanielMabbett DanielMabbett commented Jul 12, 2019

  • The purpose of this PR is explained in this or a referenced issue.

This shall marshal the "Name" property for the &[]network.BastionHostIPConfiguration{}

  • [x ] The PR does not update generated files.
  • [x ] The PR targets the latest branch.
  • Tests are included and/or updated for code changes.
    I can't
  • Updates to CHANGELOG.md are included.
  • [ x] Apache v2 license headers are included in each file.

@azuresdkci
Copy link

Can one of the admins verify this patch?

@jhendrixMSFT
Copy link
Member

Hello! The SDK content is auto-generated from swagger files, so the swagger must be updated else this change will be lost. I've opened issue Azure/azure-rest-api-specs#6608 to track this, if you have any additional information on this can you please add it there? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants