Revert "Merge Master to feature/cosmos/spark30"

common/perf-test-core/README.md

@@ -32,7 +32,8 @@ helps developers create their performance tests for their APIs.
 
 ## Contributing
 
-For details on contributing to this repository, see the [contributing guide](https://github.com/Azure/azure-sdk-for-java/blob/master/CONTRIBUTING.md).
+If you would like to become an active contributor to this project please follow the instructions provided in [Microsoft
+Azure Projects Contribution Guidelines](https://azure.github.io/guidelines.html).
 
 1. Fork it
 1. Create your feature branch (`git checkout -b my-new-feature`)

eng/code-quality-reports/src/main/resources/checkstyle/checkstyle-suppressions.xml

@@ -348,14 +348,6 @@
   <!-- InvalidKeyException is not a runtime exception, issue link: https://github.com/Azure/azure-sdk-for-java/issues/5178 -->
   <suppress checks="com.azure.tools.checkstyle.checks.ThrowFromClientLogger"
             files="com.azure.security.keyvault.keys.cryptography.AesCbc.java"/>
-  <suppress checks="com.azure.tools.checkstyle.checks.ThrowFromClientLogger"
-            files="com.azure.security.keyvault.keys.cryptography.AesCbcPad.java"/>
-  <suppress checks="com.azure.tools.checkstyle.checks.ThrowFromClientLogger"
-            files="com.azure.security.keyvault.keys.cryptography.AesGcm.java"/>
-
-  <!-- suppress the runtime exception in the KeyVaultClient class-->
-  <suppress checks="com.azure.tools.checkstyle.checks.ThrowFromClientLogger"
-            files="com.azure.security.keyvault.jca.KeyVaultClient.java"/>
 
   <!-- MSAL extension temporarily living in our package. Will not take dependency on azure-core once migrated to MSAL repo -->
   <suppress checks="com.azure.tools.checkstyle.checks.ThrowFromClientLogger"
@@ -471,9 +463,6 @@
   <suppress checks="[a-zA-Z0-9]*" files="com.azure.data.schemaregistry.implementation.*"/>
   <suppress checks="[a-zA-Z0-9]*" files="com.microsoft.opentelemetry.exporter.azuremonitor.implementation.*"/>
 
-  <!-- Use the logger in a Utility static method. -->
-  <suppress checks="com.azure.tools.checkstyle.checks.GoodLoggingCheck" files="com.azure.ai.textanalytics.implementation.Utility.java"/>
-
   <!-- Suppress the check on code-gen classes -->
   <suppress checks="LineLength" files="com.azure.ai.formrecognizer.implementation.FormRecognizerClientImplBuilder"/>
   <suppress checks="LineLength" files="com.azure.ai.formrecognizer.implementation.FormRecognizerClientImpl"/>

eng/code-quality-reports/src/main/resources/revapi/revapi.json

@@ -269,92 +269,6 @@
         "code": "java.annotation.added",
         "new": "class com.azure.storage.blob.models.PageList",
         "justification": "Annotation required to resolve deserialization bug."
-      },{
-        "code": "java.method.returnTypeChanged",
-        "old": "method com.azure.core.util.IterableStream<byte[]> com.azure.core.amqp.models.AmqpDataBody::getData()",
-        "new": "method java.util.List<byte[]> com.azure.core.amqp.models.AmqpDataBody::getData()",
-        "justification": "Updated "
-      },
-      {
-        "code": "java.class.removed",
-        "old": "class com.azure.core.amqp.models.AmqpDataBody",
-        "justification": "Renamed as AmqpMessageBody."
-      },
-      {
-        "code": "java.class.kindChanged",
-        "old": "interface com.azure.core.amqp.models.AmqpMessageBody",
-        "new": "class com.azure.core.amqp.models.AmqpMessageBody",
-        "justification": "AmqpMessageBody is class representing all the new AMQP data types."
-      },
-      {
-        "code": "java.class.nowFinal",
-        "old": "interface com.azure.core.amqp.models.AmqpMessageBody",
-        "new": "class com.azure.core.amqp.models.AmqpMessageBody",
-        "justification": "Made it final."
-      },
-      {
-        "code": "java.class.removed",
-        "old": "enum com.azure.core.amqp.models.AmqpBodyType",
-        "justification": "Because It is renamed to AmqpMessageBodyType"
-      },
-      {
-        "code": "java.method.returnTypeChanged",
-        "old": "method com.azure.core.amqp.models.AmqpBodyType com.azure.core.amqp.models.AmqpMessageBody::getBodyType()",
-        "new": "method com.azure.core.amqp.models.AmqpMessageBodyType com.azure.core.amqp.models.AmqpMessageBody::getBodyType()",
-        "justification": "Renamed to match AmqpMessage prefix."
-      },
-      {
-        "code": "java.method.returnTypeChanged",
-        "old": "method java.lang.String com.azure.core.amqp.models.AmqpMessageProperties::getCorrelationId()",
-        "new": "method com.azure.core.amqp.models.AmqpMessageId com.azure.core.amqp.models.AmqpMessageProperties::getCorrelationId()",
-        "justification": "New return type AmqpMessageId."
-      },
-      {
-        "code": "java.method.returnTypeChanged",
-        "old": "method java.lang.String com.azure.core.amqp.models.AmqpMessageProperties::getMessageId()",
-        "new": "method com.azure.core.amqp.models.AmqpMessageId com.azure.core.amqp.models.AmqpMessageProperties::getMessageId()",
-        "justification": "New return type."
-      },
-      {
-        "code": "java.method.returnTypeChanged",
-        "old": "method java.lang.String com.azure.core.amqp.models.AmqpMessageProperties::getReplyTo()",
-        "new": "method com.azure.core.amqp.models.AmqpAddress com.azure.core.amqp.models.AmqpMessageProperties::getReplyTo()",
-        "justification": "New return type."
-      },
-      {
-        "code": "java.method.returnTypeChanged",
-        "old": "method java.lang.String com.azure.core.amqp.models.AmqpMessageProperties::getTo()",
-        "new": "method com.azure.core.amqp.models.AmqpAddress com.azure.core.amqp.models.AmqpMessageProperties::getTo()",
-        "justification": "New return type."
-      },
-      {
-        "code": "java.method.parameterTypeChanged",
-        "old": "parameter com.azure.core.amqp.models.AmqpMessageProperties com.azure.core.amqp.models.AmqpMessageProperties::setCorrelationId(===java.lang.String===)",
-        "new": "parameter com.azure.core.amqp.models.AmqpMessageProperties com.azure.core.amqp.models.AmqpMessageProperties::setCorrelationId(===com.azure.core.amqp.models.AmqpMessageId===)",
-        "justification": "Introduced new type AmqpMessageId."
-      },
-      {
-        "code": "java.method.parameterTypeChanged",
-        "old": "parameter com.azure.core.amqp.models.AmqpMessageProperties com.azure.core.amqp.models.AmqpMessageProperties::setMessageId(===java.lang.String===)",
-        "new": "parameter com.azure.core.amqp.models.AmqpMessageProperties com.azure.core.amqp.models.AmqpMessageProperties::setMessageId(===com.azure.core.amqp.models.AmqpMessageId===)",
-        "justification":"Introduced new type AmqpMessageId."
-      },
-      {
-        "code": "java.method.parameterTypeChanged",
-        "old": "parameter com.azure.core.amqp.models.AmqpMessageProperties com.azure.core.amqp.models.AmqpMessageProperties::setReplyTo(===java.lang.String===)",
-        "new": "parameter com.azure.core.amqp.models.AmqpMessageProperties com.azure.core.amqp.models.AmqpMessageProperties::setReplyTo(===com.azure.core.amqp.models.AmqpAddress===)",
-        "justification": "Introduced new type AmqpAddress."
-      },
-      {
-        "code": "java.method.parameterTypeChanged",
-        "old": "parameter com.azure.core.amqp.models.AmqpMessageProperties com.azure.core.amqp.models.AmqpMessageProperties::setTo(===java.lang.String===)",
-        "new": "parameter com.azure.core.amqp.models.AmqpMessageProperties com.azure.core.amqp.models.AmqpMessageProperties::setTo(===com.azure.core.amqp.models.AmqpAddress===)",
-        "justification": "Introduced new type AmqpAddress."
-      },
-      {
-        "code": "java.method.removed",
-        "old": "method void com.azure.core.amqp.models.AmqpAnnotatedMessage::<init>(com.azure.core.amqp.models.AmqpAnnotatedMessage)",
-        "justification": "Removed copy constructor, It is not required for Service bus message."
       }
     ]
   }

eng/code-quality-reports/src/main/resources/spotbugs/spotbugs-exclude.xml

@@ -1351,13 +1351,6 @@
     <Bug pattern="UWF_UNWRITTEN_FIELD" />
   </Match>
 
-  <!-- TextAnalyticsException fields re serializable -->
-  <Match>
-    <Class name="com.azure.ai.textanalytics.models.TextAnalyticsException" />
-    <Field name="errorInformationList" />
-    <Bug pattern="SE_BAD_FIELD" />
-  </Match>
-
   <!-- Exception is required to catch, ref: code comment in the OrderbyRowComparer::compare() method  -->
   <Match>
     <Class name="com.azure.cosmos.implementation.query.orderbyquery.OrderbyRowComparer"/>
@@ -2304,7 +2297,7 @@
       <Field name="authenticationRecord"/>
       <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED"/>
   </Match>
-
+  
   <!-- These fields are designed to be not written. They are for deserializing. -->
   <Match>
       <Class name="com.azure.identity.implementation.LinuxKeyRingAccessor$GError"/>
@@ -2397,7 +2390,7 @@
     <Method name="getUserName" />
     <Bug pattern="NM_CONFUSING" />
   </Match>
-
+ 
   <!-- Disabling false positives in azure-core -->
   <!-- This Issue has been resolved as per spotbugs's recommended solution but the static checker still flags it, its a known issue with this rule. -->
   <Match>
@@ -2428,21 +2421,4 @@
       <Method name="~(get|post)" />
       <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE" />
   </Match>
-
-  <!-- Conflicting APIs have already been GA'd with incorrect capitalization  -->
-  <Match>
-    <Or>
-      <Class name="com.azure.security.keyvault.keys.cryptography.DecryptOptions" />
-      <Class name="com.azure.security.keyvault.keys.cryptography.EncryptOptions" />
-    </Or>
-    <Bug pattern="NM_CONFUSING" />
-  </Match>
-  <!-- Returning a new copy of the object is not necessary for queuing system use cases.
-  Client do not change content of message once message is created. Array copy would degrade the performance.
-  https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/models/AmqpMessageBody.java#L115 -->
-  <Match>
-    <Class name="com.azure.core.amqp.models.AmqpMessageBody"/>
-    <Field name="data"/>
-    <Bug pattern="EI_EXPOSE_REP"/>
-  </Match>
 </FindBugsFilter>