Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Improvements for FluxUtils #18942

Merged
merged 15 commits into from
Feb 18, 2021
Merged

Performance Improvements for FluxUtils #18942

merged 15 commits into from
Feb 18, 2021

Conversation

alzimmermsft
Copy link
Member

This PR contains general performance improvements for FluxUtils utility methods. The aim of this PR is to reduce CPU usage, memory thrashing, and peak memory consumption.

@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. Azure.Core azure-core pillar-performance The issue is related to performance, one of our core engineering pillars. labels Feb 2, 2021
@alzimmermsft alzimmermsft self-assigned this Feb 2, 2021
@check-enforcer
Copy link

check-enforcer bot commented Feb 2, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@JonathanGiles
Copy link
Member

/azp run java - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alzimmermsft alzimmermsft marked this pull request as ready for review February 17, 2021 02:39
srnagar
srnagar reviewed Feb 17, 2021
View reviewed changes
...http-jdk-httpclient/src/main/java/com/azure/core/http/jdk/httpclient/JdkAsyncHttpClient.java Outdated Show resolved Hide resolved
...core/azure-core-http-netty/src/main/java/com/azure/core/http/netty/NettyAsyncHttpClient.java Outdated Show resolved Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/implementation/ByteBufferCollector.java
* @return A copy of the backing array.
*/
public synchronized byte[] toByteArray() {
return Arrays.copyOf(buffer, position);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is used internally, can we avoid array copy? Can the buffer be returned directly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll be a performance hit, but for now I'd rather return a copy as this will be safe from additional changes after return if more bytes are written.

srnagar
srnagar approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alzimmermsft alzimmermsft merged commit 081d4e5 into Azure:master Feb 18, 2021
@alzimmermsft alzimmermsft deleted the AzCore_FluxUtilsPerfImprovements branch February 18, 2021 19:37
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Jun 1, 2022
CodeGen from PR 18942 in Azure/azure-rest-api-specs
6215d7e 
[Hub Generated] Publish private branch 'rolyon-permissions-extension-test-v1' (Azure#18942)

* Permissions for elevate access

* Repositioned permissions section

* Extension name change

* Deleted extra spaces

* Changed rolesWithThesePermissions to an array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanGiles JonathanGiles JonathanGiles approved these changes

@srnagar srnagar srnagar approved these changes

@anuchandy anuchandy Awaiting requested review from anuchandy

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

@hemanttanwar hemanttanwar Awaiting requested review from hemanttanwar

@g2vinay g2vinay Awaiting requested review from g2vinay

Assignees

@alzimmermsft alzimmermsft

Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. pillar-performance The issue is related to performance, one of our core engineering pillars.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alzimmermsft @JonathanGiles @hemanttanwar @srnagar