mgmt, make storage account more secure by setting better default #19649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenTanyi
approved these changes
Mar 8, 2021
yungezz
reviewed
Mar 8, 2021
| .withSku(StorageAccountSkuType.STANDARD_RAGRS) | ||
| .withGeneralPurposeAccountKindV2() | ||
| .withOnlyHttpsTraffic() | ||
| .withMinimumTlsVersion(MinimumTlsVersion.TLS1_2); |
There was a problem hiding this comment.
user still able to customize this one, right?
There was a problem hiding this comment.
Yes, customer can configure differently as in test code https://github.com/Azure/azure-sdk-for-java/pull/19649/files#diff-edf813069045825a9ed68c4408e389ba75eae39461b4a2ff37b8a5df20469e05R246-R250
The default here in SDK matches Portal default.
yungezz
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, minimal TLS version will be 1.2
HTTPS only is already service default, so no change on this even with code added to SDK.
This could be a behavior change, though I think it be worth it in long term.