Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Async Attestation Client #23070

Merged
merged 42 commits into from
Aug 2, 2021

Conversation

LarryOsterman
Copy link
Member

  • Split Async APIs from AttestationClientBuilder into a new AttestationAsyncClientBuilder
  • Removed MetadataConfigurationClient, rolled the functionality into AttestationClient.
  • Refactored AttestationClient methods to forward to AttestationAsyncClient.
  • Refactored the Xxxx APIs to forward to XxxxWithResponse API.

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@LarryOsterman
Copy link
Member Author

$sourceSessionRecordPath = ".\target\test-classes\session-records"

Curious do you use this file by manual calling the ps1 or does our eng system support this direclty somehow?

Refers to: sdk/attestation/azure-security-attestation/update-recorded-sessions.ps1:3 in d6bc8df. [](commit_id = d6bc8df, deletion_comment = False)

Manually - I found this in digitaltwins and modelsrepository and I thought it was an excellent idea to automate updating recordings.

If there was an automated way of doing it, I'd love to do that (the other 3 SDKs automatically update their recordings), but this was a poor-man's alternative. One thing I might do is to delete the existing session records, since they often get stale.

@pallavit
Copy link
Contributor

There isn't I have a macro as well for this. So, when I saw your script - I was curious! You may already know this but if you are changing test names or removing some old tests - there may be stale files in the session_records. So, it might be worth it to guard against it.


In reply to: 885046351

@LarryOsterman
Copy link
Member Author

Ping? I'd like to get this committed so I can make forward progress.

Copy link
Contributor

@pallavit pallavit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@LarryOsterman LarryOsterman enabled auto-merge (squash) August 2, 2021 23:23
@LarryOsterman LarryOsterman merged commit a312a34 into Azure:main Aug 2, 2021
@LarryOsterman LarryOsterman deleted the LarryO-CreateAsyncClient branch August 2, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants