-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Async Attestation Client #23070
Create Async Attestation Client #23070
Conversation
…n top of async client
…r; Restructured Attestation client to wrap async attestation client; Removed MetadataConfigurationClient and folded it into AttestationClient/AttestationAsyncClient
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
Manually - I found this in digitaltwins and modelsrepository and I thought it was an excellent idea to automate updating recordings. If there was an automated way of doing it, I'd love to do that (the other 3 SDKs automatically update their recordings), but this was a poor-man's alternative. One thing I might do is to delete the existing session records, since they often get stale. |
There isn't I have a macro as well for this. So, when I saw your script - I was curious! You may already know this but if you are changing test names or removing some old tests - there may be stale files in the session_records. So, it might be worth it to guard against it. In reply to: 885046351 |
...ecurity-attestation/src/main/java/com/azure/security/attestation/AttestationAsyncClient.java
Outdated
Show resolved
Hide resolved
...ecurity-attestation/src/main/java/com/azure/security/attestation/AttestationAsyncClient.java
Show resolved
Hide resolved
...ecurity-attestation/src/main/java/com/azure/security/attestation/AttestationAsyncClient.java
Show resolved
Hide resolved
...ecurity-attestation/src/main/java/com/azure/security/attestation/AttestationAsyncClient.java
Show resolved
Hide resolved
...ecurity-attestation/src/main/java/com/azure/security/attestation/AttestationAsyncClient.java
Show resolved
Hide resolved
...ecurity-attestation/src/main/java/com/azure/security/attestation/AttestationAsyncClient.java
Show resolved
Hide resolved
...-attestation/src/main/java/com/azure/security/attestation/AttestationAsyncClientBuilder.java
Outdated
Show resolved
Hide resolved
...-attestation/src/main/java/com/azure/security/attestation/AttestationAsyncClientBuilder.java
Outdated
Show resolved
Hide resolved
Ping? I'd like to get this committed so I can make forward progress. |
...ure-security-attestation/src/main/java/com/azure/security/attestation/AttestationClient.java
Show resolved
Hide resolved
...attestation/src/main/java/com/azure/security/attestation/SigningCertificatesAsyncClient.java
Outdated
Show resolved
Hide resolved
...urity-attestation/src/main/java/com/azure/security/attestation/models/AttestationSigner.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AttestationClientBuilder
into a newAttestationAsyncClientBuilder
MetadataConfigurationClient
, rolled the functionality intoAttestationClient
.AttestationClient
methods to forward toAttestationAsyncClient
.Xxxx
APIs to forward toXxxxWithResponse
API.