New Feature: Adding Index Metrics to Query Metrics #23497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aayush3011
requested review from
FabianMeiswinkel,
kirankumarkolli,
kushagraThapar,
mbhaskar,
milismsft,
moderakh,
simplynaveen20 and
xinlian12
as code owners
ghost
added
the
...re-cosmos/src/main/java/com/azure/cosmos/implementation/CompositeIndexUtilizationEntity.java
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/SingleIndexUtilizationEntity.java
Show resolved
Hide resolved
...e-cosmos/src/main/java/com/azure/cosmos/implementation/query/metrics/QueryMetricsWriter.java
Outdated
Show resolved
Hide resolved
added 2 commits
August 11, 2021 11:46
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/IndexUtilizationInfo.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/IndexUtilizationInfo.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/QueryMetrics.java
Outdated
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/SingleIndexUtilizationEntity.java
Outdated
Show resolved
Hide resolved
...ure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/WFConstants.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosQueryRequestOptions.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosDiagnosticsTest.java
Show resolved
Hide resolved
...rc/main/java/com/azure/cosmos/implementation/query/DefaultDocumentQueryExecutionContext.java
Show resolved
Hide resolved
|
Any reason why we chose the tabular format?
I recommend printing these either in the format that is used by server side query metrics or as a simple json instead of the current way |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kushagraThapar
approved these changes
Aug 17, 2021
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosQueryRequestOptions.java
Show resolved
Hide resolved
|
As per the benchmark graph impact is > 2% , did we do multiple run to have more accurate result ? |
@simplynaveen20 - that was only 1 run, I am running the performance benchmark for multiple runs, will share the result soon. |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
May 26, 2023
Release app microsoft.app 2023 04 01 preview (Azure#24103) * Adds base for updating Microsoft.App from version preview/2022-11-01-preview to version 2023-04-01-preview * Updates readme * Updates API version in new specs and examples * support terminationGracePeriodSeconds (Azure#23476) * Support SubPath in volume mount and mount options for azure file volume (Azure#23496) * Support SubPath in volume mount and mount options for azure file volume * update description * Add replica/container running state (Azure#23617) * add replica/container running state * spell error fix * add event trigger for Container Jobs 2023-04-01-preview (Azure#23724) * add event trigger for Container Jobs 2023-04-01-preview * prettier and avocado fix --------- Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com> * Resolve Comments for Event driven jobs (Azure#23729) * Resolve Comments for Event driven jobs * change scaling rule to azure-servicebus * update example --------- Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com> * Swagger change for mtls and runningState (Azure#23767) * 1. Add mtls properties for managed ManagedEnvironment 2. Add running state for Revision * fix * Add ContainerApp Start/Stop for 2023-04-01-preview (Azure#23497) * Add ContainerApp Start/Stop for 2023-04-01-preview * Fix validation error * Fix validation error * Change example to add location in header * Fix lint error * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Add new source controls properties (Azure#23891) * Add new source controls properties * Update examples * fix examples * Change event trigger replica properties to executions, add polling in… (Azure#23810) * Change event trigger replica properties to executions, add polling interval to event trigger, fix typos and descriptions to accommodate both apps and jobs * Fix validation errors * code review comments * Fix formatting errors * Code review comments * Add single execution history endpoint, refactor copy paste code for j… (Azure#23816) * Add single execution history endpoint, refactor copy paste code for jobName and jobExecutionName path parameters * Fix validation errors from ARM * Fix validation errors * Code review comments * Fix validation error * code review comments from Anand * Add springboard properties (Azure#23932) * Add springboard properties * CR comments * Update specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/examples/ContainerApps_CreateOrUpdate.json Co-authored-by: Jitin John <jijohn@microsoft.com> * Update specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/examples/ContainerApps_CreateOrUpdate.json Co-authored-by: Jitin John <jijohn@microsoft.com> --------- Co-authored-by: Jitin John <jijohn@microsoft.com> * Fix Lint issues in ContainerApps.json (Azure#24107) * Fix lint issue * Fix format issue * Fix json format issue * Fix model validation * Fix lint error * fix param (Azure#24166) Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com> --------- Co-authored-by: Zunli Hu <zuh@microsoft.com> Co-authored-by: njucz <740360112@qq.com> Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com> Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com> Co-authored-by: Taher Daroly <41846928+tdaroly@users.noreply.github.com> Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com> Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com> Co-authored-by: Zijian-Ju <53360473+Zijian-Ju@users.noreply.github.com> Co-authored-by: Sanchit Mehta <sanchit.mehta602@gmail.com> Co-authored-by: trajkobal <108365738+trajkobal@users.noreply.github.com> Co-authored-by: Ahmed ElSayed <ahmed@elsayed.io> Co-authored-by: Jitin John <jijohn@microsoft.com> Co-authored-by: Seris370 <38371667+Seris370@users.noreply.github.com> Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample of the new Query Metrics. You can find the Index Metrics under Index Utilization Info Metrics.
Benchmark Results