Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the azure-identity-extensions to the azure-sdk-bom #32504

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

saragluna
Copy link
Member

Description

Add the com.azure:azure-identity-extensions to the azure-sdk-bom. #32359 (comment).

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link
Member

@JonathanGiles JonathanGiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine with me - but it would be good to get @alzimmermsft and @g2vinay informed and agreeing to this too.

Copy link
Member

@alzimmermsft alzimmermsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this as azure-sdk-bom should only contain GA libraries and this is GA'd. This library will be routinely released, correct?

@saragluna
Copy link
Member Author

saragluna commented Dec 9, 2022

I'm good with this as azure-sdk-bom should only contain GA libraries and this is GA'd. This library will be routinely released, correct?

Yes, it will be routinely released and the Spring team will perform the release. (cc @stliu)

@saragluna saragluna requested a review from g2vinay December 9, 2022 02:12
@saragluna
Copy link
Member Author

@g2vinay, could you help review this PR?

@g2vinay
Copy link
Member

g2vinay commented Dec 12, 2022

@saragluna
Looks fine to me,
Just to note, since spring team will own this SDK release, it will have to be shipped as part of Azure SDK release cycles before bom release goes out.
@vcolin7 to co-ordindate with spring team and co-ordinate timely release of this SDK, as needed.

@saragluna saragluna merged commit dcbf31a into Azure:main Dec 13, 2022
@saragluna saragluna deleted the xiada/update-az-sdk-bom branch December 13, 2022 00:41
@saragluna saragluna added this to the 2023-01 milestone Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants