Add support for stable HTTP semconv #37899
Conversation
trask
force-pushed
the
stable-http-semconv
branch
2 times, most recently
from
00212a8 to
c37545a
Compare
trask
force-pushed
the
stable-http-semconv
branch
from
c37545a to
04f3a99
Compare
...er/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/SpanDataMapper.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/SpanDataMapper.java
Show resolved
Hide resolved
...er/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/SpanDataMapper.java
Show resolved
Hide resolved
...er/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/SpanDataMapper.java
Show resolved
Hide resolved
...er/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/SpanDataMapper.java
Show resolved
Hide resolved
|
API change check API changes are not detected in this pull request. |
| @@ -22,18 +22,227 @@ | |||
| // this is a copy of io.opentelemetry.semconv.trace.attributes.SemanticAttributes | |||
| // because the module that contains that class is not stable, | |||
| // so don't want to take a dependency on it | |||
There was a problem hiding this comment.
I understand it's not being stable not take it as a dependency.
If there is no new code added, i.e. it's identical, can we just use it as dependency?
This would create a dependency on us to remember to update it regularly. It's likely to be outdated.
What kind of potential issues are you concerned about?
There was a problem hiding this comment.
What kind of potential issues are you concerned about?
diamond dependency problem, this is why azure sdk architects have been pushing back on other langs including alpha libraries in their distros
| } | ||
|
|
||
| @Nullable | ||
| private static String getHttpUrlFromServerSpanStableSemconv(Attributes attributes) { |
There was a problem hiding this comment.
can you please add the link to the otel spec for this?
There was a problem hiding this comment.
I don't think there's an otel spec for how to build http url from its components, this might be the most relevent spec: https://www.rfc-editor.org/rfc/rfc2616
Adds support for stable HTTP semconv, while maintaining backcompat support for the pre-stable HTTP semconv.