Always send sample rate for logs #38930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
heyams
reviewed
Feb 24, 2024
| @@ -139,6 +139,7 @@ public void map(SpanData span, Consumer<TelemetryItem> consumer) { | |||
| consumer); | |||
| } | |||
|
|
|||
| // TODO looks like this method can be private | |||
| public TelemetryItem map(SpanData span, long itemCount) { | |||
There was a problem hiding this comment.
that's not the same method
this needs to be fixed on the agent side |
heyams
approved these changes
Feb 24, 2024
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed this in #38737