Move some CLI output parsing to stream style #39008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed a bug in how parsing `az` output was working after adding support for the new `expires_on` field. The path to fixing that required fixing how parsing the json worked, so I took the opportunity to start moving to stream-style deserialization.
billwert
requested review from
maorleger,
ahsonkhan,
KarishmaGhiya,
scottaddie and
mpodwysocki
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
alzimmermsft
approved these changes
Feb 29, 2024
...ity/azure-identity/src/main/java/com/azure/identity/implementation/models/AzureCliToken.java
Outdated
Show resolved
Hide resolved
...ity/azure-identity/src/main/java/com/azure/identity/implementation/models/AzureCliToken.java
Outdated
Show resolved
Hide resolved
...ity/azure-identity/src/main/java/com/azure/identity/implementation/models/AzureCliToken.java
Outdated
Show resolved
Hide resolved
...ity/azure-identity/src/main/java/com/azure/identity/implementation/models/AzureCliToken.java
Outdated
Show resolved
Hide resolved
...ity/azure-identity/src/main/java/com/azure/identity/implementation/models/AzureCliToken.java
Outdated
Show resolved
Hide resolved
...zure-identity/src/test/java/com/azure/identity/implementation/models/AzureCliTokenTests.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a bug in how parsing
azoutput was working after adding support for the newexpires_onfield. The path to fixing that required fixing how parsing the json worked, so I took the opportunity to start moving to stream-style deserialization.