Fixed mgmt, support convenience API for publicNetworkAccess #39357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Mgmt
v-hongli1
requested review from
weidongxu-microsoft,
haolingdong-msft,
XiaofeiCao and
ArthurMa1978
as code owners
...ervice/src/main/java/com/azure/resourcemanager/appservice/implementation/WebAppBaseImpl.java
Outdated
Show resolved
Hide resolved
...rvice/src/main/java/com/azure/resourcemanager/containerservice/models/KubernetesCluster.java
Outdated
Show resolved
Hide resolved
...manager-appservice/src/main/java/com/azure/resourcemanager/appservice/models/WebAppBase.java
Outdated
Show resolved
Hide resolved
...ourcemanager-appservice/src/test/java/com/azure/resourcemanager/appservice/WebAppsTests.java
Outdated
Show resolved
Hide resolved
...ervice/src/main/java/com/azure/resourcemanager/appservice/implementation/WebAppBaseImpl.java
Outdated
Show resolved
Hide resolved
...manager-appservice/src/main/java/com/azure/resourcemanager/appservice/models/WebAppBase.java
Outdated
Show resolved
Hide resolved
...ervice/src/main/java/com/azure/resourcemanager/appservice/implementation/WebAppBaseImpl.java
Outdated
Show resolved
Hide resolved
...in/java/com/azure/resourcemanager/containerservice/implementation/KubernetesClusterImpl.java
Outdated
Show resolved
Hide resolved
...rcemanager-cosmos/src/main/java/com/azure/resourcemanager/cosmos/models/CosmosDBAccount.java
Outdated
Show resolved
Hide resolved
...r-storage/src/test/java/com/azure/resourcemanager/storage/StorageAccountOperationsTests.java
Outdated
Show resolved
Hide resolved
...cemanager-storage/src/main/java/com/azure/resourcemanager/storage/models/StorageAccount.java
Outdated
Show resolved
Hide resolved
...cemanager-storage/src/main/java/com/azure/resourcemanager/storage/models/StorageAccount.java
Outdated
Show resolved
Hide resolved
v-hongli1
force-pushed
the
issue#39310
branch
2 times, most recently
from
b4759bd
to
5048b67
Compare
...ervice/src/test/java/com/azure/resourcemanager/containerservice/KubernetesClustersTests.java
Show resolved
Hide resolved
...ppservice/src/main/java/com/azure/resourcemanager/appservice/models/PublicNetworkAccess.java
Outdated
Show resolved
Hide resolved
...ervice/src/main/java/com/azure/resourcemanager/appservice/implementation/WebAppBaseImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
LGTM.
Please add the changelog.
For WebApp, please do a double check, that after you disable public network via SDK, the Portal UI (not JSON template) or CLI would show this as "disabled". Confirm by a screenshot please.
Reason is that WebApp (Site) has 2 model that have similar structure, but only one of them takes effect.
|
Create web app with |
weidongxu-microsoft
approved these changes
Mar 27, 2024
XiaofeiCao
reviewed
Mar 28, 2024
...rcemanager-cosmos/src/main/java/com/azure/resourcemanager/cosmos/models/CosmosDBAccount.java
Outdated
Show resolved
Hide resolved
XiaofeiCao
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relate to issue#39310
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines